coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 28: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60711/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15913/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 28 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:45:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Use stopwatch_wait_until_expired where applicable
by Mario Scheithauer (Code Review) 19 Sep '17

19 Sep '17

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/21590 ) Change subject: Use stopwatch_wait_until_expired where applicable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21590 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55 Gerrit-Change-Number: 21590 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:30:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection
by Martin Roth (Code Review) 19 Sep '17

19 Sep '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21587 ) Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetre… File src/mainboard/lenovo/x220/devicetree.cb: https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x220/devicetre… PS1, Line 171: 54 > maybe change to 14 to avoid confusion with comment? Maybe just remove it, since it isn't used if bdc detection is disabled? https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x230/devicetre… File src/mainboard/lenovo/x230/devicetree.cb: https://review.coreboot.org/#/c/21587/1/src/mainboard/lenovo/x230/devicetre… PS1, Line 173: register "bdc_gpio_num" = "54" : register "bdc_gpio_lvl" = "0" Remove? -- To view, visit https://review.coreboot.org/21587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Gerrit-Change-Number: 21587 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:16:48 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: ec/lenovo/h8: Add support for bluetooth on wifi
by Martin Roth (Code Review) 19 Sep '17

19 Sep '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21578 ) Change subject: ec/lenovo/h8: Add support for bluetooth on wifi ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/21578/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21578/1//COMMIT_MSG@11 PS1, Line 11: failes fails https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig File src/ec/lenovo/h8/Kconfig: https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig@28 PS1, Line 28: Don't care for BDC detection as wifi card does have Bluetooth Could you reword this? Maybe Force bluetooth to be enabled on wifi cards. https://review.coreboot.org/#/c/21578/1/src/ec/lenovo/h8/Kconfig@28 PS1, Line 28: " Remove trailing quote. -- To view, visit https://review.coreboot.org/21578 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23f14c937252a296dc543db49ec9e093e7e24604 Gerrit-Change-Number: 21578 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:14:53 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/lib/ubsan: Indent macros to improve readability
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21600 ) Change subject: src/lib/ubsan: Indent macros to improve readability ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60710/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15912/ : SUCCESS -- To view, visit https://review.coreboot.org/21600 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab Gerrit-Change-Number: 21600 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:09:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: timer: Add helper function stopwatch_wait_until_expired
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21589 ) Change subject: timer: Add helper function stopwatch_wait_until_expired ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60707/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15909/ : SUCCESS -- To view, visit https://review.coreboot.org/21589 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia888907028d687e3d17e5a088657086a3c839ad3 Gerrit-Change-Number: 21589 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:03:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: include/nhlt: Unbreak a long URL
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21599 ) Change subject: include/nhlt: Unbreak a long URL ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60709/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15911/ : SUCCESS -- To view, visit https://review.coreboot.org/21599 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c955e9978d56bd1a174ae48e1b69adee43986c9 Gerrit-Change-Number: 21599 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:00:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Use stopwatch_wait_until_expired where applicable
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21590 ) Change subject: Use stopwatch_wait_until_expired where applicable ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60708/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15910/ : SUCCESS -- To view, visit https://review.coreboot.org/21590 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d6c6810b91294a7e401a4a1a446218c04c98e55 Gerrit-Change-Number: 21590 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:00:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/lib/ubsan: Indent macros to improve readability
by Jonathan Neuschäfer (Code Review) 19 Sep '17

19 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21600 Change subject: src/lib/ubsan: Indent macros to improve readability ...................................................................... src/lib/ubsan: Indent macros to improve readability Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/lib/ubsan.c 1 file changed, 9 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/21600/1 diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 1cd0612..ead0e18 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -61,22 +61,20 @@ } #define ABORT_VARIANT(name, params, call) \ -__attribute__((noreturn)) \ -void __ubsan_handle_##name##_abort params; \ -__attribute__((noreturn)) \ -void __ubsan_handle_##name##_abort params { \ - __ubsan_handle_##name call; \ - __builtin_unreachable(); \ -} + __attribute__((noreturn)) void __ubsan_handle_##name##_abort params; \ + __attribute__((noreturn)) void __ubsan_handle_##name##_abort params { \ + __ubsan_handle_##name call; \ + __builtin_unreachable(); \ + } #define ABORT_VARIANT_VP(name) \ -ABORT_VARIANT(name, (void *a), (a)) + ABORT_VARIANT(name, (void *a), (a)) #define ABORT_VARIANT_VP_VP(name) \ -ABORT_VARIANT(name, (void *a, void *b), (a, b)) + ABORT_VARIANT(name, (void *a, void *b), (a, b)) #define ABORT_VARIANT_VP_IP(name) \ -ABORT_VARIANT(name, (void *a, intptr_t b), (a, b)) + ABORT_VARIANT(name, (void *a, intptr_t b), (a, b)) #define ABORT_VARIANT_VP_VP_VP(name) \ -ABORT_VARIANT(name, (void *a, void *b, void *c), (a, b, c)) + ABORT_VARIANT(name, (void *a, void *b, void *c), (a, b, c)) struct ubsan_type_mismatch_data { struct ubsan_source_location location; -- To view, visit https://review.coreboot.org/21600 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab Gerrit-Change-Number: 21600 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: include/nhlt: Unbreak a long URL
by Jonathan Neuschäfer (Code Review) 19 Sep '17

19 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21599 Change subject: include/nhlt: Unbreak a long URL ...................................................................... include/nhlt: Unbreak a long URL Change-Id: I2c955e9978d56bd1a174ae48e1b69adee43986c9 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/include/nhlt.h 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/21599/1 diff --git a/src/include/nhlt.h b/src/include/nhlt.h index f692b9a..5b72320 100644 --- a/src/include/nhlt.h +++ b/src/include/nhlt.h @@ -320,8 +320,7 @@ /* * Microphone array definitions may be found here: - * https://msdn.microsoft.com/en-us/library/windows/hardware/ - * dn613960%28v=vs.85%29.aspx + * https://msdn.microsoft.com/en-us/library/windows/hardware/dn613960%28v=vs.8… */ enum { NHLT_MIC_ARRAY_2CH_SMALL = 0xa, -- To view, visit https://review.coreboot.org/21599 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2c955e9978d56bd1a174ae48e1b69adee43986c9 Gerrit-Change-Number: 21599 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017