coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: Makefile.inc: Add left shift macro
by Jonathan Neuschäfer (Code Review) 19 Sep '17

19 Sep '17

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/21601 ) Change subject: Makefile.inc: Add left shift macro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6 Gerrit-Change-Number: 21601 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Comment-Date: Tue, 19 Sep 2017 19:32:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoney: Allow alternative placement for AMD FW directory
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21456 ) Change subject: soc/amd/stoney: Allow alternative placement for AMD FW directory ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60740/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15941/ : SUCCESS -- To view, visit https://review.coreboot.org/21456 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c95b9805c60ab6204750f7929049c7382e0c6cd Gerrit-Change-Number: 21456 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 19:26:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Makefile.inc: Add left shift macro
by Martin Roth (Code Review) 19 Sep '17

19 Sep '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21601 Change subject: Makefile.inc: Add left shift macro ...................................................................... Makefile.inc: Add left shift macro Add a macro to shift a value to the left by a specified number of bits. Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M Makefile.inc 1 file changed, 15 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/21601/1 diff --git a/Makefile.inc b/Makefile.inc index 88a9a63..cdebd1b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -113,19 +113,20 @@ # macros work on all formats understood by printf(1) # values are space separated if using more than one value # -# int-add: adds an arbitrary length list of integers -# int-subtract: subtracts the the second of two integers from the first -# int-multiply: multiplies an arbitrary length list of integers -# int-divide: divides the first integer by the second -# int-remainder: arithmetic remainder of the first number divided by the second -# int-lt: 1 if the first value is less than the second. 0 otherwise -# int-gt: 1 if the first values is greater than the second. 0 otherwise -# int-eq: 1 if the two values are equal. 0 otherwise -# int-align: align $1 to $2 units -# file-size: returns the filesize of the given file -# tolower: returns the value in all lowercase -# toupper: returns the value in all uppercase -# ws_to_under: returns the value with any whitespace changed to underscores +# int-add: adds an arbitrary length list of integers +# int-subtract: subtracts the the second of two integers from the first +# int-multiply: multiplies an arbitrary length list of integers +# int-divide: divides the first integer by the second +# int-remainder: arithmetic remainder of the first number divided by the second +# int-shift-left: Shift $1 left by $2 bits +# int-lt: 1 if the first value is less than the second. 0 otherwise +# int-gt: 1 if the first values is greater than the second. 0 otherwise +# int-eq: 1 if the two values are equal. 0 otherwise +# int-align: align $1 to $2 units +# file-size: returns the filesize of the given file +# tolower: returns the value in all lowercase +# toupper: returns the value in all uppercase +# ws_to_under: returns the value with any whitespace changed to underscores _toint=$(shell printf "%d" $1) _int-add2=$(shell expr $(call _toint,$1) + $(call _toint,$2)) int-add=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-add,$(call _int-add2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) @@ -134,6 +135,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) +int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \< $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \> $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1)))) -- To view, visit https://review.coreboot.org/21601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6 Gerrit-Change-Number: 21601 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting
by Youness Alaoui (Code Review) 19 Sep '17

19 Sep '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/21591 ) Change subject: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21591 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Gerrit-Change-Number: 21591 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 18:41:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/asrock/g41c-gs: Fix the SATA clock output on ck505
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21257 ) Change subject: mb/asrock/g41c-gs: Fix the SATA clock output on ck505 ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60715/ : SUCCESS -- To view, visit https://review.coreboot.org/21257 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b8ca91920f015ae3265871bc092023302fefdc Gerrit-Change-Number: 21257 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 16:25:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Makefile: Don't rebuild when generating tags or file list
by Patrick Georgi (Code Review) 19 Sep '17

19 Sep '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/21585 ) Change subject: Makefile: Don't rebuild when generating tags or file list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21585 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c Gerrit-Change-Number: 21585 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 16:02:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21587 ) Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60714/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15916/ : SUCCESS -- To view, visit https://review.coreboot.org/21587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Gerrit-Change-Number: 21587 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 15:35:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection
by Patrick Rudolph (Code Review) 19 Sep '17

19 Sep '17

Hello Arthur Heymans, Jonathan Neuschäfer, build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21587 to look at the new patch set (#2). Change subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection ...................................................................... mb/lenovo/x2?0/devicetree: Fix regression of BDC detection The x220 and x230 do have BDC detection, but it's broken. Disable BDC detection on those two boards, and add a comment why it doesn't work. The issue has been reported and tested on Lenovo X220. Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x230/devicetree.cb 2 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/21587/2 -- To view, visit https://review.coreboot.org/21587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Gerrit-Change-Number: 21587 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 42: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60713/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15915/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 42 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:53:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 19 Sep '17

19 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 34: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60712/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15914/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 34 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 19 Sep 2017 14:46:00 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017