coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: amd/stoneyridge: Convert MP init to mp_init_with_smm
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21498 ) Change subject: amd/stoneyridge: Convert MP init to mp_init_with_smm ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60816/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16002/ : SUCCESS -- To view, visit https://review.coreboot.org/21498 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie54295cb00c6835947456e8818a289b7eb260914 Gerrit-Change-Number: 21498 Gerrit-PatchSet: 6 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 20:32:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Make UMA memory cacheable
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21606 ) Change subject: amd/stoneyridge: Make UMA memory cacheable ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60815/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16001/ : SUCCESS -- To view, visit https://review.coreboot.org/21606 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa54d9b1c206d2ee6dc4b8f90b445a6820ceb8fd Gerrit-Change-Number: 21606 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 20:29:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Remove EXT_CONF_SUPPORT check
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21497 ) Change subject: amd/stoneyridge: Remove EXT_CONF_SUPPORT check ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60814/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16000/ : SUCCESS -- To view, visit https://review.coreboot.org/21497 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic58c47fc5f568d17f5027c96d4152b0e5b3e1d14 Gerrit-Change-Number: 21497 Gerrit-PatchSet: 6 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 20:24:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Simplify memory hole calculation
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21496 ) Change subject: amd/stoneyridge: Simplify memory hole calculation ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60813/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15999/ : SUCCESS -- To view, visit https://review.coreboot.org/21496 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id15a88897e29bff28ab7c498dc4d3818834f08b2 Gerrit-Change-Number: 21496 Gerrit-PatchSet: 5 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 20:23:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Move AmdInitEnv to ramstage
by Marshall Dawson (Code Review) 20 Sep '17

20 Sep '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21613 Change subject: amd/stoneyridge: Move AmdInitEnv to ramstage ...................................................................... amd/stoneyridge: Move AmdInitEnv to ramstage Relocate the call to AGESA in preparation for implementing postcar. This change should have no net effect as long as the ordering is maintained and AmdInitEnv stays later than CAR teardown. BUG=b:66196801 Change-Id: I0e4a5fd979b06cf50907c62d51e55db63c5e00c5 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/chip.c M src/soc/amd/stoneyridge/romstage.c 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/21613/1 diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c index 325d2ea..c230fe7 100644 --- a/src/soc/amd/stoneyridge/chip.c +++ b/src/soc/amd/stoneyridge/chip.c @@ -14,6 +14,8 @@ */ #include <chip.h> +#include <bootstate.h> +#include <console/console.h> #include <cpu/amd/mtrr.h> #include <cpu/cpu.h> #include <device/device.h> @@ -21,6 +23,8 @@ #include <soc/cpu.h> #include <soc/northbridge.h> #include <soc/southbridge.h> +#include <agesawrapper.h> +#include <agesawrapper_call.h> struct device_operations cpu_bus_ops = { .read_resources = DEVICE_NOOP, @@ -75,3 +79,11 @@ .init = &soc_init, .final = &soc_final }; + +static void do_initenv(void *unused) +{ + post_code(0x46); + AGESAWRAPPER(amdinitenv); +} + +BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, do_initenv, NULL); diff --git a/src/soc/amd/stoneyridge/romstage.c b/src/soc/amd/stoneyridge/romstage.c index 4104f53..00e4b2d 100644 --- a/src/soc/amd/stoneyridge/romstage.c +++ b/src/soc/amd/stoneyridge/romstage.c @@ -77,9 +77,6 @@ */ chipset_teardown_car(); - post_code(0x44); - AGESAWRAPPER(amdinitenv); - post_code(0x50); run_ramstage(); -- To view, visit https://review.coreboot.org/21613 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0e4a5fd979b06cf50907c62d51e55db63c5e00c5 Gerrit-Change-Number: 21613 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: mainboard: use SeaBIOS config only when it's the payload of choice
by Martin Roth (Code Review) 20 Sep '17

20 Sep '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21611 ) Change subject: mainboard: use SeaBIOS config only when it's the payload of choice ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21611/1/src/mainboard/adi/rcc-dff/Kconfig File src/mainboard/adi/rcc-dff/Kconfig: https://review.coreboot.org/#/c/21611/1/src/mainboard/adi/rcc-dff/Kconfig@72 PS1, Line 72: if PAYLOAD_SEABIOS While this works, could we use 'depends on PAYLOAD_SEABIOS' instead? We generally don't use if/endif for a single config option. -- To view, visit https://review.coreboot.org/21611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1629aecf33cb62bb1e6856ef5627748a7dc74d8a Gerrit-Change-Number: 21611 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 19:23:42 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard: use SeaBIOS config only when it's the payload of choice
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21611 ) Change subject: mainboard: use SeaBIOS config only when it's the payload of choice ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60812/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15998/ : SUCCESS -- To view, visit https://review.coreboot.org/21611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1629aecf33cb62bb1e6856ef5627748a7dc74d8a Gerrit-Change-Number: 21611 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 18:07:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: disable use of upper memory for SeaBIOS
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18905 ) Change subject: mainboard/winnet/g170: disable use of upper memory for SeaBIOS ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60810/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15997/ : SUCCESS -- To view, visit https://review.coreboot.org/18905 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69f1fe38503b0f8d6015b515637d8376726490c0 Gerrit-Change-Number: 18905 Gerrit-PatchSet: 5 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 18:02:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: drop the redundant vendor name
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21612 ) Change subject: mainboard/winnet/g170: drop the redundant vendor name ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60811/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15996/ : SUCCESS -- To view, visit https://review.coreboot.org/21612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae0a8725645b9d6321b64ccbad10633e0049d477 Gerrit-Change-Number: 21612 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 18:01:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/winnet/g170: drop the redundant vendor name
by Lubomir Rintel (Code Review) 20 Sep '17

20 Sep '17

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/21612 Change subject: mainboard/winnet/g170: drop the redundant vendor name ...................................................................... mainboard/winnet/g170: drop the redundant vendor name "WinNET WinNET G170" doesn't look too cool :( Change-Id: Iae0a8725645b9d6321b64ccbad10633e0049d477 Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M src/mainboard/winnet/g170/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/21612/1 diff --git a/src/mainboard/winnet/g170/Kconfig b/src/mainboard/winnet/g170/Kconfig index b62a44d..47e04be 100644 --- a/src/mainboard/winnet/g170/Kconfig +++ b/src/mainboard/winnet/g170/Kconfig @@ -33,7 +33,7 @@ config MAINBOARD_PART_NUMBER string - default "WinNET G170" + default "G170" config IRQ_SLOT_COUNT int -- To view, visit https://review.coreboot.org/21612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iae0a8725645b9d6321b64ccbad10633e0049d477 Gerrit-Change-Number: 21612 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017