coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 31: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60803/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15989/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 31 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:13:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: Add "truncate" command
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21608 ) Change subject: util/cbfstool: Add "truncate" command ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60801/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15987/ : SUCCESS -- To view, visit https://review.coreboot.org/21608 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c747090813898539f3428936afa9d8459adee9c Gerrit-Change-Number: 21608 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 10:13:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: use cbfstool truncate
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21609 ) Change subject: vboot: use cbfstool truncate ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60802/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15988/ : SUCCESS -- To view, visit https://review.coreboot.org/21609 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b7e1c483a69e66e82541c09582be2a71356a10 Gerrit-Change-Number: 21609 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 10:12:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: use cbfstool truncate
by Patrick Georgi (Code Review) 20 Sep '17

20 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21609 Change subject: vboot: use cbfstool truncate ...................................................................... vboot: use cbfstool truncate Instead of a shell based parser for cbfstool print -k output. BUG=b:65853903 BRANCH=none TEST=`abuild -x -t GOOGLE_KEVIN -p none` creates a valid-looking image. Change-Id: I33b7e1c483a69e66e82541c09582be2a71356a10 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/vboot/Makefile.inc 1 file changed, 4 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21609/1 diff --git a/src/vboot/Makefile.inc b/src/vboot/Makefile.inc index 0d6ce57..3128fae 100644 --- a/src/vboot/Makefile.inc +++ b/src/vboot/Makefile.inc @@ -239,17 +239,11 @@ # in the keyblock, and coreboot's vboot code clips the region_device to match, # which prevents any potential extension attacks. $(obj)/FW_MAIN_%.bin: $(obj)/coreboot.rom + $(CBFSTOOL) $< truncate -r $(basename $(notdir $@)) > $@.tmp.size $(CBFSTOOL) $< read -r $(basename $(notdir $@)) -f $@.tmp - $(CBFSTOOL) $(obj)/coreboot.rom print -k -r $(basename $(notdir $@)) | \ - tail -1 | \ - sed "s,^(empty)[[:space:]]$0x[0-9a-f]*$\tnull\t.*$$,\1," \ - > $@.tmp.size - if [ -n "$$(cat $@.tmp.size)" ] && [ $$( printf "%d" $$(cat $@.tmp.size)) -gt 0 ]; then \ - head -c $$( printf "%d" $$(cat $@.tmp.size)) $@.tmp > $@.tmp2 && \ - mv $@.tmp2 $@; \ - else \ - mv $@.tmp $@; \ - fi + head -c $$( printf "%d" $$(cat $@.tmp.size)) $@.tmp > $@.tmp2 + mv $@.tmp2 $@ + rm -f $@.tmp $@.tmp.size $(obj)/VBLOCK_%.bin: $(obj)/FW_MAIN_%.bin $(FUTILITY) $(FUTILITY) vbutil_firmware \ -- To view, visit https://review.coreboot.org/21609 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I33b7e1c483a69e66e82541c09582be2a71356a10 Gerrit-Change-Number: 21609 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/cbfstool: Add "truncate" command
by Patrick Georgi (Code Review) 20 Sep '17

20 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21608 Change subject: util/cbfstool: Add "truncate" command ...................................................................... util/cbfstool: Add "truncate" command It does the opposite to "expand", removing a trailing empty file from CBFS. It also returns the size of the CBFS post processing on stdout. BUG=b:65853903 BRANCH=none TEST=`cbfstool test.bin truncate -r FW_MAIN_A` removes the trailing empty file in FW_MAIN_A. Without a trailing empty file, the region is left alone (tested using COREBOOT which comes with a master header pointer). Change-Id: I0c747090813898539f3428936afa9d8459adee9c Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c 3 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21608/1 diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 92815f5..af4affc 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -480,6 +480,52 @@ return 0; } +int cbfs_truncate_space(struct buffer *region, uint32_t *size) +{ + if (buffer_get(region) == NULL) + return 1; + + struct cbfs_image image; + memset(&image, 0, sizeof(image)); + if (cbfs_image_from_buffer(&image, region, 0)) { + ERROR("reading CBFS failed!\n"); + return 1; + } + + *size = buffer_size(region); + + struct cbfs_file *entry, *trailer; + for (trailer = entry = buffer_get(region); + cbfs_is_valid_entry(&image, entry); + trailer = entry, + entry = cbfs_find_next_entry(&image, entry)) { + /* just iterate through */ + } + + /* trailer now points to the last valid CBFS entry's header. + * If this equals entry, there's only one file - even if that one is + * empty, we still want to keep it or we remove the entire filesystem. + * + * If that file is empty, remove it and report its header's offset as + * maximum size. + */ + if (trailer == entry) { + WARN("Empty CBFS, not truncating"); + return 1; + } + if ((strlen(trailer->filename) != 0) && + (trailer->type != htonl(CBFS_COMPONENT_NULL)) && + (trailer->type != htonl(CBFS_COMPONENT_DELETED))) { + /* nothing to truncate */ + return 1; + } + uint32_t new_size = (void *)trailer - buffer_get(region); + memset(trailer, 0xff, *size - new_size); + *size = new_size; + + return 0; +} + static size_t cbfs_file_entry_metadata_size(const struct cbfs_file *f) { return ntohl(f->offset); diff --git a/util/cbfstool/cbfs_image.h b/util/cbfstool/cbfs_image.h index 1bd74ce..5772b1b 100644 --- a/util/cbfstool/cbfs_image.h +++ b/util/cbfstool/cbfs_image.h @@ -84,6 +84,11 @@ Returns 0 on success, otherwise non-zero. */ int cbfs_expand_to_region(struct buffer *region); +/* Truncate a CBFS by removing a trailing "empty" file if it exists. + Returns 0 on success, otherwise non-zero and passes the CBFS' remaining + size in the size argument. */ +int cbfs_truncate_space(struct buffer *region, uint32_t *size); + /* Releases the CBFS image. Returns 0 on success, otherwise non-zero. */ int cbfs_image_delete(struct cbfs_image *image); diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 5e7d904..3263a91 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -1121,6 +1121,23 @@ return cbfs_expand_to_region(param.image_region); } +static int cbfs_truncate(void) +{ + struct buffer src_buf; + + /* Obtain the source region. */ + if (!partitioned_file_read_region(&src_buf, param.image_file, + param.region_name)) { + ERROR("Region not found in image: %s\n", param.source_region); + return 1; + } + + uint32_t size; + int result = cbfs_truncate_space(param.image_region, &size); + printf("0x%x\n", size); + return result; +} + static const struct command commands[] = { {"add", "H:r:f:n:t:c:b:a:yvA:gh?", cbfs_add, true, true}, {"add-flat-binary", "H:r:f:n:l:e:c:b:vA:gh?", cbfs_add_flat_binary, @@ -1142,6 +1159,7 @@ {"update-fit", "H:r:n:x:vh?", cbfs_update_fit, true, true}, {"write", "r:f:i:Fudvh?", cbfs_write, true, true}, {"expand", "r:h?", cbfs_expand, true, true}, + {"truncate", "r:h?", cbfs_truncate, true, true}, }; static struct option long_options[] = { @@ -1291,6 +1309,8 @@ "Write file into same-size [or larger] raw region\n" " read [-r fmap-region] -f file " "Extract raw region contents into binary file\n" + " truncate [-r fmap-region] " + "Truncate CBFS and print new size on stdout\n" " expand [-r fmap-region] " "Expand CBFS to span entire region\n" " update-fit [-r image,regions] -n MICROCODE_BLOB_NAME \\\n" -- To view, visit https://review.coreboot.org/21608 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0c747090813898539f3428936afa9d8459adee9c Gerrit-Change-Number: 21608 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Make SCI configurable
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21584 ) Change subject: soc/intel/apollolake: Make SCI configurable ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60800/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15986/ : SUCCESS -- To view, visit https://review.coreboot.org/21584 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a7ce7d68a6f1f16f27d0902d83dc8774e785b1 Gerrit-Change-Number: 21584 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 08:05:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Calculate soc reserved memory size
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21540 ) Change subject: soc/intel/skylake: Calculate soc reserved memory size ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60799/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15984/ : SUCCESS -- To view, visit https://review.coreboot.org/21540 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19583f7d18ca11c3a58eb61c927e5c3c3b65d2ec Gerrit-Change-Number: 21540 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 07:56:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add function to get soc reserved memory size
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21539 ) Change subject: soc/intel/common: Add function to get soc reserved memory size ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60798/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15985/ : SUCCESS -- To view, visit https://review.coreboot.org/21539 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I587a9c1ea44f2dbf67099fef03d0ff92bc44f242 Gerrit-Change-Number: 21539 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 07:43:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use EBDA area to store cbmem_top address
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21424 ) Change subject: soc/intel/skylake: Use EBDA area to store cbmem_top address ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60797/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15983/ : SUCCESS -- To view, visit https://review.coreboot.org/21424 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1a674efa5ab3a4fc076fc93236edd911d28b398 Gerrit-Change-Number: 21424 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Wed, 20 Sep 2017 07:42:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add intel common EBDA support
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21538 ) Change subject: soc/intel/common: Add intel common EBDA support ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60796/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15982/ : SUCCESS -- To view, visit https://review.coreboot.org/21538 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8355a1dd528b111f1391e6d28a9b174edddc9ca0 Gerrit-Change-Number: 21538 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 07:35:26 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017