coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mainboard: use SeaBIOS config only when it's the payload of choice
by Lubomir Rintel (Code Review) 20 Sep '17

20 Sep '17

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/21611 Change subject: mainboard: use SeaBIOS config only when it's the payload of choice ...................................................................... mainboard: use SeaBIOS config only when it's the payload of choice It makes no sense for Das U-Boot which uses the same setting. Change-Id: I1629aecf33cb62bb1e6856ef5627748a7dc74d8a Signed-off-by: Lubomir Rintel <lkundrak(a)v3.sk> --- M src/mainboard/adi/rcc-dff/Kconfig M src/mainboard/intel/littleplains/Kconfig M src/mainboard/intel/mohonpeak/Kconfig 3 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/21611/1 diff --git a/src/mainboard/adi/rcc-dff/Kconfig b/src/mainboard/adi/rcc-dff/Kconfig index 3c22a74..ab0e113 100644 --- a/src/mainboard/adi/rcc-dff/Kconfig +++ b/src/mainboard/adi/rcc-dff/Kconfig @@ -69,6 +69,8 @@ help The Mohon Peak board uses COM2 (2f8) for the serial console. +if PAYLOAD_SEABIOS + config PAYLOAD_CONFIGFILE string default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" @@ -77,4 +79,6 @@ segment. This means that USB/SATA devices will not work in SeaBIOS unless we put the SeaBIOS buffer area down in the 0x9000 segment. +endif # PAYLOAD_SEABIOS + endif # BOARD_ADI_RCC_DFF diff --git a/src/mainboard/intel/littleplains/Kconfig b/src/mainboard/intel/littleplains/Kconfig index 10cde71..8c4050e 100644 --- a/src/mainboard/intel/littleplains/Kconfig +++ b/src/mainboard/intel/littleplains/Kconfig @@ -56,6 +56,8 @@ help The Little Plains board uses COM2 (2f8) for the serial console. +if PAYLOAD_SEABIOS + config PAYLOAD_CONFIGFILE string default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" @@ -64,4 +66,6 @@ segment. This means that USB/SATA devices will not work in SeaBIOS unless we put the SeaBIOS buffer area down in the 0x9000 segment. +endif # PAYLOAD_SEABIOS + endif # BOARD_INTEL_LITTLEPLAINS diff --git a/src/mainboard/intel/mohonpeak/Kconfig b/src/mainboard/intel/mohonpeak/Kconfig index c354d1b..37a9878 100644 --- a/src/mainboard/intel/mohonpeak/Kconfig +++ b/src/mainboard/intel/mohonpeak/Kconfig @@ -69,6 +69,8 @@ help The Mohon Peak board uses COM2 (2f8) for the serial console. +if PAYLOAD_SEABIOS + config PAYLOAD_CONFIGFILE string default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" @@ -77,4 +79,6 @@ segment. This means that USB/SATA devices will not work in SeaBIOS unless we put the SeaBIOS buffer area down in the 0x9000 segment. +endif # PAYLOAD_SEABIOS + endif # BOARD_INTEL_MOHONPEAK -- To view, visit https://review.coreboot.org/21611 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1629aecf33cb62bb1e6856ef5627748a7dc74d8a Gerrit-Change-Number: 21611 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in coreboot[master]: mb/google/reef: Enable UHEPI on Reef
by Sumeet R Pawnikar (Code Review) 20 Sep '17

20 Sep '17

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/21610 ) Change subject: mb/google/reef: Enable UHEPI on Reef ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21610/1/src/mainboard/google/reef/ec.c File src/mainboard/google/reef/ec.c: https://review.coreboot.org/#/c/21610/1/src/mainboard/google/reef/ec.c@47 PS1, Line 47: MAINBOARD_EC_S3_WAKE_EVENTS Fix typo of similar entries for MAINBOARD_EC_S3_WAKE_EVENTS. Last entry should be S0ix. -- To view, visit https://review.coreboot.org/21610 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If56d1de5d1157c8cf9c418e3a9d2396ffcfcb0fd Gerrit-Change-Number: 21610 Gerrit-PatchSet: 1 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 17:24:37 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/lib/ubsan: Indent macros to improve readability
by Marc Jones (Code Review) 20 Sep '17

20 Sep '17

Marc Jones has posted comments on this change. ( https://review.coreboot.org/21600 ) Change subject: src/lib/ubsan: Indent macros to improve readability ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21600 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide4e58e584a1a2bbc1b861e2c4dd943a1aeb35ab Gerrit-Change-Number: 21600 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 17:09:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/reef: Enable UHEPI on Reef
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21610 ) Change subject: mb/google/reef: Enable UHEPI on Reef ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60808/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15994/ : SUCCESS -- To view, visit https://review.coreboot.org/21610 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If56d1de5d1157c8cf9c418e3a9d2396ffcfcb0fd Gerrit-Change-Number: 21610 Gerrit-PatchSet: 1 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:45:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Enable UHEPI on Poppy
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21086 ) Change subject: mb/google/poppy: Enable UHEPI on Poppy ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60809/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15995/ : SUCCESS -- To view, visit https://review.coreboot.org/21086 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65173104fce258d03956bbb0e80073c47fe80fab Gerrit-Change-Number: 21086 Gerrit-PatchSet: 3 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:44:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/chromeec: Enable unified host event programming interface
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21085 ) Change subject: google/chromeec: Enable unified host event programming interface ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60807/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15993/ : SUCCESS -- To view, visit https://review.coreboot.org/21085 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4917a222c79b6aaecb71d7704ffde57bf3bc99d9 Gerrit-Change-Number: 21085 Gerrit-PatchSet: 3 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:41:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/reef: Enable UHEPI on Reef
by Jenny Tc (Code Review) 20 Sep '17

20 Sep '17

Jenny Tc has uploaded this change for review. ( https://review.coreboot.org/21610 Change subject: mb/google/reef: Enable UHEPI on Reef ...................................................................... mb/google/reef: Enable UHEPI on Reef Unified Host Event Programming Interface (UHEPI) enables a unified host command EC_CMD_PROGRAM_HOST_EVENT to set/get/clear different host events. BRANCH=none BUG=b:63969337 TEST=verify masks with ec hostevent command on S0,S3,S5 and S0ix Change-Id: If56d1de5d1157c8cf9c418e3a9d2396ffcfcb0fd Signed-off-by: Jenny TC <jenny.tc(a)intel.com> --- M src/mainboard/google/reef/Kconfig M src/mainboard/google/reef/ec.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21610/1 diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 41d3dcb..1c83604 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -21,6 +21,7 @@ select USE_SAR select SAR_ENABLE select DSAR_ENABLE + select CHROMEEC_UHEPI if BOARD_GOOGLE_BASEBOARD_REEF diff --git a/src/mainboard/google/reef/ec.c b/src/mainboard/google/reef/ec.c index 59fa442..23cb35f 100644 --- a/src/mainboard/google/reef/ec.c +++ b/src/mainboard/google/reef/ec.c @@ -41,6 +41,11 @@ } else { google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S5_WAKE_EVENTS); +#if IS_ENABLED(CONFIG_CHROMEEC_UHEPI) + google_chromeec_set_lazy_wake_masks(MAINBOARD_EC_S5_WAKE_EVENTS, + MAINBOARD_EC_S3_WAKE_EVENTS, + MAINBOARD_EC_S3_WAKE_EVENTS); +#endif } /* Clear wake event mask */ -- To view, visit https://review.coreboot.org/21610 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If56d1de5d1157c8cf9c418e3a9d2396ffcfcb0fd Gerrit-Change-Number: 21610 Gerrit-PatchSet: 1 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com>

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60804/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15991/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 3 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:26:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: improve the "new layout" feature
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: improve the "new layout" feature ...................................................................... Patch Set 46: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60806/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15992/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 46 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Christopher Douglass <cdouglass.orion(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:23:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 20 Sep '17

20 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 38: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60805/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/15990/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 38 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Sep 2017 15:18:33 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017