coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mb/amd/gardenia: Remove direct AGESA header includes
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21717 ) Change subject: mb/amd/gardenia: Remove direct AGESA header includes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61184/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16346/ : SUCCESS -- To view, visit https://review.coreboot.org/21717 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ae7a435fadabf577f1f65ad4a6aa6234e9a29 Gerrit-Change-Number: 21717 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:33:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove direct AGESA header includes
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21716 ) Change subject: soc/amd/stoneyridge: Remove direct AGESA header includes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61183/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16345/ : SUCCESS -- To view, visit https://review.coreboot.org/21716 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadc516e11148048ed9bf43c7a46827793245027a Gerrit-Change-Number: 21716 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:32:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Remove direct AGESA header includes
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21715 ) Change subject: soc/amd/common: Remove direct AGESA header includes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61182/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16344/ : SUCCESS -- To view, visit https://review.coreboot.org/21715 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94140235f46a627dda99540af8619aeca3f4f157 Gerrit-Change-Number: 21715 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:30:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/kahlee: Remove direct AGESA header includes
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21714 ) Change subject: mb/google/kahlee: Remove direct AGESA header includes ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61181/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16343/ : SUCCESS -- To view, visit https://review.coreboot.org/21714 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642f5caf8a37ae4042c32fec3a92e0995193cb7a Gerrit-Change-Number: 21714 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:28:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: AMD Stoney Ridge: Add agesa_headers.h
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21713 ) Change subject: AMD Stoney Ridge: Add agesa_headers.h ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61180/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16342/ : SUCCESS -- To view, visit https://review.coreboot.org/21713 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d76811c1270ec7ef71266d84f3960919b792d4 Gerrit-Change-Number: 21713 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 02:28:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vc/amd/pi/Lib: Wrap amdlib #includes with #pragma pack(push)
by Martin Roth (Code Review) 27 Sep '17

27 Sep '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21720 Change subject: vc/amd/pi/Lib: Wrap amdlib #includes with #pragma pack(push) ...................................................................... vc/amd/pi/Lib: Wrap amdlib #includes with #pragma pack(push) This is isolated enough from the rest of the coreboot code that it can just be wrapped instead of using agesawrapper.h. BUG=b:66818758 Test=Build tested Change-Id: Ib8c0e3d69cfe59d18854234d15280f359dad99fe Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/vendorcode/amd/pi/Lib/amdlib.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21720/1 diff --git a/src/vendorcode/amd/pi/Lib/amdlib.h b/src/vendorcode/amd/pi/Lib/amdlib.h index f5eab0a..b23f735 100644 --- a/src/vendorcode/amd/pi/Lib/amdlib.h +++ b/src/vendorcode/amd/pi/Lib/amdlib.h @@ -46,8 +46,11 @@ #ifndef _AMD_LIB_H_ #define _AMD_LIB_H_ +#pragma pack(push) #include "Porting.h" #include "AMD.h" +#pragma pack(pop) + #define IOCF8 0xCF8 #define IOCFC 0xCFC -- To view, visit https://review.coreboot.org/21720 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8c0e3d69cfe59d18854234d15280f359dad99fe Gerrit-Change-Number: 21720 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove direct AGESA header includes
by Martin Roth (Code Review) 27 Sep '17

27 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21716 to look at the new patch set (#2). Change subject: soc/amd/stoneyridge: Remove direct AGESA header includes ...................................................................... soc/amd/stoneyridge: Remove direct AGESA header includes All AGESA headers should be included only through agesawrapper.h BUG=b:66818758 TEST=Build tested Change-Id: Iadc516e11148048ed9bf43c7a46827793245027a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/stoneyridge/dimmSpd.c M src/soc/amd/stoneyridge/early_setup.c M src/soc/amd/stoneyridge/imc.c M src/soc/amd/stoneyridge/include/fchec.h M src/soc/amd/stoneyridge/northbridge.c M src/soc/amd/stoneyridge/smbus_spd.c 6 files changed, 18 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/21716/2 -- To view, visit https://review.coreboot.org/21716 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iadc516e11148048ed9bf43c7a46827793245027a Gerrit-Change-Number: 21716 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/common: Remove direct AGESA header includes
by Martin Roth (Code Review) 27 Sep '17

27 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21715 to look at the new patch set (#2). Change subject: soc/amd/common: Remove direct AGESA header includes ...................................................................... soc/amd/common: Remove direct AGESA header includes All AGESA headers should be included only through agesawrapper.h BUG=b:66818758 TEST=Build tested Change-Id: I94140235f46a627dda99540af8619aeca3f4f157 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/common/BiosCallOuts.h M src/soc/amd/common/agesawrapper.c M src/soc/amd/common/agesawrapper_call.h M src/soc/amd/common/block/include/amdblocks/psp.h M src/soc/amd/common/def_callouts.c M src/soc/amd/common/heapmanager.c 6 files changed, 15 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/21715/2 -- To view, visit https://review.coreboot.org/21715 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I94140235f46a627dda99540af8619aeca3f4f157 Gerrit-Change-Number: 21715 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/kahlee: Remove direct AGESA header includes
by Martin Roth (Code Review) 27 Sep '17

27 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21714 to look at the new patch set (#2). Change subject: mb/google/kahlee: Remove direct AGESA header includes ...................................................................... mb/google/kahlee: Remove direct AGESA header includes All Stoney AGESA headers should be included only through agesawrapper.h BUG=b:66818758 TEST=Build tested Change-Id: I642f5caf8a37ae4042c32fec3a92e0995193cb7a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/kahlee/BiosCallOuts.c M src/mainboard/google/kahlee/OemCustomize.c M src/mainboard/google/kahlee/bootblock/BiosCallOuts.c M src/mainboard/google/kahlee/bootblock/OemCustomize.c M src/mainboard/google/kahlee/gpio.c 5 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/21714/2 -- To view, visit https://review.coreboot.org/21714 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I642f5caf8a37ae4042c32fec3a92e0995193cb7a Gerrit-Change-Number: 21714 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 46: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61179/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16341/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 46 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 00:50:41 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017