coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: util/board_status: do a spell check
by Jonathan Neuschäfer (Code Review) 02 Sep '17

02 Sep '17

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/21322 ) Change subject: util/board_status: do a spell check ...................................................................... Patch Set 2: Code-Review+1 Thanks -- To view, visit https://review.coreboot.org/21322 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Gerrit-Change-Number: 21322 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 13:50:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/board_status: do a spell check
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21322 ) Change subject: util/board_status: do a spell check ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15000/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59730/ : SUCCESS -- To view, visit https://review.coreboot.org/21322 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Gerrit-Change-Number: 21322 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 13:22:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/board_status: do a spell check
by Idwer Vollering (Code Review) 02 Sep '17

02 Sep '17

Hello Denis 'GNUtoo' Carikli, Sumeet R Pawnikar, Jonathan Neuschäfer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21322 to look at the new patch set (#2). Change subject: util/board_status: do a spell check ...................................................................... util/board_status: do a spell check Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> --- M util/board_status/README 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21322/2 -- To view, visit https://review.coreboot.org/21322 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Gerrit-Change-Number: 21322 Gerrit-PatchSet: 2 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arch/riscv: Document mprv_{read, write}_* functions
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21342 ) Change subject: arch/riscv: Document mprv_{read,write}_* functions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14999/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59729/ : SUCCESS -- To view, visit https://review.coreboot.org/21342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaf0cb241f0eb4de241f0983c0b32dbcc28f96480 Gerrit-Change-Number: 21342 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Anonymous Coward #1001664 Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 11:41:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/riscv: Document mprv_{read, write}_* functions
by Jonathan Neuschäfer (Code Review) 02 Sep '17

02 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21342 Change subject: arch/riscv: Document mprv_{read,write}_* functions ...................................................................... arch/riscv: Document mprv_{read,write}_* functions Change-Id: Iaf0cb241f0eb4de241f0983c0b32dbcc28f96480 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/include/vm.h 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21342/1 diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index a65aba9..dadfecd 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -91,6 +91,17 @@ ); \ } +/* + * mprv_{read,write}_* - Modified privilege memory access functions. + * + * These inline functions perform a read or write memory operation with the + * mstatus.MPRV bit set. This causes the memory protections and translation of + * the previous mode (e.g. U-mode, if we're handling a trap from U-mode) to be + * applied. + * + * The user of these functions must make sure to avoid trap loops through + * unaligned memory accesses. + */ DEFINE_MPRV_READ(mprv_read_u8, uint8_t, lbu) DEFINE_MPRV_READ(mprv_read_u16, uint16_t, lhu) DEFINE_MPRV_READ(mprv_read_u32, uint32_t, lwu) -- To view, visit https://review.coreboot.org/21342 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf0cb241f0eb4de241f0983c0b32dbcc28f96480 Gerrit-Change-Number: 21342 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Set IGD stolen memory size to 64MB
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21341 ) Change subject: soc/intel/cannonlake: Set IGD stolen memory size to 64MB ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14998/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59728/ : SUCCESS -- To view, visit https://review.coreboot.org/21341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d992e139810ad203137b34c98d1a463f88b92d Gerrit-Change-Number: 21341 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 07:25:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Set IGD stolen memory size to 64MB
by Subrata Banik (Code Review) 02 Sep '17

02 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21341 Change subject: soc/intel/cannonlake: Set IGD stolen memory size to 64MB ...................................................................... soc/intel/cannonlake: Set IGD stolen memory size to 64MB This patch to override default FSP IGD stolen memory size UPD value which ease the hardware register based CNL memory layout calculation. TEST=Ensures FSP-M UPD "IgdDvmt50PreAlloc" value is 0x2 (64MB) Change-Id: I63d992e139810ad203137b34c98d1a463f88b92d Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/romstage/romstage.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/21341/1 diff --git a/src/soc/intel/cannonlake/romstage/romstage.c b/src/soc/intel/cannonlake/romstage/romstage.c index 483f44b..a9ad1d8 100644 --- a/src/soc/intel/cannonlake/romstage/romstage.c +++ b/src/soc/intel/cannonlake/romstage/romstage.c @@ -71,6 +71,8 @@ unsigned int i; uint32_t mask = 0; + /* Set IGD stolen size to 64MB. */ + m_cfg->IgdDvmt50PreAlloc = 2; m_cfg->TsegSize = CONFIG_SMM_TSEG_SIZE; m_cfg->IedSize = CONFIG_IED_REGION_SIZE; m_cfg->SaGv = config->SaGv; -- To view, visit https://review.coreboot.org/21341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I63d992e139810ad203137b34c98d1a463f88b92d Gerrit-Change-Number: 21341 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: intel/skylake: nhlt: Add capture configuration format for IV feedback...
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21340 ) Change subject: intel/skylake: nhlt: Add capture configuration format for IV feedback from max98927 ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14997/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59727/ : SUCCESS -- To view, visit https://review.coreboot.org/21340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e Gerrit-Change-Number: 21340 Gerrit-PatchSet: 2 Gerrit-Owner: harsha p <harsha.p.n(a)intel.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 06:00:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/skylake: nhlt: Add capture configuration format for IV feedback...
by harsha p (Code Review) 02 Sep '17

02 Sep '17

Hello HARSHAPRIYA N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21340 to look at the new patch set (#2). Change subject: intel/skylake: nhlt: Add capture configuration format for IV feedback from max98927 ...................................................................... intel/skylake: nhlt: Add capture configuration format for IV feedback from max98927 This changelist adds the capture format to be set for max98927. The nhlt blob is the same but the format params for capture are different from the render. BUG=b:36724448 TEST=IV feedback data is of good quality Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e Signed-off-by: Harsha Priya <harshapriya.n(a)intel.com> --- M src/soc/intel/skylake/nhlt/max98927.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/21340/2 -- To view, visit https://review.coreboot.org/21340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e Gerrit-Change-Number: 21340 Gerrit-PatchSet: 2 Gerrit-Owner: harsha p <harsha.p.n(a)intel.corp-partner.google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/skylake: nhlt: Add capture format for IV feedback from max98927
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21340 ) Change subject: intel/skylake: nhlt: Add capture format for IV feedback from max98927 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14996/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59726/ : SUCCESS -- To view, visit https://review.coreboot.org/21340 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I135cf4479e89cd2046ff46027f94c0f71aed650e Gerrit-Change-Number: 21340 Gerrit-PatchSet: 1 Gerrit-Owner: harsha p <harsha.p.n(a)intel.corp-partner.google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 05:51:51 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017