coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: cpu/intel/slot_1: Increase CAR size
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21349 ) Change subject: cpu/intel/slot_1: Increase CAR size ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15017/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59747/ : SUCCESS -- To view, visit https://review.coreboot.org/21349 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b440e7be4f3149378db88872872012c92049c20 Gerrit-Change-Number: 21349 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:26:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/slot_1: Enable postcar frame for EARLY_CBMEM_INIT boards
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21348 ) Change subject: cpu/intel/slot_1: Enable postcar frame for EARLY_CBMEM_INIT boards ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15016/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59746/ : SUCCESS -- To view, visit https://review.coreboot.org/21348 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0407408a3b5c2cd13fd2f4c28e9a9037e8ed12 Gerrit-Change-Number: 21348 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:24:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/car/romstage.c: Drop superfluous code
by Keith Hui (Code Review) 02 Sep '17

02 Sep '17

Keith Hui has abandoned this change. ( https://review.coreboot.org/21347 ) Change subject: cpu/intel/car/romstage.c: Drop superfluous code ...................................................................... Abandoned Breaks too many other boards -- To view, visit https://review.coreboot.org/21347 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I8ac0f4c2a4642712df062f8b9001d912c7612d9a Gerrit-Change-Number: 21347 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/intel/car: Add postcar frame support and related improvements
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21329 ) Change subject: cpu/intel/car: Add postcar frame support and related improvements ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15010/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59742/ : SUCCESS -- To view, visit https://review.coreboot.org/21329 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ab996e46e4f96320143022938477a5fd2046ed7 Gerrit-Change-Number: 21329 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:07:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59745/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15015/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:06:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/slot_1: Increase CAR size
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21349 ) Change subject: cpu/intel/slot_1: Increase CAR size ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59744/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15013/ : SUCCESS -- To view, visit https://review.coreboot.org/21349 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b440e7be4f3149378db88872872012c92049c20 Gerrit-Change-Number: 21349 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:05:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21350 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59743/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15014/ : SUCCESS -- To view, visit https://review.coreboot.org/21350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie70372ccb32b0a96a8e0054b8ecadd2ea30d6221 Gerrit-Change-Number: 21350 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:05:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/car/romstage.c: Drop superfluous code
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21347 ) Change subject: cpu/intel/car/romstage.c: Drop superfluous code ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59740/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15012/ : SUCCESS -- To view, visit https://review.coreboot.org/21347 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ac0f4c2a4642712df062f8b9001d912c7612d9a Gerrit-Change-Number: 21347 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:01:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/slot_1: Enable postcar frame for EARLY_CBMEM_INIT boards
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21348 ) Change subject: cpu/intel/slot_1: Enable postcar frame for EARLY_CBMEM_INIT boards ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59741/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15011/ : SUCCESS -- To view, visit https://review.coreboot.org/21348 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee0407408a3b5c2cd13fd2f4c28e9a9037e8ed12 Gerrit-Change-Number: 21348 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:01:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by Keith Hui (Code Review) 02 Sep '17

02 Sep '17

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/21351 Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT Move select ASUS 440BX boards to EARLY_CBMEM_INIT. A LATE_CBMEM_INIT guard remains at this time to allow reverting, which can be removed in a followup as they are boot tested and confirmed stable. Developed and boot tested on p2b-ls. Brought to you by https://review.coreboot.org/c/20977/. Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p2b-d/Kconfig M src/mainboard/asus/p2b-ds/Kconfig M src/mainboard/asus/p2b-ds/romstage.c M src/mainboard/asus/p2b-f/Kconfig M src/mainboard/asus/p2b-ls/Kconfig M src/mainboard/asus/p2b-ls/romstage.c M src/mainboard/asus/p2b/Kconfig M src/mainboard/asus/p2b/romstage.c M src/mainboard/asus/p3b-f/Kconfig M src/mainboard/asus/p3b-f/romstage.c 10 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/21351/1 diff --git a/src/mainboard/asus/p2b-d/Kconfig b/src/mainboard/asus/p2b-d/Kconfig index 8bee3e1..ba2e7e0 100644 --- a/src/mainboard/asus/p2b-d/Kconfig +++ b/src/mainboard/asus/p2b-d/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p2b-ds/Kconfig b/src/mainboard/asus/p2b-ds/Kconfig index 405edca..7d69d1f 100644 --- a/src/mainboard/asus/p2b-ds/Kconfig +++ b/src/mainboard/asus/p2b-ds/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p2b-ds/romstage.c b/src/mainboard/asus/p2b-ds/romstage.c index 1d34bd9..286c47c 100644 --- a/src/mainboard/asus/p2b-ds/romstage.c +++ b/src/mainboard/asus/p2b-ds/romstage.c @@ -24,6 +24,7 @@ #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83977tf/w83977tf.h> #include <lib.h> +#include <cbmem.h> #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1) @@ -40,4 +41,7 @@ enable_smbus(); sdram_initialize(); +#if IS_ENABLED(CONFIG_EARLY_CBMEM_INIT) + cbmem_initialize_empty(); +#endif } diff --git a/src/mainboard/asus/p2b-f/Kconfig b/src/mainboard/asus/p2b-f/Kconfig index 7386ba9..b702c1b 100644 --- a/src/mainboard/asus/p2b-f/Kconfig +++ b/src/mainboard/asus/p2b-f/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p2b-ls/Kconfig b/src/mainboard/asus/p2b-ls/Kconfig index a0333a6..967ebd9 100644 --- a/src/mainboard/asus/p2b-ls/Kconfig +++ b/src/mainboard/asus/p2b-ls/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p2b-ls/romstage.c b/src/mainboard/asus/p2b-ls/romstage.c index ecfc8b8..b713224 100644 --- a/src/mainboard/asus/p2b-ls/romstage.c +++ b/src/mainboard/asus/p2b-ls/romstage.c @@ -25,6 +25,7 @@ /* FIXME: The ASUS P2B-LS has a Winbond W83977EF, actually. */ #include <superio/winbond/w83977tf/w83977tf.h> #include <lib.h> +#include <cbmem.h> #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1) @@ -41,4 +42,5 @@ enable_smbus(); sdram_initialize(); + cbmem_initialize_empty(); } diff --git a/src/mainboard/asus/p2b/Kconfig b/src/mainboard/asus/p2b/Kconfig index f2e85b6..6b934a5 100644 --- a/src/mainboard/asus/p2b/Kconfig +++ b/src/mainboard/asus/p2b/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p2b/romstage.c b/src/mainboard/asus/p2b/romstage.c index 70e4323..41c7c5e 100644 --- a/src/mainboard/asus/p2b/romstage.c +++ b/src/mainboard/asus/p2b/romstage.c @@ -24,6 +24,7 @@ #include <superio/winbond/common/winbond.h> #include <superio/winbond/w83977tf/w83977tf.h> #include <lib.h> +#include <cbmem.h> #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1) @@ -40,4 +41,7 @@ enable_smbus(); sdram_initialize(); +#if IS_ENABLED(CONFIG_EARLY_CBMEM_INIT) + cbmem_initialize_empty(); +#endif } diff --git a/src/mainboard/asus/p3b-f/Kconfig b/src/mainboard/asus/p3b-f/Kconfig index d860bb6..212aa93 100644 --- a/src/mainboard/asus/p3b-f/Kconfig +++ b/src/mainboard/asus/p3b-f/Kconfig @@ -18,7 +18,6 @@ def_bool y select CPU_INTEL_SLOT_1 select NORTHBRIDGE_INTEL_I440BX - select LATE_CBMEM_INIT select SOUTHBRIDGE_INTEL_I82371EB select SUPERIO_WINBOND_W83977TF select HAVE_PIRQ_TABLE diff --git a/src/mainboard/asus/p3b-f/romstage.c b/src/mainboard/asus/p3b-f/romstage.c index 0bb5bca..c7586dc 100644 --- a/src/mainboard/asus/p3b-f/romstage.c +++ b/src/mainboard/asus/p3b-f/romstage.c @@ -25,6 +25,7 @@ /* FIXME: The ASUS P3B-F has a Winbond W83977EF, actually. */ #include <superio/winbond/w83977tf/w83977tf.h> #include <lib.h> +#include <cbmem.h> /* FIXME: The ASUS P3B-F has a Winbond W83977EF, actually. */ #define SERIAL_DEV PNP_DEV(0x3f0, W83977TF_SP1) @@ -79,4 +80,7 @@ sdram_initialize(); disable_spd(); +#if IS_ENABLED(CONFIG_EARLY_CBMEM_INIT) + cbmem_initialize_empty(); +#endif } -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017