coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: arm/libgcc/lib1funcs.S: Workaround for clang
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21358 Change subject: arm/libgcc/lib1funcs.S: Workaround for clang ...................................................................... arm/libgcc/lib1funcs.S: Workaround for clang clang does not understand `movnes` and `subges` opcodes so use the corresponding opcodes it knows about Change-Id: I2150cc14f8a0ce7f819f29c49cb00c695448bc10 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/arch/arm/libgcc/lib1funcs.S 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/21358/1 diff --git a/src/arch/arm/libgcc/lib1funcs.S b/src/arch/arm/libgcc/lib1funcs.S index a642185..6ee1feb 100644 --- a/src/arch/arm/libgcc/lib1funcs.S +++ b/src/arch/arm/libgcc/lib1funcs.S @@ -92,7 +92,11 @@ subhs \dividend, \dividend, \divisor, lsr #3 orrhs \result, \result, \curbit, lsr #3 cmp \dividend, #0 @ Early termination? +#if IS_ENABLED(CONFIG_COMPILER_GCC) movnes \curbit, \curbit, lsr #4 @ No, any more bits to do? +#else + lsrsne \curbit, \curbit, #4 @ No, any more bits to do? +#endif movne \divisor, \divisor, lsr #4 bne 1b @@ -178,7 +182,11 @@ subhs \dividend, \dividend, \divisor, lsr #3 cmp \dividend, #1 mov \divisor, \divisor, lsr #4 +#if IS_ENABLED(CONFIG_COMPILER_GCC) subges \order, \order, #4 +#else + subsge \order, \order, #4 +#endif bge 1b tst \order, #3 -- To view, visit https://review.coreboot.org/21358 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2150cc14f8a0ce7f819f29c49cb00c695448bc10 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: armv7/Makefile.inc: Make cflags compiler agnostic
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21357 Change subject: armv7/Makefile.inc: Make cflags compiler agnostic ...................................................................... armv7/Makefile.inc: Make cflags compiler agnostic clang does not know about -Wa,-mthumb so use the right flags Change-Id: I00b7ab5ad25349382bef3cc5001f3a3297f11ca0 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/21357/1 diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.inc index fe0b446..b25a4e9 100644 --- a/src/arch/arm/armv7/Makefile.inc +++ b/src/arch/arm/armv7/Makefile.inc @@ -20,7 +20,11 @@ armv7-m_flags = -march=armv7-m $(armv7_flags) -D__COREBOOT_ARM_V7_M__ armv7-r_flags = -march=armv7-r $(armv7_flags) -D__COREBOOT_ARM_V7_R__ +ifeq ($(CONFIG_COMPILER_GCC),y) armv7_asm_flags = -Wa,-mthumb -Wa,-mimplicit-it=always -Wa,-mno-warn-deprecated +else +armv7_asm_flags = -mthumb -mimplicit-it=always +endif armv7-r_asm_flags = $(armv7-r_flags) $(armv7_asm_flags) ############################################################################### -- To view, visit https://review.coreboot.org/21357 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I00b7ab5ad25349382bef3cc5001f3a3297f11ca0 Gerrit-Change-Number: 21357 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: via/cn700: Fix clang error with missing main
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21356 Change subject: via/cn700: Fix clang error with missing main ...................................................................... via/cn700: Fix clang error with missing main According to clang, main has no prototype for bcom/winnetp680 so add it into corresponding raminit.h Change-Id: I8a55267901986757a4fa88ee13460ffbed3eeadc Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/northbridge/via/cn700/raminit.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/21356/1 diff --git a/src/northbridge/via/cn700/raminit.h b/src/northbridge/via/cn700/raminit.h index 073b253..d78ad1f 100644 --- a/src/northbridge/via/cn700/raminit.h +++ b/src/northbridge/via/cn700/raminit.h @@ -28,5 +28,6 @@ /* mainboard specific */ int spd_read_byte(unsigned device, unsigned address); +void main(unsigned long bist); #endif -- To view, visit https://review.coreboot.org/21356 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8a55267901986757a4fa88ee13460ffbed3eeadc Gerrit-Change-Number: 21356 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: device/Kconfig: Make Ada dependent on GCC toolchain
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21355 Change subject: device/Kconfig: Make Ada dependent on GCC toolchain ...................................................................... device/Kconfig: Make Ada dependent on GCC toolchain libgfxinit cannot compile with clang since it has no Ada support so disable it on clang builds Change-Id: I5db0353cdab4d24fd6832393901d8f47cf25849d Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/device/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/21355/1 diff --git a/src/device/Kconfig b/src/device/Kconfig index a5b8247..d2b3db9 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -73,7 +73,7 @@ config MAINBOARD_USE_LIBGFXINIT bool "Use libgfxinit" - depends on MAINBOARD_HAS_LIBGFXINIT + depends on MAINBOARD_HAS_LIBGFXINIT && COMPILER_GCC select HAVE_VGA_TEXT_FRAMEBUFFER select HAVE_LINEAR_FRAMEBUFFER select RAMSTAGE_LIBHWBASE -- To view, visit https://review.coreboot.org/21355 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5db0353cdab4d24fd6832393901d8f47cf25849d Gerrit-Change-Number: 21355 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: xcompile: Step closer to clang && !gcc builds
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21354 Change subject: xcompile: Step closer to clang && !gcc builds ...................................................................... xcompile: Step closer to clang && !gcc builds Fix the following error from clang invoking gcc linker with wrong arg: i386-elf-gcc: error: unrecognized command line option '--rtlib=libgcc'; did you mean '-static-libgcc'? clang-4.0: error: linker (via gcc) command failed with exit code 1 Just remove --rtlib switch from CFLAGS relating to clang Change-Id: Ife7ef6b6b47a04598fc67b40751bc59eed93b4af Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M util/xcompile/xcompile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/21354/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 408ca71..6062cff 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -446,7 +446,7 @@ # but that's more of a clang limitation. Let's be optimistic # that this will change in the future. CLANG="${clang_prefix}clang" - CFLAGS_CLANG="-target ${clang_arch}-${TABI} --rtlib=${CLANG_RUNTIME} $CFLAGS_CLANG -ccc-gcc-name ${GCC}" + CFLAGS_CLANG="-target ${clang_arch}-${TABI} $CFLAGS_CLANG -ccc-gcc-name ${GCC}" fi } -- To view, visit https://review.coreboot.org/21354 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ife7ef6b6b47a04598fc67b40751bc59eed93b4af Gerrit-Change-Number: 21354 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21353 Change subject: fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy ...................................................................... fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy To avoid error with symbol redefinition (using clang): src/drivers/intel/fsp1_0/fsp_util.c:111:22: error: invalid symbol redefinition ".global find_fsp\n\t" Rename the C function to find_fsp_dummy. Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/drivers/intel/fsp1_0/fsp_util.c M src/drivers/intel/fsp1_0/fsp_util.h 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/21353/1 diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c index fc1bd51..b10aa45 100644 --- a/src/drivers/intel/fsp1_0/fsp_util.c +++ b/src/drivers/intel/fsp1_0/fsp_util.c @@ -35,7 +35,7 @@ EFI_STATUS Status; if (fsp_header_ptr == NULL) { - fsp_header_ptr = (void *)find_fsp(); + fsp_header_ptr = (void *)find_fsp_dummy(); if ((u32)fsp_header_ptr < 0xff) { post_code(0x4F); /* output something in case there is no serial */ die("Can't find the FSP!\n"); @@ -100,7 +100,7 @@ } #endif /* __PRE_RAM__ */ -volatile u8 * find_fsp () +volatile u8 * find_fsp_dummy () { #ifdef __PRE_RAM__ @@ -213,7 +213,7 @@ void print_fsp_info(void) { if (fsp_header_ptr == NULL) - fsp_header_ptr = (void *)find_fsp(); + fsp_header_ptr = (void *)find_fsp_dummy(); if ((u32)fsp_header_ptr < 0xff) { post_code(0x4F); /* post code in case there is no serial */ diff --git a/src/drivers/intel/fsp1_0/fsp_util.h b/src/drivers/intel/fsp1_0/fsp_util.h index badd254..7eb37ac 100644 --- a/src/drivers/intel/fsp1_0/fsp_util.h +++ b/src/drivers/intel/fsp1_0/fsp_util.h @@ -25,7 +25,7 @@ void * find_and_set_fastboot_cache(void); #endif -volatile u8 * find_fsp (void); +volatile u8 * find_fsp_dummy (void); void fsp_early_init(FSP_INFO_HEADER *fsp_info); void FspNotify(u32 Phase); void FspNotifyReturnPoint(EFI_STATUS Status, VOID *HobListPtr); -- To view, visit https://review.coreboot.org/21353 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df Gerrit-Change-Number: 21353 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: abuild: Allow building with any toolchain
by Damien Zammit (Code Review) 03 Sep '17

03 Sep '17

Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21352 Change subject: abuild: Allow building with any toolchain ...................................................................... abuild: Allow building with any toolchain Adds -A --any-toolchain option to abuild This is handy for those who want to test compiling all board configs with abuild using a non-coreboot toolchain Change-Id: Idd599b0d2c324ad88ba3c83cdf3b180eb6d1fc80 Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M util/abuild/abuild 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/21352/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index e03753a..91c5bf9 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -527,6 +527,7 @@ Options:\n" [-a|--all] Build previously succeeded ports as well + [-A|--any-toolchain] Use any toolchain [-B|--blobs] Allow using binary files [--checksum <path/basefile>] Store checksums at path/basefile [-c|--cpus <numcpus>] Build on <numcpus> at the same time @@ -603,12 +604,12 @@ # shellcheck disable=SC2086 if [ "${getoptbrand:0:6}" == "getopt" ]; then # Detected GNU getopt that supports long options. - args=$(getopt -l version,verbose,quiet,help,all,target:,payloads:,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,clean,outdir:,chromeos,xmlfile:,kconfig:,dir:,root:,recursive,checksum:,timeless,exitcode -o Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K:d:R:Ie -- "$@") || exit 1 + args=$(getopt -l version,verbose,quiet,help,all,target:,payloads:,cpus:,silent,junit,config,loglevel:,remove,prefix:,update,scan-build,ccache,blobs,clang,any-toolchain,clean,outdir:,chromeos,xmlfile:,kconfig:,dir:,root:,recursive,checksum:,timeless,exitcode -o Vvqhat:p:c:sJCl:rP:uyBLAzo:xX:K:d:R:Ie -- "$@") || exit 1 eval set -- $args retval=$? else # Detected non-GNU getopt - args=$(getopt Vvqhat:p:c:sJCl:rP:uyBLzo:xX:K:d:R:Ie "$@") + args=$(getopt Vvqhat:p:c:sJCl:rP:uyBLAzo:xX:K:d:R:Ie "$@") set -- $args retval=$? fi @@ -674,6 +675,10 @@ customizing="${customizing}, blobs" configoptions="${configoptions}CONFIG_USE_BLOBS=y\n" ;; + -A|--any-toolchain) shift + customizing="${customizing}, any-toolchain" + configoptions="${configoptions}CONFIG_ANY_TOOLCHAIN=y\n" + ;; -L|--clang) shift customizing="${customizing}, clang" configoptions="${configoptions}CONFIG_COMPILER_LLVM_CLANG=y\n# CONFIG_COMPILER_GCC is not set\n" -- To view, visit https://review.coreboot.org/21352 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idd599b0d2c324ad88ba3c83cdf3b180eb6d1fc80 Gerrit-Change-Number: 21352 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>

1 0

Change in coreboot[master]: superio/winbond/*: Unify w*_set_clksel_48()
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21331 ) Change subject: superio/winbond/*: Unify w*_set_clksel_48() ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15020/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59750/ : SUCCESS -- To view, visit https://review.coreboot.org/21331 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If05e0db93375641917e538d83aacd1b50fbd033b Gerrit-Change-Number: 21331 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:44:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15019/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59749/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:34:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21350 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15018/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59748/ : SUCCESS -- To view, visit https://review.coreboot.org/21350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie70372ccb32b0a96a8e0054b8ecadd2ea30d6221 Gerrit-Change-Number: 21350 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 23:32:13 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017