Nico Huber has posted comments on this change. ( https://review.coreboot.org/21355 )
Change subject: device/Kconfig: Make Ada dependent on GCC toolchain
......................................................................
Patch Set 1: Code-Review-1
It's probably no problem at all to use a combination of Clang/GNAT.
Is there any board with libgfxinit yet that compiles with Clang? I'd
like to test it and untangle this. Should be only some changes to
`toolchain.inc`.
--
To view, visit https://review.coreboot.org/21355
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5db0353cdab4d24fd6832393901d8f47cf25849d
Gerrit-Change-Number: 21355
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 03 Sep 2017 01:09:27 +0000
Gerrit-HasComments: No
Damien Zammit has posted comments on this change. ( https://review.coreboot.org/21353 )
Change subject: fsp1_0/fsp_util: Rename find_fsp to find_fsp_dummy
......................................................................
Patch Set 1:
(1 comment)
See inline comment
https://review.coreboot.org/#/c/21353/1/src/drivers/intel/fsp1_0/fsp_util.c
File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/21353/1/src/drivers/intel/fsp1_0/fsp_util.c…
PS1, Line 112: "find_fsp:\n\t"
The problem is with this line here. The C function is called find_fsp, so you can't call an inline asm label the same thing.
--
To view, visit https://review.coreboot.org/21353
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c152f9a580fdfc40e9f6e998d2d6484b7f47df
Gerrit-Change-Number: 21353
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com>
Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 03 Sep 2017 01:00:55 +0000
Gerrit-HasComments: Yes