coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: Makefile.inc: Remove -gnatg from ADAFLAGS_common
by Nico Huber (Code Review) 03 Sep '17

03 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21365 to look at the new patch set (#2). Change subject: Makefile.inc: Remove -gnatg from ADAFLAGS_common ...................................................................... Makefile.inc: Remove -gnatg from ADAFLAGS_common It was only set by accident. `-gnatg` is a special mode for GNAT internals and libgnat (we already set it explicitly for the latter). TEST=Gave libgfxinit a shot on lenovo/t420. Change-Id: Ie56a95da2dafd014bd6152cb419a2d315e7c78c4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/21365/2 -- To view, visit https://review.coreboot.org/21365 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie56a95da2dafd014bd6152cb419a2d315e7c78c4 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: toolchain: Use xcompile proposed CFLAGS for Ada
by Nico Huber (Code Review) 03 Sep '17

03 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21363 to look at the new patch set (#3). Change subject: toolchain: Use xcompile proposed CFLAGS for Ada ...................................................................... toolchain: Use xcompile proposed CFLAGS for Ada We don't output special ADAFLAGS in xcompile but its CFLAGS are compatible with and necessary for Ada too. So use the latter and make sure we use them for libgnat too. Fixes i386 builds with x86_64 toolchain. TEST=Gave libgfxinit a shot on lenovo/t420. Change-Id: I0d13f182acfaa9bd1b608edd8a508c4ceedef3b3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/lib/gnat/Makefile.inc M toolchain.inc 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/21363/3 -- To view, visit https://review.coreboot.org/21363 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0d13f182acfaa9bd1b608edd8a508c4ceedef3b3 Gerrit-Change-Number: 21363 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Makefile.inc: Remove -gnatg from ADAFLAGS_common
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21365 ) Change subject: Makefile.inc: Remove -gnatg from ADAFLAGS_common ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15049/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59781/ : SUCCESS -- To view, visit https://review.coreboot.org/21365 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie56a95da2dafd014bd6152cb419a2d315e7c78c4 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 22:05:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Always use GCC for Ada sources
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21366 ) Change subject: Always use GCC for Ada sources ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59782/ : SUCCESS -- To view, visit https://review.coreboot.org/21366 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Gerrit-Change-Number: 21366 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 22:03:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Use xcompile proposed CFLAGS for Ada
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21363 ) Change subject: Use xcompile proposed CFLAGS for Ada ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15050/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59780/ : SUCCESS -- To view, visit https://review.coreboot.org/21363 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d13f182acfaa9bd1b608edd8a508c4ceedef3b3 Gerrit-Change-Number: 21363 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 22:01:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Always use GCC for Ada sources
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21366 ) Change subject: Always use GCC for Ada sources ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/15048/ : ABORTED https://qa.coreboot.org/job/coreboot-gerrit/59779/ : ABORTED -- To view, visit https://review.coreboot.org/21366 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Gerrit-Change-Number: 21366 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 21:51:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Always use GCC for Ada sources
by Nico Huber (Code Review) 03 Sep '17

03 Sep '17

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/21366 ) Change subject: Always use GCC for Ada sources ...................................................................... Always use GCC for Ada sources We can't use $(CC) in case it's set to Clang. TEST=Built one target with Ada sources before and after this change and verified that the same compiler commands are emitted. Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M src/lib/gnat/Makefile.inc M toolchain.inc 3 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/21366/2 -- To view, visit https://review.coreboot.org/21366 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Gerrit-Change-Number: 21366 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: Always use GCC for Ada sources
by Nico Huber (Code Review) 03 Sep '17

03 Sep '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21366 Change subject: Always use GCC for Ada sources ...................................................................... Always use GCC for Ada sources We can't use $(CC) in case it's set to Clang. TEST=Build one target with Ada sources before and after this change and verified that the same compiler commands are emitted. Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M src/lib/gnat/Makefile.inc M toolchain.inc 3 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/21366/1 diff --git a/Makefile b/Makefile index 343ec65..e85ff8e 100644 --- a/Makefile +++ b/Makefile @@ -301,13 +301,19 @@ # $4 additional dependencies ifn$(EMPTY)def $(1)-objs_$(2)_template de$(EMPTY)fine $(1)-objs_$(2)_template +ifn$(EMPTY)eq ($(filter ads adb,$(2)),) $$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $$(call create_ada_deps,$1,$$(call src-to-ali,$1,$$(1).$2)) $(KCONFIG_AUTOHEADER) $(4) + @printf " GCC $$$$(subst $$$$(obj)/,,$$$$(@))\n" + $(GCC_$(1)) \ + $$$$(ADAFLAGS_$(1)) $$$$(addprefix -I,$$$$($(1)-ada-dirs)) \ + $(3) -c -o $$$$@ $$$$< +el$(EMPTY)se +$$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $(KCONFIG_AUTOHEADER) $(4) @printf " CC $$$$(subst $$$$(obj)/,,$$$$(@))\n" $(CC_$(1)) \ - $$(if $$(filter-out ads adb,$(2)), \ - -MMD $$$$(CPPFLAGS_$(1)) $$$$(CFLAGS_$(1)) -MT $$$$(@), \ - $$$$(ADAFLAGS_$(1)) $$$$(addprefix -I,$$$$($(1)-ada-dirs))) \ + -MMD $$$$(CPPFLAGS_$(1)) $$$$(CFLAGS_$(1)) -MT $$$$(@) \ $(3) -c -o $$$$@ $$$$< +end$(EMPTY)if en$(EMPTY)def end$(EMPTY)if endef diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.inc index 5c4c510..3f22c0e 100644 --- a/src/lib/gnat/Makefile.inc +++ b/src/lib/gnat/Makefile.inc @@ -24,7 +24,7 @@ -gnatg \ -gnatpg \ -I$$(src)/lib/gnat/ \ - $$(CFLAGS_$(1)) \ + $$(GCC_CFLAGS_$(1)) \ libgnat-$(1)-y += a-unccon.ads libgnat-$(1)-y += ada.ads diff --git a/toolchain.inc b/toolchain.inc index 936eb14..f8ee875 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -120,6 +120,7 @@ $(if $(2),,$(warning *** The toolchain architecture for $(1) is unknown.) \ $(error Check your .config file for CONFIG_ARCH_$(1)_* settings)) CC_$(1) := $(CC_$(2)) +GCC_$(1) := $(GCC_CC_$(2)) LD_$(1) := $(LD_$(2)) NM_$(1) := $(NM_$(2)) AR_$(1) := $(AR_$(2)) @@ -129,7 +130,7 @@ STRIP_$(1) := $(STRIP_$(2)) READELF_$(1) := $(READELF_$(2)) CFLAGS_$(1) = $$(CFLAGS_common) $$(CFLAGS_$(2)) -ADAFLAGS_$(1) = --RTS=$$(obj)/libgnat-$(2)/ $$(ADAFLAGS_common) $$(CFLAGS_$(2)) +ADAFLAGS_$(1) = --RTS=$$(obj)/libgnat-$(2)/ $$(ADAFLAGS_common) $$(GCC_CFLAGS_$(2)) CPPFLAGS_$(1) = $$(CPPFLAGS_common) $$(CPPFLAGS_$(2)) -D__ARCH_$(2)__ COMPILER_RT_$(1) := $$(COMPILER_RT_$(2)) COMPILER_RT_FLAGS_$(1) := $$(COMPILER_RT_FLAGS_$(2)) -- To view, visit https://review.coreboot.org/21366 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9b8ea35352d74b364f09fc12d8d981ca42f8b7c8 Gerrit-Change-Number: 21366 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: Makefile.inc: Remove -gnatg from ADAFLAGS_common
by Nico Huber (Code Review) 03 Sep '17

03 Sep '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21365 Change subject: Makefile.inc: Remove -gnatg from ADAFLAGS_common ...................................................................... Makefile.inc: Remove -gnatg from ADAFLAGS_common It was only set by accident. `-gnatg` is a special mode for GNAT internals and libgnat (we already set it explicitly for the latter). Change-Id: Ie56a95da2dafd014bd6152cb419a2d315e7c78c4 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/21365/1 diff --git a/Makefile.inc b/Makefile.inc index 679e0ac..54ce995 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -365,7 +365,7 @@ CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie CFLAGS_common += -fno-delete-null-pointer-checks -fconserve-stack -ADAFLAGS_common += -gnatg -gnatp +ADAFLAGS_common += -gnatp ADAFLAGS_common += -Wuninitialized -Wall -Werror ADAFLAGS_common += -pipe -g -nostdinc ADAFLAGS_common += -Wstrict-aliasing -Wshadow -- To view, visit https://review.coreboot.org/21365 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie56a95da2dafd014bd6152cb419a2d315e7c78c4 Gerrit-Change-Number: 21365 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: Documentation: add thinkpad/codenames.csv
by build bot (Jenkins) (Code Review) 03 Sep '17

03 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21364 ) Change subject: Documentation: add thinkpad/codenames.csv ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15047/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59778/ : SUCCESS -- To view, visit https://review.coreboot.org/21364 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae44ceb29675511ec562c275e750087eca5d2f27 Gerrit-Change-Number: 21364 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 18:18:40 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017