Julius Werner has posted comments on this change. ( https://review.coreboot.org/21328 )
Change subject: google/gru: Re-enable 3V rail GPIO on Scarlet
......................................................................
Patch Set 2: Code-Review+2
Will submit this tomorrow if no further objections.
--
To view, visit https://review.coreboot.org/21328
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6037aa486b50119f2c7b859b966cadc3686e3459
Gerrit-Change-Number: 21328
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Sep 2017 18:26:45 +0000
Gerrit-HasComments: No
Marc Jones has posted comments on this change. ( https://review.coreboot.org/21333 )
Change subject: amd/stoneyridge: Remove duplicate PCI definitions
......................................................................
Patch Set 1:
Oh, I see. It was defined twice in the same file. I was thinking it was included somewhere else. Maybe just update the commit message.
--
To view, visit https://review.coreboot.org/21333
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafb10476f32505f6b4ad7b5ba6fa5de2c4648836
Gerrit-Change-Number: 21333
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Sep 2017 16:35:08 +0000
Gerrit-HasComments: No
Marc Jones has posted comments on this change. ( https://review.coreboot.org/21333 )
Change subject: amd/stoneyridge: Remove duplicate PCI definitions
......................................................................
Patch Set 1:
(1 comment)
Where are the other definitions?
https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc…
File src/soc/amd/stoneyridge/include/soc/pci_devs.h:
https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc…
PS1, Line 22:
A comment about where these are declared would be helpful here. I'd assume that they needed to be in this file with the others.
--
To view, visit https://review.coreboot.org/21333
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafb10476f32505f6b4ad7b5ba6fa5de2c4648836
Gerrit-Change-Number: 21333
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Sep 2017 16:33:24 +0000
Gerrit-HasComments: Yes