coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21400 ) Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59859/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15123/ : SUCCESS -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 08:22:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by Kevin Chiu (Code Review) 05 Sep '17

05 Sep '17

Kevin Chiu has uploaded a new patch set (#2). ( https://review.coreboot.org/21400 ) Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... google/snappy: Update EC keyboard backlight flag by SKU ID Set SKU ID by ec command EC_CMD_SET_SKU_ID to update EC keyboard backlight flag. BUG=none BRANCH=reef TEST=emerge-snappy coreboot Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/reef/mainboard.c 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/21400/2 -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by Kevin Chiu (Code Review) 05 Sep '17

05 Sep '17

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/21400 Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... google/snappy: Update EC keyboard backlight flag by SKU ID Set SKU ID by ec command EC_CMD_SET_SKU_ID to update EC keyboard backlight flag. BUG=none BRANCH=reef TEST=emerge-snappy coreboot Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h M src/mainboard/google/reef/mainboard.c 4 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/21400/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 4d47982..c382849 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -263,6 +263,29 @@ return r.flags[feature / 32] & EC_FEATURE_MASK_0(feature); } +int google_chromeec_set_sku_id(int skuid) +{ + struct chromeec_command cmd; + struct ec_params_set_sku_id set_skuid = { + .sku_id = skuid + }; + + printk(BIOS_DEBUG, "DBG: google_chromeec_set_sku_id: %d\n", skuid); + + cmd.cmd_code = EC_CMD_GET_SKU_ID; + cmd.cmd_version = 0; + cmd.cmd_size_in = sizeof(set_skuid); + cmd.cmd_data_in = &set_skuid; + cmd.cmd_data_out = NULL; + cmd.cmd_size_out = 0; + cmd.cmd_dev_index = 0; + + if (google_chromeec_command(&cmd) != 0) + return -1; + + return 0; +} + #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_RTC) int rtc_get(struct rtc_time *time) { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 60d5a32..59dae89 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -47,6 +47,7 @@ void google_chromeec_check_pd_image(int expected_type); int google_chromeec_check_feature(int feature); +int google_chromeec_set_sku_id(int skuid); uint8_t google_chromeec_calc_checksum(const uint8_t *data, int size); u16 google_chromeec_get_board_version(void); u32 google_chromeec_get_sku_id(void); diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 46ab905..6ce5db5 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -1129,6 +1129,13 @@ }; /*****************************************************************************/ +/* set sku id */ +#define EC_CMD_GET_SKU_ID 0x0F +struct ec_params_set_sku_id { + uint32_t sku_id; +} __packed; + +/*****************************************************************************/ /* Flash commands */ /* Get flash info */ diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index c6b1997..a2d3f81 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -28,6 +28,9 @@ #include <vendorcode/google/chromeos/chromeos.h> #include <variant/ec.h> #include <variant/gpio.h> +#include <ec/google/chromeec/ec.h> + +static int board_sku(void); static void mainboard_init(void *chip_info) { @@ -38,6 +41,8 @@ boardid = board_id(); printk(BIOS_INFO, "Board ID: %d\n", boardid); + google_chromeec_set_sku_id(board_sku()); + pads = variant_gpio_table(&num); gpio_configure_pads(pads, num); -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 16: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15120/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59856/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 16 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 05:24:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15119/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59855/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 05:23:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Set IGD stolen memory size to 64MB
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21341 ) Change subject: soc/intel/cannonlake: Set IGD stolen memory size to 64MB ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59849/ : SUCCESS -- To view, visit https://review.coreboot.org/21341 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63d992e139810ad203137b34c98d1a463f88b92d Gerrit-Change-Number: 21341 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 05 Sep 2017 05:01:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/braswell: Add SoC stepping identify helper
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21371 ) Change subject: soc/intel/braswell: Add SoC stepping identify helper ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15113/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59848/ : SUCCESS -- To view, visit https://review.coreboot.org/21371 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2371f85ea84df4b417e25ec8840d317cd918d5f Gerrit-Change-Number: 21371 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 02:26:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Remove duplicate PCI definitions
by Martin Roth (Code Review) 05 Sep '17

05 Sep '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21333 ) Change subject: amd/stoneyridge: Remove duplicate PCI definitions ...................................................................... Patch Set 1: Code-Review+2 You might want to mention where the other version is, and why you chose to remove this version. Or not... -- To view, visit https://review.coreboot.org/21333 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb10476f32505f6b4ad7b5ba6fa5de2c4648836 Gerrit-Change-Number: 21333 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 01:40:50 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: [WIP] gma: Implement PCI Id based generation check
by Nico Huber (Code Review) 04 Sep '17

04 Sep '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21394 Change subject: [WIP] gma: Implement PCI Id based generation check ...................................................................... [WIP] gma: Implement PCI Id based generation check We were used to sanity check the GPU generation by the audio id because that was easily accessible in MMIO space and only one number per gene- ration. It doesn't work on Skylake, though, so we read PCI ids instead. Change-Id: Id6c9cfdb00664dc2c36b2cbd13136568829297d5 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb 2 files changed, 57 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/94/21394/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index e82b133..ba08664 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -287,4 +287,46 @@ when Ironlake .. Haswell => 4, when Broadwell .. Skylake => 8); + ---------------------------------------------------------------------------- + + use type HW.Word16; + + function Is_Broadwell_H (Device_Id : Word16) return Boolean is + (Device_Id = 16#1612# or Device_Id = 16#1622# or Device_Id = 16#162a#); + + function Is_Skylake_U (Device_Id : Word16) return Boolean is + (Device_Id = 16#1906# or Device_Id = 16#1916# or Device_Id = 16#1923# or + Device_Id = 16#1926# or Device_Id = 16#1927#); + + -- Rather catch too much here than too little, + -- it's only used to distinguish generations. + function Is_GPU (Device_Id : Word16; CPU : CPU_Type; CPU_Var : CPU_Variant) + return Boolean is + (case CPU is + when Ironlake => (Device_Id and 16#fff3#) = 16#0042#, + when Sandybridge => (Device_Id and 16#ffc2#) = 16#0102#, + when Ivybridge => (Device_Id and 16#ffc3#) = 16#0142#, + when Haswell => + (case CPU_Var is + when Normal => (Device_Id and 16#ffc3#) = 16#0402# or + (Device_Id and 16#ffc3#) = 16#0d02#, + when ULT => (Device_Id and 16#ffc3#) = 16#0a02#), + when Broadwell => ((Device_Id and 16#ffc3#) = 16#1602# or + (Device_Id and 16#ffcf#) = 16#160b# or + (Device_Id and 16#ffcf#) = 16#160d#) and + (case CPU_Var is + when Normal => Is_Broadwell_H (Device_Id), + when ULT => not Is_Broadwell_H (Device_Id)), + when Broxton => (Device_Id and 16#fffe#) = 16#5a84#, + when Skylake => ((Device_Id and 16#ffc3#) = 16#1902# or + (Device_Id and 16#ffcf#) = 16#190b# or + (Device_Id and 16#ffcf#) = 16#190d# or + (Device_Id and 16#fff9#) = 16#1921#) and + (case CPU_Var is + when Normal => not Is_Skylake_U (Device_Id), + when ULT => Is_Skylake_U (Device_Id))); + + function Compatible_GPU (Device_Id : Word16) return Boolean is + (Is_GPU (Device_Id, CPU, CPU_Var)); + end HW.GFX.GMA.Config; diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 6bc6fea..5198272 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -345,6 +345,17 @@ Audio_VID_DID = 16#8086_2805#, when Ironlake => Audio_VID_DID = 16#0000_0000#); end Check_Platform; + + procedure Check_Platform_PCI (Success : out Boolean) + is + use type HW.Word16; + Vendor, Device : Word16; + begin + Dev.Read16 (Vendor, PCI.Vendor_Id); + Dev.Read16 (Device, PCI.Device_Id); + + Success := Vendor = 16#8086# and Config.Compatible_GPU (Device); + end Check_Platform_PCI; begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); @@ -374,15 +385,16 @@ Registers.Set_Register_Base (Config.Default_MMIO_Base); Success := Config.Default_MMIO_Base_Set; end if; + Check_Platform_PCI (Success); else pragma Debug (Debug.Put_Line ("WARNING: Couldn't initialize PCI dev.")); Registers.Set_Register_Base (Config.Default_MMIO_Base); Success := Config.Default_MMIO_Base_Set; - end if; - if Success then - Check_Platform (Success); + if Success then + Check_Platform (Success); + end if; end if; if not Success then -- To view, visit https://review.coreboot.org/21394 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id6c9cfdb00664dc2c36b2cbd13136568829297d5 Gerrit-Change-Number: 21394 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15112/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59847/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 20:32:53 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017