coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: Move ADDR32() hack to arch/x86
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21392 ) Change subject: Move ADDR32() hack to arch/x86 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15095/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59830/ : SUCCESS -- To view, visit https://review.coreboot.org/21392 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99ec76d591789db186e8a33774565e5a04fc4e47 Gerrit-Change-Number: 21392 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:53:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Move ADDR32() hack to arch/x86
by Philippe Mathieu-Daudé (Code Review) 04 Sep '17

04 Sep '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/21392 ) Change subject: Move ADDR32() hack to arch/x86 ...................................................................... Patch Set 1: Code-Review+1 oops I missed this in previous review, thanks -- To view, visit https://review.coreboot.org/21392 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99ec76d591789db186e8a33774565e5a04fc4e47 Gerrit-Change-Number: 21392 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:50:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21390 ) Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15097/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59829/ : SUCCESS -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:49:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nvidia/tegra*: Use xcompile for compiler prefix unless specified
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21391 ) Change subject: nvidia/tegra*: Use xcompile for compiler prefix unless specified ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15096/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59828/ : SUCCESS -- To view, visit https://review.coreboot.org/21391 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I711a73be9d35d896198664f0ae213218653f275e Gerrit-Change-Number: 21391 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:49:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59826/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15093/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:41:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59827/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15094/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:41:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Move ADDR32() hack to arch/x86
by Patrick Georgi (Code Review) 04 Sep '17

04 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21392 Change subject: Move ADDR32() hack to arch/x86 ...................................................................... Move ADDR32() hack to arch/x86 It's arch specific, so no need to pollute non-x86 with it. Change-Id: I99ec76d591789db186e8a33774565e5a04fc4e47 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M src/arch/x86/include/arch/registers.h M src/cpu/x86/smm/smmrelocate.S M src/include/compiler.h 3 files changed, 9 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21392/1 diff --git a/src/arch/x86/include/arch/registers.h b/src/arch/x86/include/arch/registers.h index 76fda28..9a618f4 100644 --- a/src/arch/x86/include/arch/registers.h +++ b/src/arch/x86/include/arch/registers.h @@ -18,6 +18,7 @@ #include <compiler.h> +#if !defined(__ASSEMBLER__) #define DOWNTO8(A) \ union { \ struct { \ @@ -57,5 +58,12 @@ uint32_t cs; uint32_t eflags; }; +#endif // !ASSEMBLER + +#if IS_ENABLED(CONFIG_COMPILER_LLVM_CLANG) +#define ADDR32(opcode) opcode +#else +#define ADDR32(opcode) addr32 opcode +#endif #endif diff --git a/src/cpu/x86/smm/smmrelocate.S b/src/cpu/x86/smm/smmrelocate.S index b3be51d..230c78d 100644 --- a/src/cpu/x86/smm/smmrelocate.S +++ b/src/cpu/x86/smm/smmrelocate.S @@ -37,7 +37,7 @@ #endif // ADDR32() macro -#include <compiler.h> +#include <arch/registers.h> #if IS_ENABLED(CONFIG_SMM_TSEG) #error "Don't use this file with TSEG." diff --git a/src/include/compiler.h b/src/include/compiler.h index 268064d..a830239 100644 --- a/src/include/compiler.h +++ b/src/include/compiler.h @@ -26,10 +26,4 @@ #define __always_unused __attribute__((unused)) #define __must_check __attribute__((warn_unused_result)) -#if IS_ENABLED(CONFIG_COMPILER_LLVM_CLANG) -#define ADDR32(opcode) opcode -#else -#define ADDR32(opcode) addr32 opcode -#endif - #endif -- To view, visit https://review.coreboot.org/21392 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I99ec76d591789db186e8a33774565e5a04fc4e47 Gerrit-Change-Number: 21392 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21390 ) Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59825/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15092/ : SUCCESS -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:28:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nvidia/tegra*: Use xcompile for compiler prefix unless specified
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21391 ) Change subject: nvidia/tegra*: Use xcompile for compiler prefix unless specified ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15091/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59824/ : SUCCESS -- To view, visit https://review.coreboot.org/21391 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I711a73be9d35d896198664f0ae213218653f275e Gerrit-Change-Number: 21391 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 15:26:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nvidia/tegra*: Use xcompile for compiler prefix unless specified
by Patrick Georgi (Code Review) 04 Sep '17

04 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21391 Change subject: nvidia/tegra*: Use xcompile for compiler prefix unless specified ...................................................................... nvidia/tegra*: Use xcompile for compiler prefix unless specified GCC_PREFIX is uncommon in the coreboot tree. If not provided, take data from .xcompile to fill in the blanks. Change-Id: I711a73be9d35d896198664f0ae213218653f275e Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M src/soc/nvidia/tegra124/lp0/Makefile M src/soc/nvidia/tegra210/lp0/Makefile 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/21391/1 diff --git a/src/soc/nvidia/tegra124/lp0/Makefile b/src/soc/nvidia/tegra124/lp0/Makefile index a6065ba..8864107 100644 --- a/src/soc/nvidia/tegra124/lp0/Makefile +++ b/src/soc/nvidia/tegra124/lp0/Makefile @@ -13,6 +13,9 @@ ## ################################################################################ +-include ../../../../../.xcompile +GCC_PREFIX?=$(CROSS_COMPILE_arm) + CC = $(GCC_PREFIX)gcc NM = $(GCC_PREFIX)nm OBJCOPY = $(GCC_PREFIX)objcopy diff --git a/src/soc/nvidia/tegra210/lp0/Makefile b/src/soc/nvidia/tegra210/lp0/Makefile index a6065ba..8864107 100644 --- a/src/soc/nvidia/tegra210/lp0/Makefile +++ b/src/soc/nvidia/tegra210/lp0/Makefile @@ -13,6 +13,9 @@ ## ################################################################################ +-include ../../../../../.xcompile +GCC_PREFIX?=$(CROSS_COMPILE_arm) + CC = $(GCC_PREFIX)gcc NM = $(GCC_PREFIX)nm OBJCOPY = $(GCC_PREFIX)objcopy -- To view, visit https://review.coreboot.org/21391 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I711a73be9d35d896198664f0ae213218653f275e Gerrit-Change-Number: 21391 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017