coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by Patrick Georgi (Code Review) 04 Sep '17

04 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21390 to look at the new patch set (#2). Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... util/testing: Also test-build tegra's lp0 resume code The regular build doesn't build it, so it fails every now and then due to changes in its dependencies. Make sure we notice these early. Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M util/testing/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/21390/2 -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21390 ) Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59823/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/15090/ : SUCCESS -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 14:56:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by Patrick Georgi (Code Review) 04 Sep '17

04 Sep '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21390 Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... util/testing: Also test-build tegra's lp0 resume code The regular build doesn't build it, so it fails every now and then due to changes in its dependencies. Make sure we notice these early. Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> --- M util/testing/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/21390/1 diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.inc index 977bc9f..3e6d0c6 100644 --- a/util/testing/Makefile.inc +++ b/util/testing/Makefile.inc @@ -80,6 +80,8 @@ unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=nvramcui MFLAGS= MAKEFLAGS= MAKETARGET=all junit.xml unset COREBOOT_BUILD_DIR;$(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=payloads/ BLD=coreinfo MFLAGS= MAKEFLAGS= MAKETARGET=defaultbuild junit.xml $(MAKE) CPUS=$(CPUS) V=$(V) Q=$(Q) BLD_DIR=util/ BLD=romcc MFLAGS= MAKEFLAGS= MAKETARGET=test junit.xml + printf 'include ../../../../../.xcompile\nGCC_PREFIX=$(subst -gcc,-,$(GCC_CC_arm))\ninclude Makefile' |$(MAKE) -C src/soc/nvidia/tegra124/lp0 -f - + printf 'include ../../../../../.xcompile\nGCC_PREFIX=$(subst -gcc,-,$(GCC_CC_arm))\ninclude Makefile' |$(MAKE) -C src/soc/nvidia/tegra210/lp0 -f - test-basic: test-lint test-tools test-abuild test-payloads test-cleanup -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: arch/x86: Enable ebda library for romstage and postcar
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21388 ) Change subject: arch/x86: Enable ebda library for romstage and postcar ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59822/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15089/ : SUCCESS -- To view, visit https://review.coreboot.org/21388 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I603800a531f56b6ebd460d5951c35a645fbfe492 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:51:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT sel...
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21389 ) Change subject: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT selected ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59821/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15088/ : SUCCESS -- To view, visit https://review.coreboot.org/21389 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I797933b9a6aea21793b3f19e45dde0ba9d536370 Gerrit-Change-Number: 21389 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:45:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Make acpi_get_sleep_type function available in romstage
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21387 ) Change subject: arch/x86: Make acpi_get_sleep_type function available in romstage ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59820/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15087/ : SUCCESS -- To view, visit https://review.coreboot.org/21387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8d143903996e5fc1a89d73c6735811a2e7395f Gerrit-Change-Number: 21387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:42:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Add support for Intel Atom C3000 SoC
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20861 ) Change subject: soc/intel/denverton_ns: Add support for Intel Atom C3000 SoC ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15085/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59819/ : SUCCESS -- To view, visit https://review.coreboot.org/20861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53d69aede3b92f1fe06b74a96cc40187fb9825f1 Gerrit-Change-Number: 20861 Gerrit-PatchSet: 6 Gerrit-Owner: Mariusz Szafranski Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: FEI WANG <wangfei.jimei(a)gmail.com> Gerrit-Reviewer: Fei Wang Gerrit-Reviewer: Mariusz Szafranski Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:35:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT sel...
by Subrata Banik (Code Review) 04 Sep '17

04 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21389 Change subject: device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT selected ...................................................................... device: Skip EBDA area reinitialization if CONFIG_EARLY_EBDA_INIT selected CONFIG_EARLY_EBDA_INIT kconfig will ensure EBDA area getting initialized during romstage. This patch ensures that dev_initializa() shouldn't override already initialized EBDA area, hence just skip reinitialization part based on kconfig option. Change-Id: I797933b9a6aea21793b3f19e45dde0ba9d536370 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/device/device.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/21389/1 diff --git a/src/device/device.c b/src/device/device.c index 35f5909..4c6b6f9 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -1179,8 +1179,13 @@ printk(BIOS_INFO, "Initializing devices...\n"); #if IS_ENABLED(CONFIG_ARCH_X86) - /* Ensure EBDA is prepared before Option ROMs. */ - setup_default_ebda(); + /* + * Initialize EBDA area in ramstage if early + * initialization is not done. + */ + if (!IS_ENABLED(CONFIG_EARLY_EBDA_INIT)) + /* Ensure EBDA is prepared before Option ROMs. */ + setup_default_ebda(); #endif /* First call the mainboard init. */ -- To view, visit https://review.coreboot.org/21389 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I797933b9a6aea21793b3f19e45dde0ba9d536370 Gerrit-Change-Number: 21389 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: arch/x86: Enable ebda library for romstage and postcar
by Subrata Banik (Code Review) 04 Sep '17

04 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21388 Change subject: arch/x86: Enable ebda library for romstage and postcar ...................................................................... arch/x86: Enable ebda library for romstage and postcar This patch provides a kconfig option as EARLY_EBDA_INIT to ensures user can make use of EBDA library even during early boot stages like romstage, postcar. Change-Id: I603800a531f56b6ebd460d5951c35a645fbfe492 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/21388/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index dbfb881..0da44bd 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -131,6 +131,14 @@ help Increase this value if preram cbmem console is getting truncated +config EARLY_EBDA_INIT + bool "Initialize EBDA area early in romstage" + default n + help + Initialize BIOS EBDA area early in romstage to allow bootloader to + use this region for storing data which can be available across + various stages. + config PC80_SYSTEM bool default y if ARCH_X86 diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 5f184c5..4f84b28 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -209,6 +209,7 @@ romstage-y += cbmem.c romstage-y += cbfs_and_run.c romstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += cpu_common.c +romstage-$(CONFIG_EARLY_EBDA_INIT) += ebda.c romstage-y += memcpy.c romstage-y += memmove.c romstage-y += memset.c @@ -281,6 +282,7 @@ postcar-y += boot.c postcar-y += cbfs_and_run.c postcar-y += cpu_common.c +postcar-$(CONFIG_EARLY_EBDA_INIT) += ebda.c postcar-y += exit_car.S postcar-y += memcpy.c postcar-y += memmove.c -- To view, visit https://review.coreboot.org/21388 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I603800a531f56b6ebd460d5951c35a645fbfe492 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: arch/x86: Make acpi_get_sleep_type function available in romstage
by Subrata Banik (Code Review) 04 Sep '17

04 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21387 Change subject: arch/x86: Make acpi_get_sleep_type function available in romstage ...................................................................... arch/x86: Make acpi_get_sleep_type function available in romstage acpi_is_wakeup_s3() function is available in both romstage and ramstage (include/arch/acpi.h) but helper function acpi_get_sleep_type() is only available during ramstage(ENV_RAMSTAGE). This patch to make acpi_get_sleep_type() available in romstage as well. Change-Id: Iac8d143903996e5fc1a89d73c6735811a2e7395f Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/acpi_s3.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/21387/1 diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c index a0a7905..cfca362 100644 --- a/src/arch/x86/acpi_s3.c +++ b/src/arch/x86/acpi_s3.c @@ -25,11 +25,6 @@ #include <rules.h> #include <symbols.h> -#if ENV_RAMSTAGE - -/* This is filled with acpi_is_wakeup() call early in ramstage. */ -static int acpi_slp_type = -1; - #if IS_ENABLED(CONFIG_EARLY_CBMEM_INIT) int acpi_get_sleep_type(void) { @@ -42,6 +37,11 @@ } #endif +#if ENV_RAMSTAGE + +/* This is filled with acpi_is_wakeup() call early in ramstage. */ +static int acpi_slp_type = -1; + static void acpi_handoff_wakeup(void) { if (acpi_slp_type < 0) -- To view, visit https://review.coreboot.org/21387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iac8d143903996e5fc1a89d73c6735811a2e7395f Gerrit-Change-Number: 21387 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017