coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mainboard/intel/harcuvar: Add support for Intel Harcuvar CRB
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20862 ) Change subject: mainboard/intel/harcuvar: Add support for Intel Harcuvar CRB ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15086/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59818/ : SUCCESS -- To view, visit https://review.coreboot.org/20862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088833e36e2d22d1fe1610b8dca1454092da511a Gerrit-Change-Number: 20862 Gerrit-PatchSet: 6 Gerrit-Owner: Mariusz Szafranski Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: FEI WANG <wangfei.jimei(a)gmail.com> Gerrit-Reviewer: Fei Wang Gerrit-Reviewer: Mariusz Szafranski Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:30:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/intel/gma: Power up legacy VGA block early
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21386 ) Change subject: drivers/intel/gma: Power up legacy VGA block early ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15084/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59817/ : SUCCESS -- To view, visit https://review.coreboot.org/21386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fe144765e2b2acd9f6b76db375cae5b8feb5489 Gerrit-Change-Number: 21386 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 13:28:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/intel/gma: Power up legacy VGA block early
by Nico Huber (Code Review) 04 Sep '17

04 Sep '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21386 Change subject: drivers/intel/gma: Power up legacy VGA block early ...................................................................... drivers/intel/gma: Power up legacy VGA block early This is required at least on Skylake to be able to configure text mode. 3rdparty/libgfxinit is also updated by the single commit: 42fb2d065d gma: Add procedure to power up legacy VGA block Change-Id: I2fe144765e2b2acd9f6b76db375cae5b8feb5489 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M 3rdparty/libgfxinit M src/drivers/intel/gma/text_fb/gma.adb 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/21386/1 diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 3a0e2a0..42fb2d0 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 3a0e2a08f5489f3bb5c6e9f97b903e6e10c31a6c +Subproject commit 42fb2d065d604eb08c723ac6b96aeebb4c84cbd3 diff --git a/src/drivers/intel/gma/text_fb/gma.adb b/src/drivers/intel/gma/text_fb/gma.adb index ded7b9e..8f61d1d 100644 --- a/src/drivers/intel/gma/text_fb/gma.adb +++ b/src/drivers/intel/gma/text_fb/gma.adb @@ -47,6 +47,7 @@ Max_Pipe => Primary); if configs (Primary).Port /= Disabled then + HW.GFX.GMA.Power_Up_VGA; vga_io_init; vga_textmode_init; -- To view, visit https://review.coreboot.org/21386 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2fe144765e2b2acd9f6b76db375cae5b8feb5489 Gerrit-Change-Number: 21386 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma: Add procedure to power up legacy VGA block
by Nico Huber (Code Review) 04 Sep '17

04 Sep '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21323 ) Change subject: gma: Add procedure to power up legacy VGA block ...................................................................... gma: Add procedure to power up legacy VGA block Calling this is necessary for VGA text mode on at least Skylake, where the legacy VGA registers are inaccessible otherwise. Change-Id: I48ba1738bcc7babd4e666e5266f775dcd06b2a3f Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/21323 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved Nico Huber: Verified diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index 99a1276..6bc6fea 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -438,6 +438,23 @@ ---------------------------------------------------------------------------- + procedure Power_Up_VGA + is + Fake_Config : constant Pipe_Configs := + (Primary => + (Port => Analog, + Framebuffer => HW.GFX.Default_FB, + Mode => HW.GFX.Invalid_Mode), + others => + (Port => Disabled, + Framebuffer => HW.GFX.Default_FB, + Mode => HW.GFX.Invalid_Mode)); + begin + Power_And_Clocks.Power_Up (Cur_Configs, Fake_Config); + end Power_Up_VGA; + + ---------------------------------------------------------------------------- + function FB_First_Page (FB : Framebuffer_Type) return Natural is (Natural (FB.Offset / GTT_Page_Size)); function FB_Pages (FB : Framebuffer_Type) return Natural is diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index 3771804..cd992b8 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -80,6 +80,12 @@ Global => (Input => Init_State); pragma Warnings (GNATprove, On, "unused variable ""Write_Delay"""); + pragma Warnings (GNATprove, Off, "subprogram ""Power_Up_VGA"" has no effect", + Reason => "Effect depends on the platform compiled for"); + procedure Power_Up_VGA + with + Pre => Is_Initialized; + procedure Update_Outputs (Configs : Pipe_Configs); pragma Warnings (GNATprove, Off, "subprogram ""Dump_Configs"" has no effect", -- To view, visit https://review.coreboot.org/21323 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I48ba1738bcc7babd4e666e5266f775dcd06b2a3f Gerrit-Change-Number: 21323 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma: Add procedure to power up legacy VGA block
by Nico Huber (Code Review) 04 Sep '17

04 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21323 ) Change subject: gma: Add procedure to power up legacy VGA block ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21323 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48ba1738bcc7babd4e666e5266f775dcd06b2a3f Gerrit-Change-Number: 21323 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 04 Sep 2017 12:51:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15071/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59804/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 08:50:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15072/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59805/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 08:48:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/board_status: do a spell check
by Idwer Vollering (Code Review) 04 Sep '17

04 Sep '17

Idwer Vollering has submitted this change and it was merged. ( https://review.coreboot.org/21322 ) Change subject: util/board_status: do a spell check ...................................................................... util/board_status: do a spell check Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Reviewed-on: https://review.coreboot.org/21322 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M util/board_status/README 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Jonathan Neuschäfer: Looks good to me, but someone else must approve Sumeet R Pawnikar: Looks good to me, approved diff --git a/util/board_status/README b/util/board_status/README index 2337826..c462e7d 100644 --- a/util/board_status/README +++ b/util/board_status/README @@ -9,13 +9,13 @@ time, to do that go in "Console --->" in make menuconfig, then set "Default console log level" to SPEW -Rereference: ------------- +Reference: +---------- [1] in make menuconfig you should have: [*] Use CMOS for configuration values This option is also known as CONFIG_USE_OPTION_TABLE in Kconfig. -Information trough SSH +Information through SSH ====================== -board_status.sh can gather information trough ssh with the -r +board_status.sh can gather information through ssh with the -r option. When using "-r <host>", The script will attempt to log into @@ -28,10 +28,10 @@ board_status.sh expects the remote host to have the following programs in its path: cbmem, dmesg -Boot log gathering trough a serial port +Boot log gathering through a serial port ======================================= When using -s </dev/xxx>, board_status.sh starts by retrieving the -boot log trough the serial port. +boot log through the serial port. To produce such logs, power off the board, run board_status.sh with the right arguments, power on the board. -- To view, visit https://review.coreboot.org/21322 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie39be471851586076343b8e9454a9140d4664b8d Gerrit-Change-Number: 21322 Gerrit-PatchSet: 3 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21350 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15068/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59801/ : SUCCESS -- To view, visit https://review.coreboot.org/21350 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie70372ccb32b0a96a8e0054b8ecadd2ea30d6221 Gerrit-Change-Number: 21350 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 05:49:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 04 Sep '17

04 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: mainboard/asus/p[23]b*: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15069/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59802/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Sep 2017 05:47:53 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017