coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/cannonlake: add uart.c to verstage
by Nick Vaccaro (Code Review) 06 Sep '17

06 Sep '17

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/21410 Change subject: soc/intel/cannonlake: add uart.c to verstage ...................................................................... soc/intel/cannonlake: add uart.c to verstage Adds uart.c to verstage. Change-Id: I2d420ff7437d25a596ee9a120964f8d4bc413bc4 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/soc/intel/cannonlake/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21410/1 diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.inc index dba04a8..5b7fe88 100644 --- a/src/soc/intel/cannonlake/Makefile.inc +++ b/src/soc/intel/cannonlake/Makefile.inc @@ -46,6 +46,7 @@ verstage-y += gspi.c verstage-y += spi.c +verstage-$(CONFIG_DRIVERS_UART_8250MEM) += uart.c CPPFLAGS_common += -I$(src)/soc/intel/cannonlake/include/fsp20 CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp2_0/cannonlake -- To view, visit https://review.coreboot.org/21410 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d420ff7437d25a596ee9a120964f8d4bc413bc4 Gerrit-Change-Number: 21410 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15146/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59888/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 9 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 00:38:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 18: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15145/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59889/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 18 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 00:35:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Common ACPI
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block: Common ACPI ...................................................................... Patch Set 27: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15144/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59887/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 27 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 23:04:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/testing: Also test-build tegra's lp0 resume code
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21390 ) Change subject: util/testing: Also test-build tegra's lp0 resume code ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59886/ : SUCCESS -- To view, visit https://review.coreboot.org/21390 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0603b22887487d8871611d91e6f8ab0ec210bff1 Gerrit-Change-Number: 21390 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 20:26:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/sgx: Fix null pointer dereference warning from klocwork
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21408 ) Change subject: soc/intel/common/sgx: Fix null pointer dereference warning from klocwork ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15143/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59885/ : SUCCESS -- To view, visit https://review.coreboot.org/21408 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc9c68652b074c666c86456183460ca38a886ed Gerrit-Change-Number: 21408 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 19:41:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/sgx: Fix null pointer dereference warning from klocwork
by Pratikkumar V Prajapati (Code Review) 05 Sep '17

05 Sep '17

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/21408 Change subject: soc/intel/common/sgx: Fix null pointer dereference warning from klocwork ...................................................................... soc/intel/common/sgx: Fix null pointer dereference warning from klocwork Fix the warnings of klocwork scan. e.g. "Pointer 'dev' checked for NULL at line 158 will be dereferenced at line 159" Change-Id: I6cc9c68652b074c666c86456183460ca38a886ed Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/soc/intel/common/block/sgx/sgx.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21408/1 diff --git a/src/soc/intel/common/block/sgx/sgx.c b/src/soc/intel/common/block/sgx/sgx.c index da84ea6..ec1b638 100644 --- a/src/soc/intel/common/block/sgx/sgx.c +++ b/src/soc/intel/common/block/sgx/sgx.c @@ -41,7 +41,13 @@ msr_t prmrr_mask; msr_t msr; device_t dev = SA_DEV_ROOT; + assert(dev != NULL); config_t *conf = dev->chip_info; + + if (!conf) { + printk(BIOS_ERR, "SGX: failed to get chip_info\n"); + return; + } if (!conf->sgx_enable || !is_sgx_supported()) return; @@ -159,6 +165,11 @@ config_t *conf = dev->chip_info; const void *microcode_patch = intel_mp_current_microcode(); + if (!conf) { + printk(BIOS_ERR, "SGX: failed to get chip_info\n"); + return; + } + if (!conf->sgx_enable || !is_sgx_supported() || !is_prmrr_set()) { printk(BIOS_ERR, "SGX: pre-conditions not met\n"); return; -- To view, visit https://review.coreboot.org/21408 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6cc9c68652b074c666c86456183460ca38a886ed Gerrit-Change-Number: 21408 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Change in coreboot[master]: nvidia/tegra*: Use xcompile for compiler prefix unless specified
by Julius Werner (Code Review) 05 Sep '17

05 Sep '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/21391 ) Change subject: nvidia/tegra*: Use xcompile for compiler prefix unless specified ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21391 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I711a73be9d35d896198664f0ae213218653f275e Gerrit-Change-Number: 21391 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Sep 2017 18:46:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/x86: Enable ebda library for romstage and postcar
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21388 ) Change subject: arch/x86: Enable ebda library for romstage and postcar ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15142/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59882/ : SUCCESS -- To view, visit https://review.coreboot.org/21388 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I603800a531f56b6ebd460d5951c35a645fbfe492 Gerrit-Change-Number: 21388 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 05 Sep 2017 18:44:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, skylake}: Fix null pointer dereference in klocwork
by build bot (Jenkins) (Code Review) 05 Sep '17

05 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21404 ) Change subject: soc/intel/{cannonlake,skylake}: Fix null pointer dereference in klocwork ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59884/ : SUCCESS -- To view, visit https://review.coreboot.org/21404 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c74ca410d1a0ba48634ec9928a0d9d1cc20e27a Gerrit-Change-Number: 21404 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-Comment-Date: Tue, 05 Sep 2017 18:34:51 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017