coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15186/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59931/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 08:57:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 22: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15185/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59932/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 22 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 08:54:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21418 ) Change subject: siemens/mc_apl1: Move SCI to IRQ 10 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15184/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59930/ : SUCCESS -- To view, visit https://review.coreboot.org/21418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 08:12:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10
by Mario Scheithauer (Code Review) 06 Sep '17

06 Sep '17

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/21418 Change subject: siemens/mc_apl1: Move SCI to IRQ 10 ...................................................................... siemens/mc_apl1: Move SCI to IRQ 10 IRQ 9 is used for different purpose on this mainboard so move SCI away to IRQ 10. Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/mainboard.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/21418/1 diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index 4c90aff..f57047b 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -20,7 +20,9 @@ #include <hwilib.h> #include <i210.h> #include <intelblocks/lpc_lib.h> +#include <intelblocks/pmclib.h> #include <soc/pci_devs.h> +#include <soc/pm.h> #include <string.h> #include "brd_gpio.h" #include "ptn3460.h" @@ -112,6 +114,19 @@ gpio_configure_pads(pads, num); } +static void mainboard_enable(device_t dev) +{ + uint32_t irq_sel_2 = 0; + uintptr_t pmc_bar = 0; + + /* Route SCI to IRQ 10 to free IRQ 9 slot. */ + pmc_bar = soc_read_pmc_base(); + irq_sel_2 = read32((void *)pmc_bar + IRQ_SEL_2); + irq_sel_2 &= ~SCI_IRQ_MASK; + irq_sel_2 |= SCI_IRQ_10; + write32((void *)(pmc_bar + IRQ_SEL_2), irq_sel_2); +} + static void mainboard_final(void *chip_info) { int status; @@ -132,5 +147,6 @@ struct chip_operations mainboard_ops = { .init = mainboard_init, + .enable_dev = mainboard_enable, .final = mainboard_final, }; -- To view, visit https://review.coreboot.org/21418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Make SCI selectable
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21417 ) Change subject: soc/intel/apollolake: Make SCI selectable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15183/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59929/ : SUCCESS -- To view, visit https://review.coreboot.org/21417 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice665ae3d8b74d344ffcb33b6ef6ff9631b2b093 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 07:47:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Make SCI selectable
by Mario Scheithauer (Code Review) 06 Sep '17

06 Sep '17

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/21417 Change subject: soc/intel/apollolake: Make SCI selectable ...................................................................... soc/intel/apollolake: Make SCI selectable The System Control Interrupt is route per default to IRQ 9. Some mainboards use IRQ 9 for different purpose. Therefore it is necessary to make the SCI selectable on Apollo Lake. Change-Id: Ice665ae3d8b74d344ffcb33b6ef6ff9631b2b093 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/soc/intel/apollolake/acpi.c M src/soc/intel/apollolake/include/soc/pm.h 2 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/21417/1 diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c index 1826b48..2386051 100644 --- a/src/soc/intel/apollolake/acpi.c +++ b/src/soc/intel/apollolake/acpi.c @@ -17,11 +17,13 @@ #include <arch/acpi.h> #include <arch/acpigen.h> +#include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> #include <cbmem.h> #include <cpu/x86/smm.h> #include <cpu/cpu.h> +#include <intelblocks/pmclib.h> #include <soc/acpi.h> #include <soc/intel/common/acpi.h> #include <soc/iomap.h> @@ -52,7 +54,39 @@ static int acpi_sci_irq(void) { - int sci_irq = 9; + static int8_t sci_irq = 0; + uint32_t irq_sel_2 = 0; + uintptr_t pmc_bar = 0; + + /* If this function was already called, just return the stored value. */ + if (sci_irq) + return sci_irq; + + /* Read PMC base address from soc. */ + pmc_bar = soc_read_pmc_base(); + irq_sel_2 = read32((void *)pmc_bar + IRQ_SEL_2) & SCI_IRQ_MASK; + + switch (irq_sel_2) { + case SCI_IRQ_9: + sci_irq = (irq_sel_2 >> 24) & 0xF; + break; + case SCI_IRQ_10: + case SCI_IRQ_11: + sci_irq = ((irq_sel_2 >> 24) & 0xF) + 9; + break; + case SCI_IRQ_20: + case SCI_IRQ_21: + case SCI_IRQ_22: + case SCI_IRQ_23: + sci_irq = ((irq_sel_2 >> 24) & 0xF) + 16; + break; + default: + printk(BIOS_ERR, "Invalid SCI route! Defaulting to IRQ9.\n"); + sci_irq = 9; + break; + } + + printk(BIOS_DEBUG, "SCI is IRQ%d\n", sci_irq); return sci_irq; } diff --git a/src/soc/intel/apollolake/include/soc/pm.h b/src/soc/intel/apollolake/include/soc/pm.h index 3be3955..5c066df 100644 --- a/src/soc/intel/apollolake/include/soc/pm.h +++ b/src/soc/intel/apollolake/include/soc/pm.h @@ -180,6 +180,16 @@ #define GPIO_GPE_CFG 0x1050 #define GPE0_DWX_MASK 0xf #define GPE0_DW_SHIFT(x) (4 + 4*(x)) +#define IRQ_SEL_2 0x106C +#define SCI_IRQ_MASK 0x0F000000 +#define SCI_IRQ_9 (9 << 24) +#define SCI_IRQ_10 (1 << 24) +#define SCI_IRQ_11 (2 << 24) +#define SCI_IRQ_DIS (3 << 24) +#define SCI_IRQ_20 (4 << 24) +#define SCI_IRQ_21 (5 << 24) +#define SCI_IRQ_22 (6 << 24) +#define SCI_IRQ_23 (7 << 24) #if IS_ENABLED(CONFIG_SOC_INTEL_GLK) #define PMC_GPE_N_95_64 8 -- To view, visit https://review.coreboot.org/21417 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ice665ae3d8b74d344ffcb33b6ef6ff9631b2b093 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15182/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59928/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 07:32:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15180/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59925/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 07:27:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by Bill XIE (Code Review) 06 Sep '17

06 Sep '17

Hello Nicola Corna, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21416 to look at the new patch set (#2). Change subject: ifdtool: refactor region-permission-related feature ...................................................................... ifdtool: refactor region-permission-related feature combine lock_descriptor() and unlock_descriptor() into one function fmba_toggle_permission(), and port the feature to "remove the ME/TXE Read/Write permissions to the other regions (-d)" of me_cleaner (https://github.com/corna/me_cleaner/) here. Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 96 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/21416/2 -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 21: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15179/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59926/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 21 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 07:25:16 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017