coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15196/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59942/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:18:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 23: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15194/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59940/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 23 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:12:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15195/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59941/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 14 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:11:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/chromeec: Enable unified host event programming interface
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21085 ) Change subject: google/chromeec: Enable unified host event programming interface ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15191/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59938/ : SUCCESS -- To view, visit https://review.coreboot.org/21085 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4917a222c79b6aaecb71d7704ffde57bf3bc99d9 Gerrit-Change-Number: 21085 Gerrit-PatchSet: 2 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:08:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Reef/Poppy: Enable UHEPI on Reef and Poppy
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21086 ) Change subject: Reef/Poppy: Enable UHEPI on Reef and Poppy ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15192/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59937/ : SUCCESS -- To view, visit https://review.coreboot.org/21086 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65173104fce258d03956bbb0e80073c47fe80fab Gerrit-Change-Number: 21086 Gerrit-PatchSet: 2 Gerrit-Owner: Jenny Tc <jenny.tc(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shamile Khan <shamile.khan(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:03:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Make SCI selectable
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21417 ) Change subject: soc/intel/apollolake: Make SCI selectable ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15193/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59939/ : SUCCESS -- To view, visit https://review.coreboot.org/21417 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice665ae3d8b74d344ffcb33b6ef6ff9631b2b093 Gerrit-Change-Number: 21417 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:01:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10
by Werner Zeh (Code Review) 06 Sep '17

06 Sep '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/21418 ) Change subject: siemens/mc_apl1: Move SCI to IRQ 10 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… File src/mainboard/siemens/mc_apl1/mainboard.c: https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… PS1, Line 117: static void mainboard_enable(device_t dev) > If we have the functionality into mainboard_init(), then FSP-S (SiliconInit OK, then this is the way to do it. Thanks for clarifying that. -- To view, visit https://review.coreboot.org/21418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:00:04 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10
by Mario Scheithauer (Code Review) 06 Sep '17

06 Sep '17

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/21418 ) Change subject: siemens/mc_apl1: Move SCI to IRQ 10 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… File src/mainboard/siemens/mc_apl1/mainboard.c: https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… PS1, Line 117: static void mainboard_enable(device_t dev) > Do we really want to have it in the mainboard_enable() function? Are there If we have the functionality into mainboard_init(), then FSP-S (SiliconInit) will re-route the SCI. If we use mainboard_final(), then it’s too late for acpi_sci_irq(). -- To view, visit https://review.coreboot.org/21418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 10:42:37 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/mc_apl1: Move SCI to IRQ 10
by Werner Zeh (Code Review) 06 Sep '17

06 Sep '17

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/21418 ) Change subject: siemens/mc_apl1: Move SCI to IRQ 10 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… File src/mainboard/siemens/mc_apl1/mainboard.c: https://review.coreboot.org/#/c/21418/1/src/mainboard/siemens/mc_apl1/mainb… PS1, Line 117: static void mainboard_enable(device_t dev) Do we really want to have it in the mainboard_enable() function? Are there any reasons against mainboard_init() or even mainboard_final()? How big is the chance that FSP will re-route the SCI in one of it's callbacks? -- To view, visit https://review.coreboot.org/21418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b8bfbdd8ab9498197603572b0e533f405a340fe Gerrit-Change-Number: 21418 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 09:17:11 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15187/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59933/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 3 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 08:57:24 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017