coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: agesa/f15tn: Remove unnecessary logic op
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21361 ) Change subject: agesa/f15tn: Remove unnecessary logic op ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15211/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59957/ : SUCCESS -- To view, visit https://review.coreboot.org/21361 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d7dfaa5fcf0e95acd650e4c129e0899b5d68f09 Gerrit-Change-Number: 21361 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:20:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: rmodtool: Increase limit on number of symbols
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21360 ) Change subject: rmodtool: Increase limit on number of symbols ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15210/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59956/ : SUCCESS -- To view, visit https://review.coreboot.org/21360 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ad2f64c452cef2e7bf957f766600891cb5ae798 Gerrit-Change-Number: 21360 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:18:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/x86/sipi_vector.S: Use correct op suffix
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21359 ) Change subject: cpu/x86/sipi_vector.S: Use correct op suffix ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15209/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59955/ : SUCCESS -- To view, visit https://review.coreboot.org/21359 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82da5a9065b382e182dc7d502c7dca2fc717543b Gerrit-Change-Number: 21359 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:18:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: armv7/Makefile.inc: Make cflags compiler agnostic
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21357 ) Change subject: armv7/Makefile.inc: Make cflags compiler agnostic ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15207/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59954/ : SUCCESS -- To view, visit https://review.coreboot.org/21357 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00b7ab5ad25349382bef3cc5001f3a3297f11ca0 Gerrit-Change-Number: 21357 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:16:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Select EARLY_EBDA_INIT config for early EBDA usage...
by Subrata Banik (Code Review) 06 Sep '17

06 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21424 Change subject: soc/intel/skylake: Select EARLY_EBDA_INIT config for early EBDA usage [WIP] ...................................................................... soc/intel/skylake: Select EARLY_EBDA_INIT config for early EBDA usage [WIP] Change-Id: Ib1a674efa5ab3a4fc076fc93236edd911d28b398 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/skylake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/21424/1 diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index b045486..91ccb6e 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -29,6 +29,7 @@ select COLLECT_TIMESTAMPS select COMMON_FADT select CPU_INTEL_FIRMWARE_INTERFACE_TABLE + select EARLY_EBDA_INIT select GENERIC_GPIO_LIB select HAVE_HARD_RESET select HAVE_INTEL_FIRMWARE -- To view, visit https://review.coreboot.org/21424 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1a674efa5ab3a4fc076fc93236edd911d28b398 Gerrit-Change-Number: 21424 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Create acpi_get_sleep_type() to get previous sleep...
by Subrata Banik (Code Review) 06 Sep '17

06 Sep '17

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/21423 Change subject: soc/intel/skylake: Create acpi_get_sleep_type() to get previous sleep state ...................................................................... soc/intel/skylake: Create acpi_get_sleep_type() to get previous sleep state This patch implements soc function to get previous sleep state using chipset_power_state global structure. acpi_get_sleep_type is needed in PRE_RAM stage when soc selects CONFIG_EARLY_EBDA_INIT kconfig option. Change-Id: I79acbfc09c8d255fbf9d73e49e8c7764f3f3fac6 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/skylake/romstage/power_state.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/21423/1 diff --git a/src/soc/intel/skylake/romstage/power_state.c b/src/soc/intel/skylake/romstage/power_state.c index 61851a5..f58ef16 100644 --- a/src/soc/intel/skylake/romstage/power_state.c +++ b/src/soc/intel/skylake/romstage/power_state.c @@ -14,6 +14,7 @@ * GNU General Public License for more details. */ +#include <arch/acpi.h> #include <arch/early_variables.h> #include <arch/io.h> #include <cbmem.h> @@ -35,12 +36,17 @@ static struct chipset_power_state power_state CAR_GLOBAL; +static struct chipset_power_state *get_power_state(void) +{ + return (struct chipset_power_state *)car_get_var_ptr(&power_state); +} + static void migrate_power_state(int is_recovery) { struct chipset_power_state *ps_cbmem; struct chipset_power_state *ps_car; - ps_car = car_get_var_ptr(&power_state); + ps_car = get_power_state(); ps_cbmem = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*ps_cbmem)); if (ps_cbmem == NULL) { @@ -129,7 +135,7 @@ { uint16_t tcobase; uint8_t *pmc; - struct chipset_power_state *ps = car_get_var_ptr(&power_state); + struct chipset_power_state *ps = get_power_state(); tcobase = smbus_tco_regs(); @@ -161,6 +167,14 @@ return ps; } +int acpi_get_sleep_type(void) +{ + struct chipset_power_state *ps; + + ps = get_power_state(); + return ps->prev_sleep_state; +} + int vboot_platform_is_resuming(void) { return acpi_sleep_from_pm1(inl(ACPI_BASE_ADDRESS + PM1_CNT)) == ACPI_S3; -- To view, visit https://review.coreboot.org/21423 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I79acbfc09c8d255fbf9d73e49e8c7764f3f3fac6 Gerrit-Change-Number: 21423 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: arm/libgcc/lib1funcs.S: Workaround for clang
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21358 ) Change subject: arm/libgcc/lib1funcs.S: Workaround for clang ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15208/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59953/ : SUCCESS -- To view, visit https://review.coreboot.org/21358 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2150cc14f8a0ce7f819f29c49cb00c695448bc10 Gerrit-Change-Number: 21358 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:12:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: via/cn700: Fix clang error with missing main
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21356 ) Change subject: via/cn700: Fix clang error with missing main ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15206/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59952/ : SUCCESS -- To view, visit https://review.coreboot.org/21356 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a55267901986757a4fa88ee13460ffbed3eeadc Gerrit-Change-Number: 21356 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:11:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/d525mw: SuperIO is W83627DHG
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21422 ) Change subject: mainboard/intel/d525mw: SuperIO is W83627DHG ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15202/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59948/ : SUCCESS -- To view, visit https://review.coreboot.org/21422 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c80878966193011ac30dfb8d4fadf3318285058 Gerrit-Change-Number: 21422 Gerrit-PatchSet: 1 Gerrit-Owner: Philipp Ammann Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:08:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/Kconfig: Make Ada dependent on GCC toolchain
by build bot (Jenkins) (Code Review) 06 Sep '17

06 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21355 ) Change subject: device/Kconfig: Make Ada dependent on GCC toolchain ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15205/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59951/ : SUCCESS -- To view, visit https://review.coreboot.org/21355 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5db0353cdab4d24fd6832393901d8f47cf25849d Gerrit-Change-Number: 21355 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Sep 2017 13:07:24 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017