coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/cyan: Fix Touchscreen Interrupt
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21122 ) Change subject: google/cyan: Fix Touchscreen Interrupt ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59181/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14512/ : SUCCESS -- To view, visit https://review.coreboot.org/21122 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c4b029851e321feeedf713186976fbec42dd82e Gerrit-Change-Number: 21122 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:55:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Increase RO coreboot size on flash
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21124 ) Change subject: google/cyan: Increase RO coreboot size on flash ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59183/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14514/ : SUCCESS -- To view, visit https://review.coreboot.org/21124 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86bea538a7b82367ea6ddbd3fe3efb1b1c0078d Gerrit-Change-Number: 21124 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:55:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Support reading Memory strap GPIOs to select SPD
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21166 ) Change subject: google/cyan: Support reading Memory strap GPIOs to select SPD ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59186/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14517/ : SUCCESS -- To view, visit https://review.coreboot.org/21166 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2ba9ec5be111b9c30360ffde41a2c644a69ecae Gerrit-Change-Number: 21166 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:53:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/reks: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21128 ) Change subject: google/reks: add new board as variant of cyan baseboard ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59187/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14518/ : SUCCESS -- To view, visit https://review.coreboot.org/21128 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac9e2b5661aa33e12927f4cb84ebaee36522a385 Gerrit-Change-Number: 21128 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:49:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/braswell: select GENERIC_GPIO_LIB
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21125 ) Change subject: soc/intel/braswell: select GENERIC_GPIO_LIB ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59182/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14513/ : SUCCESS -- To view, visit https://review.coreboot.org/21125 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9b0c6513f10b252bf0a5014bd038d24879421be Gerrit-Change-Number: 21125 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:49:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: convert to variant configuration
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21126 ) Change subject: google/cyan: convert to variant configuration ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59185/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14516/ : SUCCESS -- To view, visit https://review.coreboot.org/21126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Gerrit-Change-Number: 21126 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:47:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Remove support for pre-EVT board
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21123 ) Change subject: google/cyan: Remove support for pre-EVT board ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59180/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14511/ : SUCCESS -- To view, visit https://review.coreboot.org/21123 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b32da8064e0743cc9c5df02ce7d3441459ee8f Gerrit-Change-Number: 21123 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:42:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21127 ) Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59184/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14515/ : SUCCESS -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 23:38:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Disable L1 sub state
by Matt DeVillier (Code Review) 23 Aug '17

23 Aug '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21174 Change subject: google/cyan: Disable L1 sub state ...................................................................... google/cyan: Disable L1 sub state Adapted from Chromium commit dc59188. Disable L1 sub state to prevent WiFi randomly disappear condition. Original-Change-Id: I8975bb4bbbc2fc89b91b06ae02716367890c672d Original-Signed-off-by: T.H. Lin <T.H_Lin(a)quantatw.com> Original-Reviewed-by: Rajat Jain <rajatja(a)chromium.org> Original-Reviewed-by: Vincent Wang <vwang(a)chromium.org> Oriignal-Tested-by: TH Lin <t.h_lin(a)quanta.corp-partner.google.com> Change-Id: I51a1bcca6431e6bc28baf9b09433cec13db925c3 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/21174/1 diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index fdeac63..6cfec3a 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -13,7 +13,6 @@ select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_BRASWELL select HAVE_ACPI_RESUME - select PCIEXP_L1_SUB_STATE config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES -- To view, visit https://review.coreboot.org/21174 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I51a1bcca6431e6bc28baf9b09433cec13db925c3 Gerrit-Change-Number: 21174 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: T.H. Lin <T.H_Lin(a)quantatw.com>

1 0

Change in coreboot[master]: soc/intel/braswell: Put SERIRQ in quiet mode
by Matt DeVillier (Code Review) 23 Aug '17

23 Aug '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21173 Change subject: soc/intel/braswell: Put SERIRQ in quiet mode ...................................................................... soc/intel/braswell: Put SERIRQ in quiet mode Cherry-pick from Chromium commit 1568761. Original-Change-Id: If459c3cab8fb7ca13d8bff3173a94855ec2e2810 Original-Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Original-Tested-by: Kevin K Wong <kevin.k.wong(a)intel.com> Original-Reviewed-by: Duncan Laurie <dlaurie(a)google.com> Original-Tested-by: Aseda Aboagye <aaboagye(a)chromium.org> Change-Id: Ibb2e6d316adcfcc0d56d242501aac9c4c0bbdf62 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/braswell/include/soc/lpc.h M src/soc/intel/braswell/southcluster.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/21173/1 diff --git a/src/soc/intel/braswell/include/soc/lpc.h b/src/soc/intel/braswell/include/soc/lpc.h index 93ece3d..d842274 100644 --- a/src/soc/intel/braswell/include/soc/lpc.h +++ b/src/soc/intel/braswell/include/soc/lpc.h @@ -30,6 +30,9 @@ #define UART_CONT 0x80 #define RCBA 0xf0 +/* Memory Mapped IO in LPC bridge */ +#define SCNT 0x10 +#define SCNT_MODE (1 << 7) /* When cleared, SERIRQ is in quiet mode */ #define RID_A_STEPPING_START 1 #define RID_B_STEPPING_START 5 diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index 0e2d5e2..e033123 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -38,6 +38,18 @@ #include <soc/spi.h> #include <spi-generic.h> #include <stdint.h> +#include <reg_script.h> + +static const struct reg_script ops[] = { + REG_MMIO_RMW32(ILB_BASE_ADDRESS + SCNT, + ~SCNT_MODE, 0), /* put LPC SERIRQ in Quiet Mode */ + REG_SCRIPT_END +}; + +static void enable_serirq_quiet_mode(void) +{ + reg_script_run(ops); +} static inline void add_mmio_resource(device_t dev, int i, unsigned long addr, unsigned long size) @@ -503,6 +515,7 @@ write32(spi + LVSCC, cfg.lvscc | VCL); } spi_init(); + enable_serirq_quiet_mode(); printk(BIOS_DEBUG, "Finalizing SMM.\n"); outb(APM_CNT_FINALIZE, APM_CNT); -- To view, visit https://review.coreboot.org/21173 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb2e6d316adcfcc0d56d242501aac9c4c0bbdf62 Gerrit-Change-Number: 21173 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017