coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/cyan: Increase RO coreboot size on flash
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21124 ) Change subject: google/cyan: Increase RO coreboot size on flash ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59207/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14537/ : SUCCESS -- To view, visit https://review.coreboot.org/21124 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86bea538a7b82367ea6ddbd3fe3efb1b1c0078d Gerrit-Change-Number: 21124 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:40:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Remove support for pre-EVT board
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21123 ) Change subject: google/cyan: Remove support for pre-EVT board ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59209/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14539/ : SUCCESS -- To view, visit https://review.coreboot.org/21123 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b32da8064e0743cc9c5df02ce7d3441459ee8f Gerrit-Change-Number: 21123 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:39:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: convert to variant configuration
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21126 ) Change subject: google/cyan: convert to variant configuration ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59208/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14538/ : SUCCESS -- To view, visit https://review.coreboot.org/21126 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9 Gerrit-Change-Number: 21126 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:37:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21127 ) Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... Patch Set 7: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59211/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14542/ : SUCCESS -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 7 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:33:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/reks: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21128 ) Change subject: google/reks: add new board as variant of cyan baseboard ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59210/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14540/ : SUCCESS -- To view, visit https://review.coreboot.org/21128 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac9e2b5661aa33e12927f4cb84ebaee36522a385 Gerrit-Change-Number: 21128 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:32:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: Use GpioInt for Keyboard IRQ
by Matt DeVillier (Code Review) 24 Aug '17

24 Aug '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/21177 Change subject: google/cyan: Use GpioInt for Keyboard IRQ ...................................................................... google/cyan: Use GpioInt for Keyboard IRQ Cherry-pick from Chromium commit a162348. Remove the hard coded IRQ number for the keyboard interrupt. IRQ number can change based upon the gpio bank index ordering. Hence pass the gpio bank and index number so that kernel calculates the IRQ number. Original-Change-Id: Icfe5c3995007164bf617575b541758c18ee63a1d Original-Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Original-Reviewed-by: Duncan Laurie <dlaurie(a)chromium.org> Change-Id: I81ff19e3060c533ee76023c7651f741294e9db30 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/cyan/acpi/superio.asl M src/mainboard/google/cyan/onboard.h 2 files changed, 4 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/21177/1 diff --git a/src/mainboard/google/cyan/acpi/superio.asl b/src/mainboard/google/cyan/acpi/superio.asl index 34ae348..f2a7fc0 100644 --- a/src/mainboard/google/cyan/acpi/superio.asl +++ b/src/mainboard/google/cyan/acpi/superio.asl @@ -23,8 +23,8 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ /* Override default IRQ settings */ -#define SIO_EC_PS2K_IRQ Interrupt(ResourceConsumer, Edge, ActiveLow){\ - BOARD_I8042_IRQ} +#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\ + "\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX } /* ACPI code for EC SuperIO functions */ #include <ec/google/chromeec/acpi/superio.asl> diff --git a/src/mainboard/google/cyan/onboard.h b/src/mainboard/google/cyan/onboard.h index 1347d41..19b61df 100644 --- a/src/mainboard/google/cyan/onboard.h +++ b/src/mainboard/google/cyan/onboard.h @@ -30,16 +30,11 @@ * GPSE_SIZE = 86 */ -/* - * gpio based irq for kbd, 17th index in North Bank - * MAX_DIRECT_IRQ + GPSW_SIZE + 18 - */ -/* ToDO: change kbd irq to gpio bank index */ -#define BOARD_I8042_IRQ 182 #define BOARD_TOUCH_IRQ 184 #define BOARD_PRE_EVT_TOUCH_IRQ 156 - +/* KBD: Gpio index in N bank */ +#define BOARD_I8042_GPIO_INDEX 17 /* SCI: Gpio index in N bank */ #define BOARD_SCI_GPIO_INDEX 15 /* Trackpad: Gpio index in N bank */ -- To view, visit https://review.coreboot.org/21177 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I81ff19e3060c533ee76023c7651f741294e9db30 Gerrit-Change-Number: 21177 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() on normal boot
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() on normal boot ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59206/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14536/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:04:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/edgar: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21127 ) Change subject: google/edgar: add new board as variant of cyan baseboard ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59205/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14535/ : SUCCESS -- To view, visit https://review.coreboot.org/21127 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58548cbbc85828f37c0023e8aa9e09bdca612659 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 03:31:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable support for DPTF
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21147 ) Change subject: mainboard/google/fizz: Enable support for DPTF ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59204/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14534/ : SUCCESS -- To view, visit https://review.coreboot.org/21147 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d125a763f539158aa425fbba1d8a000a3465ca Gerrit-Change-Number: 21147 Gerrit-PatchSet: 4 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 02:26:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Support Nefario rev0
by Open Source Software for Rockchip SoCs(moved to https://github.com/rockchip-linux/) (Code Review) 24 Aug '17

24 Aug '17

Open Source Software for Rockchip SoCs(moved to https://github.com/rockchip-linux/) has posted comments on this change. ( https://review.coreboot.org/21176 ) Change subject: google/gru: Support Nefario rev0 ...................................................................... Patch Set 1: Verified+1, the BT can work with it on nefario. -- To view, visit https://review.coreboot.org/21176 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I350db2c080f2e41ae56413f5f895557978ef0ba8 Gerrit-Change-Number: 21176 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Open Source Software for Rockchip SoCs(moved to https://github.com/rockchip-linux/) Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 01:58:52 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017