coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: google/kahlee: Increase preram console size
by Marshall Dawson (Code Review) 24 Aug '17

24 Aug '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/21186 Change subject: google/kahlee: Increase preram console size ...................................................................... google/kahlee: Increase preram console size Increase the default setting to add more CAR space for the early console. This avoids truncation of the log. BUG=b:64980233 Change-Id: Ia11d1c6c186a7025510c240206743ebe8d741461 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/21186/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index ad12d8c..aa4ba8b 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -70,4 +70,10 @@ depends on CHROMEOS default "KAHLEE TEST 6421" +config PRERAM_CBMEM_CONSOLE_SIZE + hex + default 0x1200 + help + Increase this value if preram cbmem console is getting truncated + endif # BOARD_GOOGLE_KAHLEE -- To view, visit https://review.coreboot.org/21186 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia11d1c6c186a7025510c240206743ebe8d741461 Gerrit-Change-Number: 21186 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: amd/padmelon: Begin new mainboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21035 ) Change subject: amd/padmelon: Begin new mainboard ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59227/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14557/ : SUCCESS -- To view, visit https://review.coreboot.org/21035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81d20adc675df1c0b00b9becd68d418740c005c Gerrit-Change-Number: 21035 Gerrit-PatchSet: 12 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 16:04:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Begin new mainboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21035 ) Change subject: amd/padmelon: Begin new mainboard ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59226/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14556/ : SUCCESS -- To view, visit https://review.coreboot.org/21035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81d20adc675df1c0b00b9becd68d418740c005c Gerrit-Change-Number: 21035 Gerrit-PatchSet: 11 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 15:42:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Begin new mainboard
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21035 ) Change subject: amd/padmelon: Begin new mainboard ...................................................................... Patch Set 10: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59225/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14555/ : SUCCESS -- To view, visit https://review.coreboot.org/21035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81d20adc675df1c0b00b9becd68d418740c005c Gerrit-Change-Number: 21035 Gerrit-PatchSet: 10 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 14:55:38 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: gma: Move a warning justification to spec
by Nico Huber (Code Review) 24 Aug '17

24 Aug '17

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/20170 ) Change subject: gma: Move a warning justification to spec ...................................................................... gma: Move a warning justification to spec Makes us compatible with SPARK 2017. Change-Id: Ie325b913e329ceb522a320c76f1cccf512e5b79f Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/70/20170/2 -- To view, visit https://review.coreboot.org/20170 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie325b913e329ceb522a320c76f1cccf512e5b79f Gerrit-Change-Number: 20170 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken(a)codelabs.ch> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() on normal boot
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() on normal boot ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59224/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14554/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 12:08:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t430s: Fix expresscard's hotplug capability
by Arthur Heymans (Code Review) 24 Aug '17

24 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: mb/lenovo/t430s: Fix expresscard's hotplug capability ...................................................................... Patch Set 1: (1 comment) Nice catch. The southbridge code should probably be improved to handle this instead having to work around it in devicetree. https://review.coreboot.org/#/c/21178/1/src/mainboard/lenovo/t430s/devicetr… File src/mainboard/lenovo/t430s/devicetree.cb: https://review.coreboot.org/#/c/21178/1/src/mainboard/lenovo/t430s/devicetr… PS1, Line 74: pcie_port_coalesce Remapping happens due to this. -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 10:18:48 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/lenovo/t430s: Fix expresscard's hotplug capability
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21178 ) Change subject: mb/lenovo/t430s: Fix expresscard's hotplug capability ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59213/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14543/ : SUCCESS -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 07:24:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t430s: Fix expresscard's hotplug capability
by Bill XIE (Code Review) 24 Aug '17

24 Aug '17

Bill XIE has uploaded this change for review. ( https://review.coreboot.org/21178 Change subject: mb/lenovo/t430s: Fix expresscard's hotplug capability ...................................................................... mb/lenovo/t430s: Fix expresscard's hotplug capability lspci(8) shows that if pci-e port 1c.0 is set to off, port 1c.1 will shifted to 1c.0, and rest ports could be reasoned by analogy, so that the flag inside "pcie_hotplug_map" of devicetree.cb will not applied to the expresscard slot. In order to workaround this, we may modify "pcie_hotplug_map" to affect the shifted 1c.1, or leave the original 1c.0 on. Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M 3rdparty/vboot M src/mainboard/lenovo/t430s/devicetree.cb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/21178/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 8c4b828..8b71425 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 8c4b828502d8c6c7112286720dddfd30c92a968e +Subproject commit 8b71425257d251858410de71efcf389df8b200d2 diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb index 6846879..d11ad60 100644 --- a/src/mainboard/lenovo/t430s/devicetree.cb +++ b/src/mainboard/lenovo/t430s/devicetree.cb @@ -64,7 +64,7 @@ register "gen2_dec" = "0x0c15e1" register "gen4_dec" = "0x0c06a1" - register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 1, 0, 0, 0, 0, 0, 0 }" register "xhci_switchable_ports" = "0xf" register "superspeed_capable_ports" = "0xf" -- To view, visit https://review.coreboot.org/21178 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad Gerrit-Change-Number: 21178 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com>

1 0

Change in coreboot[master]: google/cyan: Use GpioInt for Keyboard IRQ
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21177 ) Change subject: google/cyan: Use GpioInt for Keyboard IRQ ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59212/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14541/ : SUCCESS -- To view, visit https://review.coreboot.org/21177 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81ff19e3060c533ee76023c7651f741294e9db30 Gerrit-Change-Number: 21177 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 04:42:26 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017