coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mb/google/eve: Add imon and vmon params for Max98927 codec
by harsha p (Code Review) 24 Aug '17

24 Aug '17

harsha p has uploaded this change for review. ( https://review.coreboot.org/21196 Change subject: mb/google/eve: Add imon and vmon params for Max98927 codec ...................................................................... mb/google/eve: Add imon and vmon params for Max98927 codec This patch adds imon and vmon slot numbers for Maxim 98927 driver. These values are used to confiure IV feedback for audio playback on speakers. BUG=b:36724448 TEST=After boot, the register dump for Max98927 codecs should have imon and vmon slots numbers set in 0x1e register. Change-Id: I4382da4f984507d147751c168e8177b58c88a70f --- M src/mainboard/google/eve/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/21196/1 diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index b6cb848..1507ce4 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -274,6 +274,8 @@ device pci 19.2 on chip drivers/i2c/max98927 register "interleave_mode" = "1" + register "vmon_slot_no" = "4" + register "imon_slot_no" = "5" register "uid" = "0" register "desc" = ""Right Speaker Amp"" register "name" = ""MAXR"" @@ -281,6 +283,8 @@ end chip drivers/i2c/max98927 register "interleave_mode" = "1" + register "vmon_slot_no" = "6" + register "imon_slot_no" = "7" register "uid" = "1" register "desc" = ""Left Speaker Amp"" register "name" = ""MAXL"" -- To view, visit https://review.coreboot.org/21196 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4382da4f984507d147751c168e8177b58c88a70f Gerrit-Change-Number: 21196 Gerrit-PatchSet: 1 Gerrit-Owner: harsha p <harsha.p.n(a)intel.corp-partner.google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com>

1 0

Change in coreboot[master]: driver/i2c/max98927: Add imon and vmon params
by harsha p (Code Review) 24 Aug '17

24 Aug '17

harsha p has uploaded this change for review. ( https://review.coreboot.org/21195 Change subject: driver/i2c/max98927: Add imon and vmon params ...................................................................... driver/i2c/max98927: Add imon and vmon params This change list adds imon and vmon slot numbers as params for Maxim 98927 driver. These values are looked up in the kernel driver to confiure IV feedback for audio playback on speakers. BUG=b:36724448 TEST=After boot, the register dump for Max98927 codecs should have imon and vmon slots numbers set in 0x1e register. Change-Id: I21d72ba91af83782587f11018b2d1d1c8d4f676c --- M src/drivers/i2c/max98927/chip.h M src/drivers/i2c/max98927/max98927.c 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/21195/1 diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h index c7101bc..195b35d 100644 --- a/src/drivers/i2c/max98927/chip.h +++ b/src/drivers/i2c/max98927/chip.h @@ -27,4 +27,7 @@ const char *desc; /* ACPI Device Name */ const char *name; + unsigned int vmon_slot_no; + unsigned int imon_slot_no; + }; diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c index 976c2f2..e9fc00d 100644 --- a/src/drivers/i2c/max98927/max98927.c +++ b/src/drivers/i2c/max98927/max98927.c @@ -61,6 +61,8 @@ dp = acpi_dp_new_table("_DSD"); acpi_dp_add_integer(dp, "interleave_mode", config->interleave_mode); + acpi_dp_add_integer(dp, "vmon-slot-no", config->vmon_slot_no); + acpi_dp_add_integer(dp, "imon-slot-no", config->imon_slot_no); acpi_dp_write(dp); -- To view, visit https://review.coreboot.org/21195 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I21d72ba91af83782587f11018b2d1d1c8d4f676c Gerrit-Change-Number: 21195 Gerrit-PatchSet: 1 Gerrit-Owner: harsha p <harsha.p.n(a)intel.corp-partner.google.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com>

1 0

Change in coreboot[master]: ec/google: Use feature flag layout that matches the EC host command
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21193 ) Change subject: ec/google: Use feature flag layout that matches the EC host command ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14583/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59254/ : SUCCESS -- To view, visit https://review.coreboot.org/21193 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c1f0e5390e840ea0c32315a3da8eea6f3e12f54 Gerrit-Change-Number: 21193 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 21:27:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/google: Use feature flag layout that matches the EC host command
by Patrick Georgi (Code Review) 24 Aug '17

24 Aug '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21193 Change subject: ec/google: Use feature flag layout that matches the EC host command ...................................................................... ec/google: Use feature flag layout that matches the EC host command The EC side of the feature bits in ACPI EC space isn't stable yet, and we're now going for matching them up with the EC host command of the same purpose. Change-Id: I9c1f0e5390e840ea0c32315a3da8eea6f3e12f54 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/ec/google/chromeec/acpi/ec.asl M src/ec/google/chromeec/acpi/keyboard_backlight.asl 2 files changed, 48 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/21193/1 diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 422abe1..0d05110 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -47,15 +47,49 @@ RAMV, 8, // EC RAM Version TSTB, 8, // Test Byte TSTC, 8, // Complement of Test Byte - KBLV, 8, // Keyboard Backlight + KBLV, 8, // Keyboard Backlight value FAND, 8, // Set Fan Duty Cycle PATI, 8, // Programmable Auxiliary Trip Sensor ID PATT, 8, // Programmable Auxiliary Trip Threshold PATC, 8, // Programmable Auxiliary Trip Commit CHGL, 8, // Charger Current Limit TBMD, 1, // Tablet mode + // DFUD must be 0 for the other 31 values to be valid Offset (0x0a), - KBLE, 1, // Keyboard Backlight exists + DFUD, 1, // Device Features Undefined + FLSH, 1, // Flash commands present + PFAN, 1, // PWM Fan control present + KBLE, 1, // Keyboard Backlight present + LTBR, 1, // Lightbar present + LEDC, 1, // LED control + MTNS, 1, // Motion sensors present + KEYB, 1, // EC is keyboard controller + PSTR, 1, // Persistent storage + P80P, 1, // EC serves I/O Port 80h + THRM, 1, // EC supports thermal management + SBKL, 1, // Screen backlight switch present + WIFI, 1, // WIFI switch present + HOST, 1, // EC monitors host events (eg SCI, SMI) + GPIO, 1, // EC provides GPIO commands + I2CB, 1, // EC provides I2C controller access + CHRG, 1, // EC provides commands for charger control + BATT, 1, // Simply Battery support + SBAT, 1, // Smart Battery support + HANG, 1, // EC can detect host hang + PMUI, 1, // Power Information + DSEC, 1, // another EC exists downstream + UPDC, 1, // supports USB Power Delivery + UMUX, 1, // supports USB Mux + MSFF, 1, // Motion Sense has FIFO + TVST, 1, // supports temporary secure vstore + TCMV, 1, // USB Type C Muxing is virtual (host assisted) + RTCD, 1, // EC provides an RTC device + FPRD, 1, // EC provides a fingerprint reader device + TPAD, 1, // EC provides a touchpad device + RWSG, 1, // EC has RWSIG task enabled + DEVE, 1, // EC supports device events + // make sure we're within our space envelope + Offset (0x0e), } #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP) diff --git a/src/ec/google/chromeec/acpi/keyboard_backlight.asl b/src/ec/google/chromeec/acpi/keyboard_backlight.asl index d76bed8..1edce81 100644 --- a/src/ec/google/chromeec/acpi/keyboard_backlight.asl +++ b/src/ec/google/chromeec/acpi/keyboard_backlight.asl @@ -33,8 +33,18 @@ */ Method (_STA, 0, NotSerialized) { - Multiply (0xf, \_SB.PCI0.LPCB.EC0.KBLE, Local0) - Return (Local0) + /* If query is unsupported, but this code is compiled + * in, assume the backlight exists physically. + */ + If (LEqual (1, \_SB.PCI0.LPCB.EC0.DFUD)) { + Return (0xf) + } + /* If EC reports that backlight exists, trust it */ + If (LEqual (1, \_SB.PCI0.LPCB.EC0.KBLE)) { + Return (0xf) + } + /* Otherwise: no device -> disable */ + Return (0) } /* Read current backlight value */ -- To view, visit https://review.coreboot.org/21193 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9c1f0e5390e840ea0c32315a3da8eea6f3e12f54 Gerrit-Change-Number: 21193 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Increase preram console size
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21186 ) Change subject: soc/amd/stoneyridge: Increase preram console size ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59242/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14572/ : SUCCESS -- To view, visit https://review.coreboot.org/21186 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia11d1c6c186a7025510c240206743ebe8d741461 Gerrit-Change-Number: 21186 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 18:50:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Enable the SATA controller
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21042 ) Change subject: amd/padmelon: Enable the SATA controller ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59237/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14568/ : SUCCESS -- To view, visit https://review.coreboot.org/21042 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide5f0c9d63746a80a83a886dfb62e3475657cea0 Gerrit-Change-Number: 21042 Gerrit-PatchSet: 8 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 17:44:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 8: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59241/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14571/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 8 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 17:41:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Remove board ID file
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21044 ) Change subject: amd/padmelon: Remove board ID file ...................................................................... Patch Set 9: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59239/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14569/ : SUCCESS -- To view, visit https://review.coreboot.org/21044 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34fb1d61016e84b8bd12b21de65fed40c5e2e4d9 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 9 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 17:38:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fixes to enable power button
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21048 ) Change subject: amd/padmelon: Fixes to enable power button ...................................................................... Patch Set 11: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59240/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14570/ : SUCCESS -- To view, visit https://review.coreboot.org/21048 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I104a6d3cabc15f0a61d6197d6aeb5189ce2e483b Gerrit-Change-Number: 21048 Gerrit-PatchSet: 11 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 17:35:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Fix SD controller setting
by build bot (Jenkins) (Code Review) 24 Aug '17

24 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21041 ) Change subject: amd/padmelon: Fix SD controller setting ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59236/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14566/ : SUCCESS -- To view, visit https://review.coreboot.org/21041 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If01e426760138a3dc0487ba99ac87b35a939a958 Gerrit-Change-Number: 21041 Gerrit-PatchSet: 8 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 24 Aug 2017 17:31:31 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017