coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: mainboard/google/coral: Add USB2 phy setting override for Santa
by Tim Chen (Code Review) 25 Aug '17

25 Aug '17

Tim Chen has uploaded this change for review. ( https://review.coreboot.org/21199 Change subject: mainboard/google/coral: Add USB2 phy setting override for Santa ...................................................................... mainboard/google/coral: Add USB2 phy setting override for Santa In order to pass type C USB2 eye diagram for sku Santa, USB2 port#1 PHY register needs to be overridden. port#1: PERPORTPETXISET = 7 PERPORTTXISET = 2 BUG=b:64880573 BRANCH=master TEST=emerge-coral coreboot chromeos-bootimage Change-Id: I07c0b7b0f08263a348befb7d6fd8d01028314470 Signed-off-by: Tim Chen <Tim-Chen(a)quantatw.com> --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/21199/1 diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index 3da5456..a6f9f81 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -16,6 +16,8 @@ #include <stdint.h> #include <ec/google/chromeec/ec.h> #include "baseboard/variants.h" +#include <soc/cpu.h> +#include <soc/intel/apollolake/chip.h> uint8_t variant_board_sku(void) { @@ -31,3 +33,22 @@ *oem_table_id = CONFIG_VARIANT_DIR; *oem_revision = variant_board_sku(); } + +void mainboard_devtree_update(struct device *dev) +{ + /* Override dev tree settings per board */ + struct soc_intel_apollolake_config *cfg = dev->chip_info; + uint8_t sku_id; + + sku_id = variant_board_sku(); + + switch(sku_id) { + case 2: //SANTA + case 3: //SANTA + cfg->usb2eye[1].Usb20PerPortPeTxiSet = 7; + cfg->usb2eye[1].Usb20PerPortTxiSet = 2; + break; + default: + break; + } +} -- To view, visit https://review.coreboot.org/21199 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I07c0b7b0f08263a348befb7d6fd8d01028314470 Gerrit-Change-Number: 21199 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com>

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14605/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59277/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 11 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 02:17:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 10: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59276/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14604/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 10 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 02:11:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 9: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59275/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14603/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 9 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 02:06:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Remove board ID file
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21044 ) Change subject: amd/padmelon: Remove board ID file ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14602/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59274/ : SUCCESS -- To view, visit https://review.coreboot.org/21044 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34fb1d61016e84b8bd12b21de65fed40c5e2e4d9 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 10 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 01:59:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: update SPD functions
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21197 ) Change subject: google/cyan: update SPD functions ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14598/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59270/ : SUCCESS -- To view, visit https://review.coreboot.org/21197 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafe99ec0795764f645e0a91f5b321be5b4c6fd88 Gerrit-Change-Number: 21197 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 01:19:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*: add options to trigger finalize_smm() on normal boot
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21129 ) Change subject: sb/intel/*: add options to trigger finalize_smm() on normal boot ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14594/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59266/ : SUCCESS -- To view, visit https://review.coreboot.org/21129 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43d4142291c8737b29738c41e8c484328b297b55 Gerrit-Change-Number: 21129 Gerrit-PatchSet: 14 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 00:52:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Init UPD params based on config
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21175 ) Change subject: soc/intel/cannonlake: Init UPD params based on config ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14592/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59265/ : SUCCESS -- To view, visit https://review.coreboot.org/21175 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ee58f8432a957ef389b40f717533e4cfe774b9 Gerrit-Change-Number: 21175 Gerrit-PatchSet: 4 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 00:50:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: SMBus, SAGV and Skip FSP MPInit in de...
by build bot (Jenkins) (Code Review) 25 Aug '17

25 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21198 ) Change subject: mainboard/intel/cannonlake_rvp: SMBus, SAGV and Skip FSP MPInit in devicetree ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14593/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59264/ : SUCCESS -- To view, visit https://review.coreboot.org/21198 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic810b003bf7fb13447d5d5dcd49cfcc31785b440 Gerrit-Change-Number: 21198 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 25 Aug 2017 00:46:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: SMBus, SAGV and Skip FSP MPInit in de...
by Pratikkumar V Prajapati (Code Review) 25 Aug '17

25 Aug '17

Pratikkumar V Prajapati has uploaded this change for review. ( https://review.coreboot.org/21198 Change subject: mainboard/intel/cannonlake_rvp: SMBus, SAGV and Skip FSP MPInit in devicetree ...................................................................... mainboard/intel/cannonlake_rvp: SMBus, SAGV and Skip FSP MPInit in devicetree Set SMBus, SAGV and Skip FSP MPInit configuration from devicetree.cb Change-Id: Ic810b003bf7fb13447d5d5dcd49cfcc31785b440 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> --- M src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb M src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/21198/1 diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb index e71f15b..a3c4c80 100644 --- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb +++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_u/devicetree.cb @@ -4,6 +4,11 @@ device lapic 0 on end end + # FSP configuration + register "SaGv" = "3" + register "FspSkipMpInit" = "1" + register "SmbusEnable" = "1" + device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device diff --git a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb index e71f15b..a3c4c80 100644 --- a/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb +++ b/src/mainboard/intel/cannonlake_rvp/variants/cnl_y/devicetree.cb @@ -4,6 +4,11 @@ device lapic 0 on end end + # FSP configuration + register "SaGv" = "3" + register "FspSkipMpInit" = "1" + register "SmbusEnable" = "1" + device domain 0 on device pci 00.0 on end # Host Bridge device pci 02.0 on end # Integrated Graphics Device -- To view, visit https://review.coreboot.org/21198 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic810b003bf7fb13447d5d5dcd49cfcc31785b440 Gerrit-Change-Number: 21198 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017