coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: amd/padmelon: Fixes to enable power button
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21048 ) Change subject: amd/padmelon: Fixes to enable power button ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59172/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14503/ : SUCCESS -- To view, visit https://review.coreboot.org/21048 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I104a6d3cabc15f0a61d6197d6aeb5189ce2e483b Gerrit-Change-Number: 21048 Gerrit-PatchSet: 10 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 17:47:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Remove board ID file
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21044 ) Change subject: amd/padmelon: Remove board ID file ...................................................................... Patch Set 7: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59170/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14501/ : SUCCESS -- To view, visit https://review.coreboot.org/21044 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34fb1d61016e84b8bd12b21de65fed40c5e2e4d9 Gerrit-Change-Number: 21044 Gerrit-PatchSet: 7 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 17:43:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fintek/f81803a: Correct superio.asl
by John E. Kabat Jr. (Code Review) 23 Aug '17

23 Aug '17

John E. Kabat Jr. has uploaded this change for review. ( https://review.coreboot.org/21161 Change subject: fintek/f81803a: Correct superio.asl ...................................................................... fintek/f81803a: Correct superio.asl Fix redefinition of PNP_DEFAULT_PSC when a uart is shown. Change-Id: Ie5481678af595c65815b290676ecd9ea66d4ee75 Signed-off-by: John Kabat <john.kabat(a)scarletltd.com> --- M src/superio/fintek/f81803a/acpi/superio.asl 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/21161/1 diff --git a/src/superio/fintek/f81803a/acpi/superio.asl b/src/superio/fintek/f81803a/acpi/superio.asl index d4b3849..507715f 100644 --- a/src/superio/fintek/f81803a/acpi/superio.asl +++ b/src/superio/fintek/f81803a/acpi/superio.asl @@ -103,7 +103,6 @@ #define PNP_EXIT_MAGIC_1ST 0xaa #include <superio/acpi/pnp_config.asl> -#define PNP_DEFAULT_PSC Return (0) /* no power management */ #ifdef F81803A_SHOW_UARTA #undef SUPERIO_UART_LDN @@ -112,6 +111,10 @@ #undef SUPERIO_UART_PM_VAL #undef SUPERIO_UART_PM_LDN #define SUPERIO_UART_LDN 1 + #undef PNP_DEFAULT_PSC +#ifndef SUPERIO_UART_PM_REG + #define PNP_DEFAULT_PSC Return (0) /* no power management */ +#endif #include <superio/acpi/pnp_uart.asl> #endif @@ -122,6 +125,10 @@ #undef SUPERIO_UART_PM_VAL #undef SUPERIO_UART_PM_LDN #define SUPERIO_UART_LDN 2 + #undef PNP_DEFAULT_PSC + #ifndef SUPERIO_UART_PM_REG + #define PNP_DEFAULT_PSC Return (0) /* no power management */ + #endif #include <superio/acpi/pnp_uart.asl> #endif -- To view, visit https://review.coreboot.org/21161 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5481678af595c65815b290676ecd9ea66d4ee75 Gerrit-Change-Number: 21161 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com>

1 0

Change in coreboot[master]: mainboard/lenovo: add Lenovo Z61t laptop
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21019 ) Change subject: mainboard/lenovo: add Lenovo Z61t laptop ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59168/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14499/ : SUCCESS -- To view, visit https://review.coreboot.org/21019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c89cc47d3db126d827f92d50270954bc42f224 Gerrit-Change-Number: 21019 Gerrit-PatchSet: 7 Gerrit-Owner: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 16:25:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Don't hardcode limits
by Arthur Heymans (Code Review) 23 Aug '17

23 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21159 ) Change subject: ec/lenovo/h8/acpi/thermal: Don't hardcode limits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21159 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If438a909f4415f50cd7a764fb5fba7ec29599606 Gerrit-Change-Number: 21159 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 16:13:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/acpi_tables: Add critical and passive threshold
by Arthur Heymans (Code Review) 23 Aug '17

23 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21160 ) Change subject: mb/lenovo/*/acpi_tables: Add critical and passive threshold ...................................................................... Patch Set 1: Code-Review+2 Tested with thresholds lowered (just for testing) on x200 and linux correctly shuts it down. -- To view, visit https://review.coreboot.org/21160 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic75a80994b27ac19651ed52b7fc3c00c65cd9c01 Gerrit-Change-Number: 21160 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 16:12:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/acpi_tables: Add critical and passive threshold
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21160 ) Change subject: mb/lenovo/*/acpi_tables: Add critical and passive threshold ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59166/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14497/ : SUCCESS -- To view, visit https://review.coreboot.org/21160 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic75a80994b27ac19651ed52b7fc3c00c65cd9c01 Gerrit-Change-Number: 21160 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 15:55:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/*/nvs: Rename register
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21158 ) Change subject: sb/intel/*/nvs: Rename register ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59165/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14496/ : SUCCESS -- To view, visit https://review.coreboot.org/21158 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a869adb1da2e33156968c4b7597edf99902c1a Gerrit-Change-Number: 21158 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 15:54:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi/thermal: Don't hardcode limits
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21159 ) Change subject: ec/lenovo/h8/acpi/thermal: Don't hardcode limits ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59167/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14498/ : SUCCESS -- To view, visit https://review.coreboot.org/21159 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If438a909f4415f50cd7a764fb5fba7ec29599606 Gerrit-Change-Number: 21159 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 15:53:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/acpi_tables: Add critical and passive threshold
by Patrick Rudolph (Code Review) 23 Aug '17

23 Aug '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21160 Change subject: mb/lenovo/*/acpi_tables: Add critical and passive threshold ...................................................................... mb/lenovo/*/acpi_tables: Add critical and passive threshold Add critical and passive threshold to be advertised in thermal zone 0. Change-Id: Ic75a80994b27ac19651ed52b7fc3c00c65cd9c01 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/t400/acpi_tables.c M src/mainboard/lenovo/t60/acpi_tables.c M src/mainboard/lenovo/x200/acpi_tables.c M src/mainboard/lenovo/x201/acpi_tables.c M src/mainboard/lenovo/x60/acpi_tables.c 5 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/21160/1 diff --git a/src/mainboard/lenovo/t400/acpi_tables.c b/src/mainboard/lenovo/t400/acpi_tables.c index 1540d73..feced93 100644 --- a/src/mainboard/lenovo/t400/acpi_tables.c +++ b/src/mainboard/lenovo/t400/acpi_tables.c @@ -26,6 +26,7 @@ #include <device/pci_ids.h> #include "southbridge/intel/i82801ix/nvs.h" + void acpi_create_gnvs(global_nvs_t *gnvs) { memset((void *)gnvs, 0, sizeof(*gnvs)); @@ -36,6 +37,9 @@ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; + /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; } unsigned long acpi_fill_madt(unsigned long current) diff --git a/src/mainboard/lenovo/t60/acpi_tables.c b/src/mainboard/lenovo/t60/acpi_tables.c index b5b51a0..d29a6cc 100644 --- a/src/mainboard/lenovo/t60/acpi_tables.c +++ b/src/mainboard/lenovo/t60/acpi_tables.c @@ -32,4 +32,7 @@ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; + /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; } diff --git a/src/mainboard/lenovo/x200/acpi_tables.c b/src/mainboard/lenovo/x200/acpi_tables.c index 1540d73..43a0fc8 100644 --- a/src/mainboard/lenovo/x200/acpi_tables.c +++ b/src/mainboard/lenovo/x200/acpi_tables.c @@ -36,6 +36,9 @@ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; + /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; } unsigned long acpi_fill_madt(unsigned long current) diff --git a/src/mainboard/lenovo/x201/acpi_tables.c b/src/mainboard/lenovo/x201/acpi_tables.c index 70719e8..d817d19 100644 --- a/src/mainboard/lenovo/x201/acpi_tables.c +++ b/src/mainboard/lenovo/x201/acpi_tables.c @@ -29,4 +29,7 @@ void acpi_create_gnvs(global_nvs_t * gnvs) { + /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; } diff --git a/src/mainboard/lenovo/x60/acpi_tables.c b/src/mainboard/lenovo/x60/acpi_tables.c index b5b51a0..d29a6cc 100644 --- a/src/mainboard/lenovo/x60/acpi_tables.c +++ b/src/mainboard/lenovo/x60/acpi_tables.c @@ -32,4 +32,7 @@ gnvs->cmap = 0x01; gnvs->cmbp = 0x01; + /* Set thermal levels */ + gnvs->tcrt = 100; + gnvs->tpsv = 90; } -- To view, visit https://review.coreboot.org/21160 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic75a80994b27ac19651ed52b7fc3c00c65cd9c01 Gerrit-Change-Number: 21160 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017