coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: Makefile: Keep list of exported variables
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21162 ) Change subject: Makefile: Keep list of exported variables ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59177/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14508/ : SUCCESS -- To view, visit https://review.coreboot.org/21162 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ce9eff32d817ec190441550116376843abd1c11 Gerrit-Change-Number: 21162 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 22:31:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] payloads/external: Provide generic Makefile.git
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21163 ) Change subject: [WIP] payloads/external: Provide generic Makefile.git ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59178/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14509/ : SUCCESS -- To view, visit https://review.coreboot.org/21163 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7557ca81fa1e32cd5c17c757e9458d048ff1ec99 Gerrit-Change-Number: 21163 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 22:29:05 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] payloads/external/GRUB2: Convert to use Makefile.git
by Nico Huber (Code Review) 23 Aug '17

23 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21164 Change subject: [WIP] payloads/external/GRUB2: Convert to use Makefile.git ...................................................................... [WIP] payloads/external/GRUB2: Convert to use Makefile.git Change-Id: I837a5e3b107eb82e14dcd0f21a954250f0e9b088 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M payloads/external/GRUB2/Kconfig M payloads/external/GRUB2/Makefile M payloads/external/Makefile.inc 3 files changed, 17 insertions(+), 64 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/21164/1 diff --git a/payloads/external/GRUB2/Kconfig b/payloads/external/GRUB2/Kconfig index 656f7c9..9888df2 100644 --- a/payloads/external/GRUB2/Kconfig +++ b/payloads/external/GRUB2/Kconfig @@ -1,31 +1,10 @@ if PAYLOAD_GRUB2 -choice - prompt "GRUB2 version" - default GRUB2_MASTER - -config GRUB2_MASTER - bool "HEAD" - help - Newest GRUB2 version - -config GRUB2_REVISION - bool "git revision" - help - Select this option if you have a specific commit or branch - that you want to use as the revision from which to - build GRUB2. - - You will be able to specify the name of a branch or a commit id - later. -endchoice - config GRUB2_REVISION_ID - string "Insert a commit's SHA-1 or a branch name" - depends on GRUB2_REVISION + string "GIT Revision" default "origin/master" help - The commit's SHA-1 or branch name of the revision to use. + The commit's SHA-1, branch or tag name of the revision to use. config GRUB2_EXTRA_MODULES string "Extra modules to include in GRUB image" diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile index 4a0a491..942972a 100644 --- a/payloads/external/GRUB2/Makefile +++ b/payloads/external/GRUB2/Makefile @@ -1,29 +1,16 @@ -TAG-$(CONFIG_GRUB2_MASTER)= -TAG-$(CONFIG_GRUB2_REVISION)=$(CONFIG_GRUB2_REVISION_ID) -NAME-$(CONFIG_GRUB2_MASTER)=HEAD -NAME-$(CONFIG_GRUB2_REVISION)=$(CONFIG_GRUB2_REVISION_ID) - -project_git_repo=git://git.sv.gnu.org/grub.git -project_dir=grub2 - unexport HOSTCC CC LD OBJCOPY STRIP -MAKEOVERRIDES := -all: grub2 +project_name := GRUB +project_repo := git://git.sv.gnu.org/grub.git +project_rev := $(REVISION_ID) +project_dir := grub2 +project_output := grub2/build/default_payload.elf +project_params := default_payload.elf EXTRA_PAYLOAD_MODULES="$(EXTRA_MODULES)" -checkout: - echo " GIT GRUB2 $(NAME-y)" - test -d grub2 || \ - git clone $(project_git_repo) $(project_dir) - cd grub2 && \ - git checkout master && \ - git pull; \ - test -n "$(TAG-y)" && \ - git branch -f $(NAME-y) $(TAG-y) && \ - git checkout $(NAME-y) || true +include ../Makefile.git grub2/build/config.h: $(CONFIG_DEP) | checkout - echo " CONFIG GRUB2 $(NAME-y)" + printf " CONFIG $(project_name) [$(project_rev)]\n" rm -rf grub2/build mkdir grub2/build cd grub2 && ./autogen.sh @@ -32,21 +19,10 @@ CFLAGS=-O2 TARGET_CFLAGS=-Os \ --with-platform=coreboot --enable-boot-time --disable-werror -config: grub2/build/config.h checkout +first_make_call: grub2/build/config.h checkout + printf " MAKE $(project_name) [$(project_rev)]\n" + $(MAKE) -C"$(dir $(project_output))" -grub2: config - echo " MAKE GRUB2 $(NAME-y)" - $(MAKE) -C grub2/build - $(MAKE) -C grub2/build default_payload.elf \ - EXTRA_PAYLOAD_MODULES="$(CONFIG_GRUB2_EXTRA_MODULES)" +$(project_output): first_make_call -clean: - test -f grub2/build/Makefile && $(MAKE) -C grub2/build clean || exit 0 - -distclean: - rm -rf grub2 - -print-repo-info: - echo "$(project_git_repo) $(project_dir)" - -.PHONY: checkout config grub2 clean distclean print-repo-info +.PHONY: first_make_call diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 0a9b3d6..59eb46f 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -158,10 +158,8 @@ CC="$(CC_x86_32)" LD="$(LD_x86_32)" \ OBJCOPY="$(OBJCOPY_x86_32)" STRIP="$(STRIP_x86_32)" \ CONFIG_DEP="$(abspath $(obj)/config.h)" \ - CONFIG_GRUB2_MASTER=$(CONFIG_GRUB2_MASTER) \ - CONFIG_GRUB2_REVISION=$(CONFIG_GRUB2_REVISION) \ - CONFIG_GRUB2_REVISION_ID=$(CONFIG_GRUB2_REVISION_ID) \ - CONFIG_GRUB2_EXTRA_MODULES=$(CONFIG_GRUB2_EXTRA_MODULES) + REVISION_ID=$(CONFIG_GRUB2_REVISION_ID) \ + EXTRA_MODULES=$(CONFIG_GRUB2_EXTRA_MODULES) payloads/external/GRUB2/grub2/build/default_payload.elf: grub2 -- To view, visit https://review.coreboot.org/21164 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I837a5e3b107eb82e14dcd0f21a954250f0e9b088 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: [WIP] payloads/external: Provide generic Makefile.git
by Nico Huber (Code Review) 23 Aug '17

23 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21163 Change subject: [WIP] payloads/external: Provide generic Makefile.git ...................................................................... [WIP] payloads/external: Provide generic Makefile.git Provide a Makefile.git to be included by payloads built from Git. Featuring: * Offline mode, e.g. don't care if a later fetch failed. * Fetching of origin, including tags and branch updates. * Simplyfied checkout: Should work with commit hashes, local/remote branches and tags. * Patch application, ported from tianocore, untested. * Unexporting of variables exported by coreboot: No more sub-make confusion! * The usual boilerplate. Change-Id: I7557ca81fa1e32cd5c17c757e9458d048ff1ec99 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A payloads/external/Makefile.git 1 file changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/21163/1 diff --git a/payloads/external/Makefile.git b/payloads/external/Makefile.git new file mode 100644 index 0000000..560991c --- /dev/null +++ b/payloads/external/Makefile.git @@ -0,0 +1,64 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2017 Nico Huber <nico.h(a)gmx.de> +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +project_rev := $(if $(strip $(project_rev)),$(project_rev),origin/master) +project_dir := $(abspath $(project_dir)) +project_patches ?= $(wildcard $(CURDIR)/patches/*.patch) + +unexport $(COREBOOT_EXPORTS) +MAKEOVERRIDES := + +all: $(project_output) + +$(project_dir)/.git: + printf " CLONE $(project_name) into $(project_dir)\n" + git clone "$(project_repo)" "$(project_dir)" + +fetch: $(project_dir)/.git + -cd "$(project_dir)" && git fetch origin + +checkout: fetch + cd "$(project_dir)" && \ + if ! git diff --quiet _cb_checkout "$(project_rev)" -- 2>/dev/null; \ + then \ + printf " CHECKOUT $(project_name) [$(project_rev)]\n"; \ + git checkout $$(git rev-parse HEAD) >/dev/null 2>&1; \ + git branch -f _cb_checkout "$(project_rev)" && \ + git checkout _cb_checkout && \ + $(if $(project_patches), \ + for patch in $(project_patches); do \ + printf " PATCH $$patch\n"; \ + git am --keep-cr "$$patch" || \ + ( printf "Error when applying patches.\n"; \ + git am --abort; exit 1; ); \ + done;,true;) \ + fi + +$(project_output): checkout + printf " MAKE $(project_name) [$(project_rev)]\n" + $(MAKE) -C"$(dir $(project_output))" $(project_params) + +clean: + if [ -f "$(dir $(project_output))Makefile" ]; then \ + $(MAKE) -C $(dir $(project_output)) clean || true; \ + fi + +distclean: + rm -rf $(project_dir) + +print-repo-info: + printf "$(project_repo) $(project_dir)\n" + +.PHONY: all fetch checkout clean distclean print-repo-info -- To view, visit https://review.coreboot.org/21163 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7557ca81fa1e32cd5c17c757e9458d048ff1ec99 Gerrit-Change-Number: 21163 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: Makefile: Keep list of exported variables
by Nico Huber (Code Review) 23 Aug '17

23 Aug '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21162 Change subject: Makefile: Keep list of exported variables ...................................................................... Makefile: Keep list of exported variables This can be useful to unexport them later. Change-Id: I2ce9eff32d817ec190441550116376843abd1c11 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M Makefile.inc 2 files changed, 36 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/21162/1 diff --git a/Makefile b/Makefile index 343ec65..4d76340 100644 --- a/Makefile +++ b/Makefile @@ -30,24 +30,31 @@ ## SUCH DAMAGE. ## -export top := $(CURDIR) -export src := src -export srck := $(top)/util/kconfig +top := $(CURDIR) +src := src +srck := $(top)/util/kconfig obj ?= build override obj := $(subst $(top)/,,$(abspath $(obj))) -export obj -export objutil ?= $(obj)/util -export objk := $(objutil)/kconfig +objutil ?= $(obj)/util +objk := $(objutil)/kconfig absobj := $(abspath $(obj)) +COREBOOT_EXPORTS := COREBOOT_EXPORTS +COREBOOT_EXPORTS += top src srck obj objutil objk -export KCONFIG_AUTOHEADER := $(obj)/config.h -export KCONFIG_AUTOCONFIG := $(obj)/auto.conf -export KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd -export KCONFIG_SPLITCONFIG := $(obj)/config -export KCONFIG_TRISTATE := $(obj)/tristate.conf -export KCONFIG_NEGATIVES := 1 -export KCONFIG_STRICT := 1 +DOTCONFIG ?= $(top)/.config +KCONFIG_CONFIG = $(DOTCONFIG) +KCONFIG_AUTOHEADER := $(obj)/config.h +KCONFIG_AUTOCONFIG := $(obj)/auto.conf +KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd +KCONFIG_SPLITCONFIG := $(obj)/config +KCONFIG_TRISTATE := $(obj)/tristate.conf +KCONFIG_NEGATIVES := 1 +KCONFIG_STRICT := 1 + +COREBOOT_EXPORTS += KCONFIG_CONFIG KCONFIG_AUTOHEADER KCONFIG_AUTOCONFIG +COREBOOT_EXPORTS += KCONFIG_DEPENDENCIES KCONFIG_SPLITCONFIG KCONFIG_TRISTATE +COREBOOT_EXPORTS += KCONFIG_NEGATIVES KCONFIG_STRICT # directory containing the toplevel Makefile.inc TOPLEVEL := . @@ -55,9 +62,6 @@ CONFIG_SHELL := sh KBUILD_DEFCONFIG := configs/defconfig UNAME_RELEASE := $(shell uname -r) -DOTCONFIG ?= $(top)/.config -KCONFIG_CONFIG = $(DOTCONFIG) -export KCONFIG_CONFIG HAVE_DOTCONFIG := $(wildcard $(DOTCONFIG)) MAKEFLAGS += -rR --no-print-directory @@ -82,6 +86,8 @@ DOXYGEN := doxygen DOXYGEN_OUTPUT_DIR := doxygen +export $(COREBOOT_EXPORTS) + all: real-all help_coreboot help:: diff --git a/Makefile.inc b/Makefile.inc index 679e0ac..54ed00d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -29,33 +29,35 @@ # misleadingly named, this is the coreboot version ifeq ($(KERNELVERSION),) ifeq ($(BUILD_TIMELESS),1) -export KERNELVERSION := TIMELESS +KERNELVERSION := TIMELESS else -export KERNELVERSION := $(strip $(if $(GIT),\ +KERNELVERSION := $(strip $(if $(GIT),\ $(shell git describe --dirty --always || git describe),\ $(if $(wildcard $(top)/.coreboot-version),\ $(shell cat $(top)/.coreboot-version),\ coreboot-unknown$(KERNELREVISION)))) endif endif +COREBOOT_EXPORTS += KERNELVERSION ####################################################################### # Basic component discovery MAINBOARDDIR=$(call strip_quotes,$(CONFIG_MAINBOARD_DIR)) VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR)) -export MAINBOARDDIR -export VARIANT_DIR +COREBOOT_EXPORTS += MAINBOARDDIR VARIANT_DIR ## Final build results, which CBFSTOOL uses to create the final ## rom image file, are placed under $(objcbfs). ## These typically have suffixes .debug .elf .bin and .map -export objcbfs := $(obj)/cbfs/$(CONFIG_CBFS_PREFIX) +objcbfs := $(obj)/cbfs/$(CONFIG_CBFS_PREFIX) +COREBOOT_EXPORTS += objcbfs ## Based on the active configuration, Makefile conditionally collects ## the required assembly includes and saves them in a file. ## Such files that do not have a clear one-to-one relation to a source ## file under src/ are placed and built under $(objgenerated) -export objgenerated := $(obj)/generated +objgenerated := $(obj)/generated +COREBOOT_EXPORTS += objgenerated ####################################################################### # root rule to resolve if in build mode (ie. configuration exists) @@ -195,7 +197,8 @@ # unless explicitly requested and enabled through --checkout forgetthis:=$(if $(GIT),$(shell git submodule update --init --checkout 3rdparty/blobs)) endif -export UPDATED_SUBMODULES:=1 +UPDATED_SUBMODULES:=1 +COREBOOT_EXPORTS += UPDATED_SUBMODULES endif postcar-c-deps:=$$(OPTION_TABLE_H) @@ -347,7 +350,8 @@ endif ifneq ($(CONFIG_LOCALVERSION),"") -export COREBOOT_EXTRA_VERSION := -$(call strip_quotes,$(CONFIG_LOCALVERSION)) +COREBOOT_EXTRA_VERSION := -$(call strip_quotes,$(CONFIG_LOCALVERSION)) +COREBOOT_EXPORTS += COREBOOT_EXTRA_VERSION endif CPPFLAGS_common := -Isrc -Isrc/include -Isrc/commonlib/include -I$(obj) @@ -435,6 +439,8 @@ $(objutil)/ifdfake $(objutil)/options $(objutil)/amdfwtool \ $(objutil)/cbootimage $(objutil)/bimgtool +export $(COREBOOT_EXPORTS) + ####################################################################### # generate build support files $(obj)/build.h: .xcompile -- To view, visit https://review.coreboot.org/21162 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2ce9eff32d817ec190441550116376843abd1c11 Gerrit-Change-Number: 21162 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity scan error
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21155 ) Change subject: soc/intel/cannonlake: Fix Coverity scan error ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59175/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14506/ : SUCCESS -- To view, visit https://review.coreboot.org/21155 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica19735307736c8a55c29af88db8b1372f8779e4 Gerrit-Change-Number: 21155 Gerrit-PatchSet: 4 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: clang buildbot Gerrit-Comment-Date: Wed, 23 Aug 2017 20:49:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity scan error
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21155 ) Change subject: soc/intel/cannonlake: Fix Coverity scan error ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59174/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14505/ : SUCCESS -- To view, visit https://review.coreboot.org/21155 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica19735307736c8a55c29af88db8b1372f8779e4 Gerrit-Change-Number: 21155 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: clang buildbot Gerrit-Comment-Date: Wed, 23 Aug 2017 19:33:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Clear GPIO overrides
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21046 ) Change subject: amd/padmelon: Clear GPIO overrides ...................................................................... Patch Set 6: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59171/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14502/ : SUCCESS -- To view, visit https://review.coreboot.org/21046 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3 Gerrit-Change-Number: 21046 Gerrit-PatchSet: 6 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 18:09:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fix Coverity scan error
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21155 ) Change subject: soc/intel/cannonlake: Fix Coverity scan error ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59173/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14504/ : SUCCESS -- To view, visit https://review.coreboot.org/21155 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica19735307736c8a55c29af88db8b1372f8779e4 Gerrit-Change-Number: 21155 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: clang buildbot Gerrit-Comment-Date: Wed, 23 Aug 2017 17:54:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fintek/f81803a: Correct superio.asl
by build bot (Jenkins) (Code Review) 23 Aug '17

23 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21161 ) Change subject: fintek/f81803a: Correct superio.asl ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59169/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14500/ : SUCCESS -- To view, visit https://review.coreboot.org/21161 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5481678af595c65815b290676ecd9ea66d4ee75 Gerrit-Change-Number: 21161 Gerrit-PatchSet: 1 Gerrit-Owner: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Aug 2017 17:52:32 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017