coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: southbridge/pi/hudson: Fix GPIO bank1 control definition
by Marshall Dawson (Code Review) 01 Aug '17

01 Aug '17

Marshall Dawson has abandoned this change. ( https://review.coreboot.org/20527 ) Change subject: southbridge/pi/hudson: Fix GPIO bank1 control definition ...................................................................... Abandoned This looks like a duplicate. The correct one is already merged. https://review.coreboot.org/#/c/20526/ -- To view, visit https://review.coreboot.org/20527 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I3ef3ea3ea22faa0152d99923da2e57517ab3d0be Gerrit-Change-Number: 20527 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common PMC for apollolake
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19375 ) Change subject: soc/intel/apollolake: Use common PMC for apollolake ...................................................................... Patch Set 19: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58116/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13544/ : SUCCESS -- To view, visit https://review.coreboot.org/19375 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Gerrit-Change-Number: 19375 Gerrit-PatchSet: 19 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 18:21:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Use common PMC for SMM
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20307 ) Change subject: soc/intel/common: Use common PMC for SMM ...................................................................... Patch Set 9: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58115/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13543/ : SUCCESS -- To view, visit https://review.coreboot.org/20307 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I067b99415e882a24970140280d3b223eb1301e2d Gerrit-Change-Number: 20307 Gerrit-PatchSet: 9 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 18:06:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel PMC support
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19349 ) Change subject: soc/intel/common/block: Add Intel PMC support ...................................................................... Patch Set 29: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58114/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13542/ : SUCCESS -- To view, visit https://review.coreboot.org/19349 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889 Gerrit-Change-Number: 19349 Gerrit-PatchSet: 29 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 17:55:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fsp driver: Call cbmem_init_top
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20833 ) Change subject: fsp driver: Call cbmem_init_top ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58110/ : UNSTABLE -- To view, visit https://review.coreboot.org/20833 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ffe35980ee3896bf58867830e128fe6767ab53 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 15:50:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA f15 f15tn f16kb: Add extra checks for incorrect SPD data
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20839 ) Change subject: AGESA f15 f15tn f16kb: Add extra checks for incorrect SPD data ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58109/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13538/ : SUCCESS -- To view, visit https://review.coreboot.org/20839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica92850cc77e1f7cbf3e7e44717de42a03b93bbe Gerrit-Change-Number: 20839 Gerrit-PatchSet: 4 Gerrit-Owner: Aladyshev Konstantin <aladyshev22(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 15:42:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: AGESA f15 f15tn f16kb: Add extra checks for incorrect SPD data
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20839 ) Change subject: AGESA f15 f15tn f16kb: Add extra checks for incorrect SPD data ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58108/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13537/ : SUCCESS -- To view, visit https://review.coreboot.org/20839 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica92850cc77e1f7cbf3e7e44717de42a03b93bbe Gerrit-Change-Number: 20839 Gerrit-PatchSet: 3 Gerrit-Owner: Aladyshev Konstantin <aladyshev22(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 15:37:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/dmp/vortex86: Fix CMOS read and random RTC reset
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20700 ) Change subject: soc/dmp/vortex86: Fix CMOS read and random RTC reset ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58103/ : SUCCESS -- To view, visit https://review.coreboot.org/20700 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7c9b6455761a38598467b001efb0603fd14c32 Gerrit-Change-Number: 20700 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 13:28:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: SMBIOS: Correct length calculation for empty string table
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20840 ) Change subject: SMBIOS: Correct length calculation for empty string table ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58102/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13532/ : SUCCESS -- To view, visit https://review.coreboot.org/20840 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3178b0030aa71e1ff11a3fd3d102942f0027eb1 Gerrit-Change-Number: 20840 Gerrit-PatchSet: 1 Gerrit-Owner: Aladyshev Konstantin <aladyshev22(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 13:07:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: SMBIOS: Correct length calculation for empty string table
by Aladyshev Konstantin (Code Review) 01 Aug '17

01 Aug '17

Aladyshev Konstantin has uploaded this change for review. ( https://review.coreboot.org/20840 Change subject: SMBIOS: Correct length calculation for empty string table ...................................................................... SMBIOS: Correct length calculation for empty string table If all strings in SMBIOS table are empty, smbios_string_table_len function should return 2, cause every table must end with "\0\0". Change-Id: Ia3178b0030aa71e1ff11a3fd3d102942f0027eb1 Signed-off-by: Konstantin Aladyshev <aladyshev22(a)gmail.com> --- M src/arch/x86/smbios.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/20840/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 72fb0df..8e95ea6 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -81,6 +81,10 @@ p += i; len += i; } + + if (!len) + return 2; + return len + 1; } -- To view, visit https://review.coreboot.org/20840 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia3178b0030aa71e1ff11a3fd3d102942f0027eb1 Gerrit-Change-Number: 20840 Gerrit-PatchSet: 1 Gerrit-Owner: Aladyshev Konstantin <aladyshev22(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017