coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: soc/intel/common/block[WIP]: Common ACPI
by build bot (Jenkins) (Code Review) 02 Aug '17

02 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20630 ) Change subject: soc/intel/common/block[WIP]: Common ACPI ...................................................................... Patch Set 9: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58134/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13560/ : SUCCESS -- To view, visit https://review.coreboot.org/20630 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6eb6fd5366e6e28fd81bc22d050b0efa05a2e5d Gerrit-Change-Number: 20630 Gerrit-PatchSet: 9 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 Aug 2017 00:16:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID
by build bot (Jenkins) (Code Review) 02 Aug '17

02 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19837 ) Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID ...................................................................... Patch Set 29: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58133/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13559/ : SUCCESS -- To view, visit https://review.coreboot.org/19837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693db6d6506af7ff40db0b3ce4cc6c1469f6ef Gerrit-Change-Number: 19837 Gerrit-PatchSet: 29 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 23:33:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Use generic gpio library
by build bot (Jenkins) (Code Review) 02 Aug '17

02 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20543 ) Change subject: soc/amd/stoneyridge: Use generic gpio library ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58132/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13558/ : SUCCESS -- To view, visit https://review.coreboot.org/20543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ea562b052401efff3101f736788ca77d21e6de6 Gerrit-Change-Number: 20543 Gerrit-PatchSet: 10 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 23:31:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/pi/hudson: Fix GPIO bank1 control definition
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20527 ) Change subject: southbridge/pi/hudson: Fix GPIO bank1 control definition ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58129/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13556/ : SUCCESS -- To view, visit https://review.coreboot.org/20527 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ef3ea3ea22faa0152d99923da2e57517ab3d0be Gerrit-Change-Number: 20527 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 21:35:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: libpayload: video: Add support for font scaling with a factor
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20709 ) Change subject: libpayload: video: Add support for font scaling with a factor ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58128/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13555/ : SUCCESS -- To view, visit https://review.coreboot.org/20709 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idff210617c9ec08c6034aef107cfdb34c7cdf029 Gerrit-Change-Number: 20709 Gerrit-PatchSet: 4 Gerrit-Owner: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Ben Gardner <gardner.ben(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peter Stuge <peter(a)stuge.se> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 20:17:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sio/smsc/kbc1100: Fix some style issues
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20852 ) Change subject: sio/smsc/kbc1100: Fix some style issues ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58127/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13554/ : SUCCESS -- To view, visit https://review.coreboot.org/20852 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8940f712c0161419ee0c383b7bc9eb581967366e Gerrit-Change-Number: 20852 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 19:58:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sio/smsc/kbc1100: Fix some style issues
by Arthur Heymans (Code Review) 01 Aug '17

01 Aug '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20852 Change subject: sio/smsc/kbc1100: Fix some style issues ...................................................................... sio/smsc/kbc1100: Fix some style issues This fixes indentation and whitespaces before opening parentheses. Change-Id: I8940f712c0161419ee0c383b7bc9eb581967366e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/superio/smsc/kbc1100/early_init.c M src/superio/smsc/kbc1100/superio.c 2 files changed, 43 insertions(+), 45 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/20852/1 diff --git a/src/superio/smsc/kbc1100/early_init.c b/src/superio/smsc/kbc1100/early_init.c index 2b4ba6f..658de9b 100644 --- a/src/superio/smsc/kbc1100/early_init.c +++ b/src/superio/smsc/kbc1100/early_init.c @@ -46,30 +46,30 @@ void kbc1100_early_init(u16 port) { - pnp_devfn_t dev; - dev = PNP_DEV (port, KBC1100_KBC); - pnp_enter_conf_state(dev); + pnp_devfn_t dev; + dev = PNP_DEV(port, KBC1100_KBC); + pnp_enter_conf_state(dev); - /* Serial IRQ enabled */ - outb(0x25, port); - outb(0x04, port + 1); + /* Serial IRQ enabled */ + outb(0x25, port); + outb(0x04, port + 1); - /* Enable keyboard */ - pnp_set_logical_device(dev); - pnp_set_enable(dev, 0); - pnp_set_iobase(dev, PNP_IDX_IO0, 0x60); - pnp_set_iobase(dev, PNP_IDX_IO1, 0x64); - pnp_set_irq(dev, 0x70, 1); /* IRQ 1 */ - pnp_set_irq(dev, 0x72, 12); /* IRQ 12 */ - pnp_set_enable(dev, 1); + /* Enable keyboard */ + pnp_set_logical_device(dev); + pnp_set_enable(dev, 0); + pnp_set_iobase(dev, PNP_IDX_IO0, 0x60); + pnp_set_iobase(dev, PNP_IDX_IO1, 0x64); + pnp_set_irq(dev, 0x70, 1); /* IRQ 1 */ + pnp_set_irq(dev, 0x72, 12); /* IRQ 12 */ + pnp_set_enable(dev, 1); - /* Enable EC Channel 0 */ - dev = PNP_DEV (port, KBC1100_EC0); - pnp_set_logical_device(dev); - pnp_set_enable(dev, 1); + /* Enable EC Channel 0 */ + dev = PNP_DEV(port, KBC1100_EC0); + pnp_set_logical_device(dev); + pnp_set_enable(dev, 1); - pnp_exit_conf_state(dev); + pnp_exit_conf_state(dev); - /* disable the 1s timer */ - outb(0xE7, 0x64); + /* disable the 1s timer */ + outb(0xE7, 0x64); } diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c index 448070a..0f5ede1 100644 --- a/src/superio/smsc/kbc1100/superio.c +++ b/src/superio/smsc/kbc1100/superio.c @@ -31,44 +31,42 @@ static void kbc1100_init(struct device *dev); struct chip_operations superio_smsc_kbc1100_ops = { - CHIP_NAME("SMSC KBC1100 Super I/O") - .enable_dev = enable_dev + CHIP_NAME("SMSC KBC1100 Super I/O") + .enable_dev = enable_dev }; static struct device_operations ops = { - .read_resources = pnp_read_resources, - .set_resources = pnp_set_resources, - .enable_resources = pnp_enable_resources, - .enable = pnp_alt_enable, - .init = kbc1100_init, - .ops_pnp_mode = &pnp_conf_mode_55_aa, + .read_resources = pnp_read_resources, + .set_resources = pnp_set_resources, + .enable_resources = pnp_enable_resources, + .enable = pnp_alt_enable, + .init = kbc1100_init, + .ops_pnp_mode = &pnp_conf_mode_55_aa, }; static struct pnp_info pnp_dev_info[] = { - { &ops, KBC1100_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x7ff, 0x7ff, }, + { &ops, KBC1100_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x7ff, + 0x7ff, }, }; static void enable_dev(struct device *dev) { - pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); + pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), + pnp_dev_info); } static void kbc1100_init(struct device *dev) { - struct resource *res0, *res1; + struct resource *res0, *res1; + if (!dev->enabled) + return; - - if (!dev->enabled) { - return; - } - - switch(dev->path.pnp.device) { - - case KBC1100_KBC: - res0 = find_resource(dev, PNP_IDX_IO0); - res1 = find_resource(dev, PNP_IDX_IO1); - pc_keyboard_init(NO_AUX_DEVICE); - break; - } + switch (dev->path.pnp.device) { + case KBC1100_KBC: + res0 = find_resource(dev, PNP_IDX_IO0); + res1 = find_resource(dev, PNP_IDX_IO1); + pc_keyboard_init(NO_AUX_DEVICE); + break; + } } -- To view, visit https://review.coreboot.org/20852 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8940f712c0161419ee0c383b7bc9eb581967366e Gerrit-Change-Number: 20852 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: soc/intel/skylake: Enable UART debug port on S3 resume
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20835 ) Change subject: soc/intel/skylake: Enable UART debug port on S3 resume ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58126/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13553/ : SUCCESS -- To view, visit https://review.coreboot.org/20835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Gerrit-Change-Number: 20835 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 19:49:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Allow SoC to enable UART resources
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20851 ) Change subject: soc/intel/common: Allow SoC to enable UART resources ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58125/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13552/ : SUCCESS -- To view, visit https://review.coreboot.org/20851 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id21447b090d8ed8c44b3b464f49ea12de58fbee2 Gerrit-Change-Number: 20851 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 19:33:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common: Add lpss.c to ramstage
by build bot (Jenkins) (Code Review) 01 Aug '17

01 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20850 ) Change subject: soc/intel/common: Add lpss.c to ramstage ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58124/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13551/ : SUCCESS -- To view, visit https://review.coreboot.org/20850 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e05d65ebb3b6499451242521ffc61fc4c952830 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 19:28:55 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017