August 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: google/gru: Correct Scarlet pwm regulator minimum value and maximum v...
by build bot (Jenkins) (Code Review) Aug. 1, 2017

Aug. 1, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20831 ) Change subject: google/gru: Correct Scarlet pwm regulator minimum value and maximum value ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58096/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13527/ : SUCCESS -- To view, visit https://review.coreboot.org/20831 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f722eabb697b3438d9f4aa29c205b0161eb442a Gerrit-Change-Number: 20831 Gerrit-PatchSet: 3 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 09:27:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19837 ) Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID ...................................................................... Patch Set 28: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58095/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13526/ : SUCCESS -- To view, visit https://review.coreboot.org/19837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693db6d6506af7ff40db0b3ce4cc6c1469f6ef Gerrit-Change-Number: 19837 Gerrit-PatchSet: 28 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 04:10:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19837 ) Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID ...................................................................... Patch Set 27: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58094/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13525/ : SUCCESS -- To view, visit https://review.coreboot.org/19837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693db6d6506af7ff40db0b3ce4cc6c1469f6ef Gerrit-Change-Number: 19837 Gerrit-PatchSet: 27 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 04:04:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Use generic gpio library
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20543 ) Change subject: soc/amd/stoneyridge: Use generic gpio library ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58093/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13524/ : SUCCESS -- To view, visit https://review.coreboot.org/20543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ea562b052401efff3101f736788ca77d21e6de6 Gerrit-Change-Number: 20543 Gerrit-PatchSet: 9 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 03:44:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19837 ) Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID ...................................................................... Patch Set 26: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58092/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13523/ : SUCCESS -- To view, visit https://review.coreboot.org/19837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693db6d6506af7ff40db0b3ce4cc6c1469f6ef Gerrit-Change-Number: 19837 Gerrit-PatchSet: 26 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 03:44:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable UART debug port in bootblock always
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20835 ) Change subject: soc/intel/skylake: Enable UART debug port in bootblock always ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58091/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13522/ : SUCCESS -- To view, visit https://review.coreboot.org/20835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Gerrit-Change-Number: 20835 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 02:39:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable UART debug port in bootblock always
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20835 ) Change subject: soc/intel/skylake: Enable UART debug port in bootblock always ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58090/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/13521/ : SUCCESS -- To view, visit https://review.coreboot.org/20835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Gerrit-Change-Number: 20835 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 02:32:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/uart: Use baudrate of 115200 by default
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20834 ) Change subject: drivers/uart: Use baudrate of 115200 by default ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58089/ : SUCCESS -- To view, visit https://review.coreboot.org/20834 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida4c7ae77aba5dfd4ec331e22a54ce43a91bde00 Gerrit-Change-Number: 20834 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 02:24:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable UART debug port in bootblock always
by build bot (Jenkins) (Code Review) July 31, 2017

July 31, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20835 ) Change subject: soc/intel/skylake: Enable UART debug port in bootblock always ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58088/ : UNSTABLE -- To view, visit https://review.coreboot.org/20835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Gerrit-Change-Number: 20835 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 Aug 2017 02:22:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable UART debug port in bootblock always
by Furquan Shaikh (Code Review) July 31, 2017

July 31, 2017

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20835 to look at the new patch set (#2). Change subject: soc/intel/skylake: Enable UART debug port in bootblock always ...................................................................... soc/intel/skylake: Enable UART debug port in bootblock always Irrespective of whether UART_DEBUG is enabled in coreboot or not, always enable UART controller for the debug port. This is required because: UART hardware loses power while the system is suspended. Linux kernel does not re-initialize the UART controller on resume and so when serial console is enabled in kernel, it can result in hangs on resume from S3. On platforms like baytrail, this was handled in a similar way by initializing UART controller on resume(https://chromium-review.googlesource.com/188011). In this change, UART is always initialized in bootblock irrespective of normal or S3 resume flow in order to re-use the UART drivers that are already implemented and avoid redundancy. BUG=b:64030366 TEST=Verified that kernel does not hang with the following sequence: echo 'N' > /sys/module/printk/parameters/console_suspend echo mem > /sys/power/state <Resume from S3> Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/Makefile.inc M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/uart.c 4 files changed, 7 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/20835/2 -- To view, visit https://review.coreboot.org/20835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic936ac2a787fdc83935103c3ce4ed8f124a97a89 Gerrit-Change-Number: 20835 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0