coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p
by Patrick Rudolph (Code Review) 27 Jul '17

27 Jul '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/20501 ) Change subject: mainboard/hp: Add HP Elitebook 8460p ...................................................................... Patch Set 6: (3 comments) With that fixed all boards seem ready to be pushed. https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb File src/mainboard/hp/8460p/devicetree.cb: https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.c… PS6, Line 17: chip northbridge/intel/sandybridge # FIXME: check gfx.ndid and gfx.did remove all FIXMEs https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.c… PS6, Line 18: register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" last two elements can be removed ad gfx.ndid is 3 https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c File src/mainboard/hp/8460p/romstage.c: https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34 PS6, Line 34: { On Ivybridge I've done: RCBA32(FD) = PCH_DISABLE_ALWAYS | 0x10001fe0; Bits that should be always disabled + reserved bits. Applies to all boards. -- To view, visit https://review.coreboot.org/20501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Gerrit-Change-Number: 20501 Gerrit-PatchSet: 6 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 15:39:41 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20789 ) Change subject: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57905/ : SUCCESS -- To view, visit https://review.coreboot.org/20789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e093ed6f5fc29bbea879779eb4777eb371b937 Gerrit-Change-Number: 20789 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 12:53:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller
by Mario Scheithauer (Code Review) 27 Jul '17

27 Jul '17

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/20789 ) Change subject: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e093ed6f5fc29bbea879779eb4777eb371b937 Gerrit-Change-Number: 20789 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 12:11:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20789 ) Change subject: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57904/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13350/ : SUCCESS -- To view, visit https://review.coreboot.org/20789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2e093ed6f5fc29bbea879779eb4777eb371b937 Gerrit-Change-Number: 20789 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 12:09:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vendorcode/siemens: Fix typo in hwilib
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20788 ) Change subject: vendorcode/siemens: Fix typo in hwilib ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57903/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13349/ : SUCCESS -- To view, visit https://review.coreboot.org/20788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I977da687ba8d9d0bad4c184cd0945ecaa52286ad Gerrit-Change-Number: 20788 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 12:04:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller
by Werner Zeh (Code Review) 27 Jul '17

27 Jul '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20789 Change subject: siemens/nc_fpga: Add support for lowest FAN speed to FAN controller ...................................................................... siemens/nc_fpga: Add support for lowest FAN speed to FAN controller The functionality of the FAN controller was extended to enable a lowest startup speed of the FAN. Add the parameter "fanmin" to the fan_ctrl_t structure and initialize the value. Change-Id: Ib2e093ed6f5fc29bbea879779eb4777eb371b937 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/drivers/siemens/nc_fpga/nc_fpga.c M src/drivers/siemens/nc_fpga/nc_fpga.h 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/20789/1 diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c index ab44e23..61d9e08 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga.c +++ b/src/drivers/siemens/nc_fpga/nc_fpga.c @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2016 Siemens AG. + * Copyright (C) 2016-2017 Siemens AG. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -73,6 +73,7 @@ FPGA_SET_PARAM(FANKi, ctrl->ki); FPGA_SET_PARAM(FANKd, ctrl->kd); FPGA_SET_PARAM(FANMaxSpeed, ctrl->fanmax); + FPGA_SET_PARAM(FANStartSpeed, ctrl->fanmin); /* Set freeze and FAN configuration. */ if ((hwilib_get_field(FF_FanReq, &fan_req, 1) == 1) && (hwilib_get_field(FF_FreezeDis, &freeze_disable, 1) == 1)) { diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.h b/src/drivers/siemens/nc_fpga/nc_fpga.h index 2cb0200..7bf087b 100644 --- a/src/drivers/siemens/nc_fpga/nc_fpga.h +++ b/src/drivers/siemens/nc_fpga/nc_fpga.h @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2016 Siemens AG. + * Copyright (C) 2016-2017 Siemens AG. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -60,7 +60,8 @@ uint16_t kp; uint16_t ki; uint16_t kd; - uint16_t res8[2]; + uint16_t fanmin; + uint16_t res8; uint16_t fanmax; uint16_t hystval; uint16_t hystthreshold; -- To view, visit https://review.coreboot.org/20789 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2e093ed6f5fc29bbea879779eb4777eb371b937 Gerrit-Change-Number: 20789 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: vendorcode/siemens: Fix typo in hwilib
by Werner Zeh (Code Review) 27 Jul '17

27 Jul '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/20788 Change subject: vendorcode/siemens: Fix typo in hwilib ...................................................................... vendorcode/siemens: Fix typo in hwilib The parameter shall be FANStartSpeed instead of FANStartpeed. Change-Id: I977da687ba8d9d0bad4c184cd0945ecaa52286ad Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/vendorcode/siemens/hwilib/hwilib.c M src/vendorcode/siemens/hwilib/hwilib.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/20788/1 diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index 08e8da9..0d4a7a0 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -349,7 +349,7 @@ [FANMaxSpeed] = { .pos[0] = {.blk_type = BLK_XIB, .offset = 0x40, .len = 2}, .get_field = hwilib_read_bytes }, - [FANStartpeed] = { + [FANStartSpeed] = { .pos[0] = {.blk_type = BLK_XIB, .offset = 0x42, .len = 2}, .get_field = hwilib_read_bytes }, [FANSensorDelay] = { diff --git a/src/vendorcode/siemens/hwilib/hwilib.h b/src/vendorcode/siemens/hwilib/hwilib.h index 83fcc8f..9739cf3 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.h +++ b/src/vendorcode/siemens/hwilib/hwilib.h @@ -64,7 +64,7 @@ FANHystThreshold, FANHystCtrl, FANMaxSpeed, - FANStartpeed, + FANStartSpeed, FANSensorDelay, FANSensorNum, FANSensorSelect, -- To view, visit https://review.coreboot.org/20788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I977da687ba8d9d0bad4c184cd0945ecaa52286ad Gerrit-Change-Number: 20788 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: mainboard/google/poppy: Update link-frequencies for OV13858 and OV5670
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20787 ) Change subject: mainboard/google/poppy: Update link-frequencies for OV13858 and OV5670 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57902/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13348/ : SUCCESS -- To view, visit https://review.coreboot.org/20787 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78fb2d3527f66b5147123a9c8fc4cb95650f86b6 Gerrit-Change-Number: 20787 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 10:53:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Update link-frequencies for OV13858 and OV5670
by V Sowmya (Code Review) 27 Jul '17

27 Jul '17

V Sowmya has uploaded this change for review. ( https://review.coreboot.org/20787 Change subject: mainboard/google/poppy: Update link-frequencies for OV13858 and OV5670 ...................................................................... mainboard/google/poppy: Update link-frequencies for OV13858 and OV5670 Update the link-frequencies for OV13858 and OV5670 camera sensors. BUG=b:38326541 BRANCH=none TEST=Build and boot soraka. Dump and verify that the generated DSDT table has the required entries. Verified that sensor probe is successful. Change-Id: I78fb2d3527f66b5147123a9c8fc4cb95650f86b6 Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/20787/1 diff --git a/src/mainboard/google/poppy/acpi/mipi_camera.asl b/src/mainboard/google/poppy/acpi/mipi_camera.asl index 0c3ceec..5c75122 100644 --- a/src/mainboard/google/poppy/acpi/mipi_camera.asl +++ b/src/mainboard/google/poppy/acpi/mipi_camera.asl @@ -616,7 +616,7 @@ Package () { 1, 2, 3, 4 } }, Package () { "link-frequencies", - Package() { 1190400000, 640000000 } + Package() { 540000000, 270000000 } }, Package () { "remote-endpoint", Package() { \_SB.PCI0.CIO2, 0, 0 } @@ -766,7 +766,7 @@ Package () { 1, 2 } }, Package () { "link-frequencies", - Package() { 844800000 } + Package() { 422400000 } }, Package () { "remote-endpoint", Package() { \_SB.PCI0.CIO2, 1, 0 } -- To view, visit https://review.coreboot.org/20787 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I78fb2d3527f66b5147123a9c8fc4cb95650f86b6 Gerrit-Change-Number: 20787 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57901/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13347/ : SUCCESS -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 09:12:53 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017