coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: mb/lenovo/t400: Switch to new hybrid graphics driver
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20793 ) Change subject: mb/lenovo/t400: Switch to new hybrid graphics driver ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57918/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13362/ : SUCCESS -- To view, visit https://review.coreboot.org/20793 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad2eccaab19c71f11308853ba9326d8186e67c93 Gerrit-Change-Number: 20793 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 17:44:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20792 ) Change subject: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57917/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13363/ : SUCCESS -- To view, visit https://review.coreboot.org/20792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie467f9a18b35ab3b8a523dbf51c5575db5b374a5 Gerrit-Change-Number: 20792 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 17:40:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/l520/Kconfig: Remove hybrid graphics driver support
by Patrick Rudolph (Code Review) 27 Jul '17

27 Jul '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20798 Change subject: mb/lenovo/l520/Kconfig: Remove hybrid graphics driver support ...................................................................... mb/lenovo/l520/Kconfig: Remove hybrid graphics driver support The schematics isn't available for the board, but other L*00 series boards seem to use a different, compared to T*00 series, GPIO layout. As it never has been tested, remove the broken driver. Change-Id: I4bfa02fdbc5da5b556010c2f300faaf6dc845b80 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/l520/cmos.default M src/mainboard/lenovo/l520/cmos.layout 3 files changed, 5 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/20798/1 diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index 4d317fa..7043184 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -17,7 +17,6 @@ select SOUTHBRIDGE_INTEL_BD82X6X select SYSTEM_TYPE_LAPTOP select USE_NATIVE_RAMINIT - select DRIVERS_LENOVO_HYBRID_GRAPHICS config HAVE_IFD_BIN bool diff --git a/src/mainboard/lenovo/l520/cmos.default b/src/mainboard/lenovo/l520/cmos.default index f38beb4..a0abaed 100644 --- a/src/mainboard/lenovo/l520/cmos.default +++ b/src/mainboard/lenovo/l520/cmos.default @@ -14,5 +14,4 @@ sticky_fn=Disable trackpoint=Enable backlight=Both -hybrid_graphics_mode=Integrated Only usb_always_on=Disable \ No newline at end of file diff --git a/src/mainboard/lenovo/l520/cmos.layout b/src/mainboard/lenovo/l520/cmos.layout index 8075904..678b7a8 100644 --- a/src/mainboard/lenovo/l520/cmos.layout +++ b/src/mainboard/lenovo/l520/cmos.layout @@ -67,7 +67,7 @@ 416 1 e 1 trackpoint 417 1 e 1 fn_ctrl_swap 418 1 e 1 sticky_fn -419 2 e 13 usb_always_on +419 2 e 12 usb_always_on 421 1 e 9 sata_mode 422 2 e 10 backlight @@ -76,8 +76,7 @@ # coreboot config options: northbridge 432 3 e 11 gfx_uma_size -435 2 e 12 hybrid_graphics_mode -#437 3 r 0 unused +#435 5 r 0 unused 440 8 h 0 volume # SandyBridge MRC Scrambler Seed values @@ -134,11 +133,9 @@ 11 4 160M 11 5 192M 11 6 224M -12 0 Integrated Only -12 1 Discrete Only -13 0 Disable -13 1 AC and battery -13 2 AC only +12 0 Disable +12 1 AC and battery +12 2 AC only # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/20798 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4bfa02fdbc5da5b556010c2f300faaf6dc845b80 Gerrit-Change-Number: 20798 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mb/lenovo/t*00/romstage: Switch to new hybrid driver
by Patrick Rudolph (Code Review) 27 Jul '17

27 Jul '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20794 to look at the new patch set (#2). Change subject: mb/lenovo/t*00/romstage: Switch to new hybrid driver ...................................................................... mb/lenovo/t*00/romstage: Switch to new hybrid driver Get rid of old hybrid graphics driver and use the new one. 1. Disable IGD and PEG in early romstage. The PEG port will get disabled on devices that do not have a discrete GPU. The power savings are around ~1Watt. The disabled IGD does no longer waste GFX stolen memory. 2. The Nvidia GPU can be handled by the generic PCI driver and allows to use the _ROM generator for Switchable graphics. 3. Settings are stored in devicetree. One driver for all Lenovo hybrid graphics capable devices. Needs test on all devices. Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/drivers/lenovo/Kconfig M src/drivers/lenovo/Makefile.inc D src/drivers/lenovo/hybrid_graphics.c M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420/romstage.c M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t420s/romstage.c M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t430/romstage.c M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t520/romstage.c M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/romstage.c 13 files changed, 195 insertions(+), 131 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/20794/2 -- To view, visit https://review.coreboot.org/20794 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73 Gerrit-Change-Number: 20794 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Documentation: Create Lesson2.md
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20212 ) Change subject: Documentation: Create Lesson2.md ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57916/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13361/ : SUCCESS -- To view, visit https://review.coreboot.org/20212 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I756b273cf832fc014ba2077a5a4fe4d8009aae6d Gerrit-Change-Number: 20212 Gerrit-PatchSet: 5 Gerrit-Owner: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Evelyn Huang <evhuang(a)google.com> Gerrit-Reviewer: Logan Carlson <logancarlson(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Yves Roth <yves.r.roth(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 17:14:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t400: Switch to new hybrid graphics driver
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20793 ) Change subject: mb/lenovo/t400: Switch to new hybrid graphics driver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57914/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13359/ : SUCCESS -- To view, visit https://review.coreboot.org/20793 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad2eccaab19c71f11308853ba9326d8186e67c93 Gerrit-Change-Number: 20793 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 16:45:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drvs/lenovo/hybrid_graphics: Switch to new hybrid driver
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20794 ) Change subject: drvs/lenovo/hybrid_graphics: Switch to new hybrid driver ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/57915/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13360/ : SUCCESS -- To view, visit https://review.coreboot.org/20794 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73 Gerrit-Change-Number: 20794 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 16:39:02 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20792 ) Change subject: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57913/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13358/ : SUCCESS -- To view, visit https://review.coreboot.org/20792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie467f9a18b35ab3b8a523dbf51c5575db5b374a5 Gerrit-Change-Number: 20792 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 16:39:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19755 ) Change subject: soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 23: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57912/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13357/ : SUCCESS -- To view, visit https://review.coreboot.org/19755 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I811c7ef875b980874f3c4b1f234f969ae5618c44 Gerrit-Change-Number: 19755 Gerrit-PatchSet: 23 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 16:32:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Convert 48Mhz enable to read/write32
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20791 ) Change subject: soc/amd/stoneyridge: Convert 48Mhz enable to read/write32 ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57911/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13356/ : SUCCESS -- To view, visit https://review.coreboot.org/20791 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5430bdb30844d3508a09ddb77a969c0628f6c7d Gerrit-Change-Number: 20791 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 16:30:03 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017