coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57900/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13346/ : ABORTED -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 09:07:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by V Sowmya (Code Review) 27 Jul '17

27 Jul '17

V Sowmya has uploaded a new patch set (#3). ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 The Giantec semiconductor GT24C16S and ON semiconductor CAT24C16 are the industrial standard electrically erasable programmable read only memory (EEPROM's) and this patch adds ACPI objects and power resources for NVMEM device. BUG=b:38326541 BRANCH=none TEST=Build and boot soraka. Dump and verify that the generated DSDT table has the required entries. Read the NVMEM content via sysfs interface. Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl 1 file changed, 75 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20495/3 -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57899/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13345/ : ABORTED -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 09:07:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by V Sowmya (Code Review) 27 Jul '17

27 Jul '17

V Sowmya has uploaded a new patch set (#2). ( https://review.coreboot.org/20495 ) Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S The GT24C16S is an industrial standard electrically erasable programmable read only memory (EEPROM) and this patch adds ACPI objects and power resources for NVMEM device. BUG=b:38326541 BRANCH=none TEST=Build and boot soraka. Dump and verify that the generated DSDT table has the required entries. Read the NVMEM content via sysfs interface. Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl 1 file changed, 65 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20495/2 -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 2 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S an...
by V Sowmya (Code Review) 27 Jul '17

27 Jul '17

V Sowmya has uploaded this change for review. ( https://review.coreboot.org/20495 Change subject: mainboard/google/poppy: Add ACPI objects for NVMEM device GT24C16S and CAT24C16 ...................................................................... mainboardb/google/poppy: Add ACPI objects for NVMEM device GT24C16S The GT24C16S is an industrial standard electrically erasable programmable read only memory (EEPROM) and this patch adds ACPI objects and power resources for NVMEM device. BUG=b:38326541 BRANCH=none TEST=Build and boot soraka. Dump and verify that the generated DSDT table has the required entries. Read the NVMEM content via sysfs interface. Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl 1 file changed, 65 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20495/1 diff --git a/src/mainboard/google/poppy/acpi/mipi_camera.asl b/src/mainboard/google/poppy/acpi/mipi_camera.asl index d32e7a3..b414040 100644 --- a/src/mainboard/google/poppy/acpi/mipi_camera.asl +++ b/src/mainboard/google/poppy/acpi/mipi_camera.asl @@ -278,8 +278,8 @@ } } } ElseIf (LEqual (Arg0, 1)) { - /* Increment only if VSIC < 3 */ - If (LLess (VSIC, 3)) { + /* Increment only if VSIC < 4 */ + If (LLess (VSIC, 4)) { /* Turn on VSIO */ If (LEqual (VSIC, Zero)) { VSIO = 3 @@ -480,6 +480,47 @@ Return (STA) } } + + /* Power resource methods for NVM */ + PowerResource (NVMP, 0, 0) { + Name (STA, 0) + Method (_ON, 0, Serialized) { + If (LEqual (AVBL, 1)) { + If (LEqual (STA, 0)) { + /* Enable VSIO regulator + + daisy chain */ + DOVD(1) + if (LNotEqual (IOVA, 52)) { + /* Set VSIO value as + 1.8006 V */ + IOVA = 52 + } + if (LNotEqual (SIOV, 52)) { + /* Set VSIO value as + 1.8006 V */ + SIOV = 52 + } + Sleep(3) + + STA = 1 + } + } + } + + Method (_OFF, 0, Serialized) { + If (LEqual (AVBL, 1)) { + If (LEqual (STA, 1)) { + DOVD(0) /* Disable regulator */ + Sleep(1) + STA = 0 + } + } + } + + Method (_STA, 0, NotSerialized) { + Return (STA) + } + } } Device (CAM0) @@ -612,6 +653,28 @@ Name (_PR0, Package () { ^PMIC.VCMP }) Name (_PR3, Package () { ^PMIC.VCMP }) } + + Device (NVM0) + { + Name (_HID, "GIAN0001") /* _HID: Hardware ID */ + Name (_UID, Zero) /* _UID: Unique ID */ + Name (_DDN, "Giantec GT24C16S") /* _DDN: DOS Device Name */ + Method (_STA, 0, NotSerialized) /* _STA: Status */ + { + Return (0x0F) + } + + Name (_DEP, Package() {\_SB.PCI0.I2C2.PMIC}) + Name (_CRS, ResourceTemplate () + { + I2cSerialBus (0x0050, ControllerInitiated, 0x00061A80, + AddressingMode7Bit, "\\_SB.PCI0.I2C2", + 0x00, ResourceConsumer, ,) + }) + + Name (_PR0, Package () { ^PMIC.NVMP }) + Name (_PR3, Package () { ^PMIC.NVMP }) + } } Scope (\_SB.PCI0.I2C4) -- To view, visit https://review.coreboot.org/20495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If49ed33b7e1de1eabf317b31ceed8568dfca0aae Gerrit-Change-Number: 20495 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass(a)intel.corp-partner.google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: mb/lenovo: add Lenovo ThinkPad X131e (Intel)
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20694 ) Change subject: mb/lenovo: add Lenovo ThinkPad X131e (Intel) ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57898/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13344/ : SUCCESS -- To view, visit https://review.coreboot.org/20694 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8de3a9308997e2d57aee869023ee9a43a2db872 Gerrit-Change-Number: 20694 Gerrit-PatchSet: 4 Gerrit-Owner: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 08:15:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: move spi_uvscc and spi_lvscc to devicetree.cb
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20486 ) Change subject: autoport: move spi_uvscc and spi_lvscc to devicetree.cb ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57897/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13343/ : SUCCESS -- To view, visit https://review.coreboot.org/20486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36866cc793b3ddf9a78fed2e2840958d08327e7d Gerrit-Change-Number: 20486 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 07:59:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 8460p
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20501 ) Change subject: mainboard/hp: Add HP Elitebook 8460p ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57896/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13342/ : SUCCESS -- To view, visit https://review.coreboot.org/20501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c42723ba240a2e9b46998c1a8a708aebc66c604 Gerrit-Change-Number: 20501 Gerrit-PatchSet: 6 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 07:56:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2570p
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20489 ) Change subject: mainboard/hp: Add HP Elitebook 2570p ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57895/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13341/ : SUCCESS -- To view, visit https://review.coreboot.org/20489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f3cd124fc676d49add59e9f0a07f70a6bb0fff0 Gerrit-Change-Number: 20489 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 07:53:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 27 Jul '17

27 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboard/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 30: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57893/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13339/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 30 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 27 Jul 2017 07:52:35 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017