coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: ec/lenovo/h8/smm: Support USB always on AC only
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20450 ) Change subject: ec/lenovo/h8/smm: Support USB always on AC only ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56527/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12110/ : SUCCESS -- To view, visit https://review.coreboot.org/20450 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib52aab427ff687b00129024cde65b78060d21e32 Gerrit-Change-Number: 20450 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 15:48:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/smm: Support USB always on AC only
by Patrick Rudolph (Code Review) 01 Jul '17

01 Jul '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20450 Change subject: ec/lenovo/h8/smm: Support USB always on AC only ...................................................................... ec/lenovo/h8/smm: Support USB always on AC only Add support for UAO AC only mode. Needs tests on all platforms. Change-Id: Ib52aab427ff687b00129024cde65b78060d21e32 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/smm.c M src/mainboard/lenovo/x201/cmos.layout M src/mainboard/lenovo/x220/cmos.layout 3 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/20450/1 diff --git a/src/ec/lenovo/h8/smm.c b/src/ec/lenovo/h8/smm.c index 31009a6..6005c31 100644 --- a/src/ec/lenovo/h8/smm.c +++ b/src/ec/lenovo/h8/smm.c @@ -18,18 +18,30 @@ #include "h8.h" +enum usb_always_on { + UAO_OFF = 0, + UAO_AC_AND_BATTERY, + UAO_AC_ONLY +}; + void h8_usb_always_on(void) { - u8 val; + enum usb_always_on val; u8 reg; if (get_option(&val, "usb_always_on") != CB_SUCCESS) - val = 0; + val = UAO_OFF; - if (val) { + if (val == UAO_AC_AND_BATTERY) { reg = ec_read(H8_USB_ALWAYS_ON); reg &= ~H8_USB_ALWAYS_ON_AC_ONLY; reg |= H8_USB_ALWAYS_ON_ENABLE; ec_write(H8_USB_ALWAYS_ON, reg); + } else if (val == UAO_AC_ONLY) { + reg = ec_read(H8_USB_ALWAYS_ON); + reg |= H8_USB_ALWAYS_ON_AC_ONLY; + reg |= H8_USB_ALWAYS_ON_ENABLE; + ec_write(H8_USB_ALWAYS_ON, reg); + ec_set_bit(0x2, 3); } } diff --git a/src/mainboard/lenovo/x201/cmos.layout b/src/mainboard/lenovo/x201/cmos.layout index 7270232..8b40585 100644 --- a/src/mainboard/lenovo/x201/cmos.layout +++ b/src/mainboard/lenovo/x201/cmos.layout @@ -125,6 +125,7 @@ 10 6 160M 11 0 Disable 11 1 AC and battery +11 2 AC only # ----------------------------------------------------------------- checksums diff --git a/src/mainboard/lenovo/x220/cmos.layout b/src/mainboard/lenovo/x220/cmos.layout index 77979b3..93e7ba9 100644 --- a/src/mainboard/lenovo/x220/cmos.layout +++ b/src/mainboard/lenovo/x220/cmos.layout @@ -136,6 +136,7 @@ 11 6 224M 12 0 Disable 12 1 AC and battery +12 2 AC only # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/20450 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib52aab427ff687b00129024cde65b78060d21e32 Gerrit-Change-Number: 20450 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: northbridge/intel/haswell: Fix undefined behavior.
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20447 ) Change subject: northbridge/intel/haswell: Fix undefined behavior. ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56526/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12109/ : SUCCESS -- To view, visit https://review.coreboot.org/20447 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d34e4f05494c17bf9b9dec113b8f6863214e56 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 2 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 15:37:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: KBL: Update FSP headers - upgrade to FSP 2.5.0
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20123 ) Change subject: KBL: Update FSP headers - upgrade to FSP 2.5.0 ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56524/ : SUCCESS -- To view, visit https://review.coreboot.org/20123 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id31ddd4595e36c91ba7c888688114c4dbe4db86a Gerrit-Change-Number: 20123 Gerrit-PatchSet: 3 Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 14:42:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: x86/acpigen: Fix acpigen_write_field
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19435 ) Change subject: x86/acpigen: Fix acpigen_write_field ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56523/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12107/ : SUCCESS -- To view, visit https://review.coreboot.org/19435 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac3600f184e6bd36a2bcb85753110692fbcbe4b6 Gerrit-Change-Number: 19435 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 14:40:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/h8: Always enable tp-smapi and thermal
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19864 ) Change subject: ec/lenovo/h8/h8: Always enable tp-smapi and thermal ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56522/ : SUCCESS -- To view, visit https://review.coreboot.org/19864 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849 Gerrit-Change-Number: 19864 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 14:17:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/h8: Always enable tp-smapi and thermal
by Philipp Deppenwiese (Code Review) 01 Jul '17

01 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19864 ) Change subject: ec/lenovo/h8/h8: Always enable tp-smapi and thermal ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/19864 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849 Gerrit-Change-Number: 19864 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 13:59:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8/h8: Always enable tp-smapi and thermal
by Patrick Rudolph (Code Review) 01 Jul '17

01 Jul '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19864 to look at the new patch set (#2). Change subject: ec/lenovo/h8/h8: Always enable tp-smapi and thermal ...................................................................... ec/lenovo/h8/h8: Always enable tp-smapi and thermal Always enable tp-smapi and thermal managment. The devicetree already configures the correct values. This patch makes sure that invalid user-settings are ignored. The tp-smapi bit is required for the SMM handler. The thermal bit should be set to allow the EC to monitor thermal state of the platform. Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/h8.c 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/19864/2 -- To view, visit https://review.coreboot.org/19864 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849 Gerrit-Change-Number: 19864 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/*/devicetree: Add BDC detection support
by Philipp Deppenwiese (Code Review) 01 Jul '17

01 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19810 ) Change subject: mb/lenovo/*/devicetree: Add BDC detection support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19810 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If33ef88fb808f36b050393fa83eb1b541ce936b9 Gerrit-Change-Number: 19810 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 13:46:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Add BDC detection support
by Philipp Deppenwiese (Code Review) 01 Jul '17

01 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19809 ) Change subject: ec/lenovo/h8: Add BDC detection support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19809 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506de2eca4b820e6d82de6b2c48a5440462e1db5 Gerrit-Change-Number: 19809 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 13:46:27 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017