coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: console: Provide callback in die() path
by Philipp Deppenwiese (Code Review) 01 Jul '17

01 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19696 ) Change subject: console: Provide callback in die() path ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-Change-Number: 19696 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 13:44:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Add panic method
by Philipp Deppenwiese (Code Review) 01 Jul '17

01 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/19695 ) Change subject: ec/lenovo/h8: Add panic method ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/19695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Gerrit-Change-Number: 19695 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 13:44:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use common opregion implementation
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20222 ) Change subject: soc/intel/skylake: Use common opregion implementation ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56517/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12102/ : SUCCESS -- To view, visit https://review.coreboot.org/20222 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39190488e12917a09dbf7ee3947a33940ebc290b Gerrit-Change-Number: 20222 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 06:02:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/fsp1_1: remove VBT function defs from util.h
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20448 ) Change subject: drivers/fsp1_1: remove VBT function defs from util.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56516/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12101/ : SUCCESS -- To view, visit https://review.coreboot.org/20448 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d82c2da40b067272d876929fc73b97f490146a7 Gerrit-Change-Number: 20448 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 05:55:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/fsp1_1: remove VBT function defs from util.h
by Matt DeVillier (Code Review) 01 Jul '17

01 Jul '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/20448 Change subject: drivers/fsp1_1: remove VBT function defs from util.h ...................................................................... drivers/fsp1_1: remove VBT function defs from util.h Including <fsp/gop.h> in util.h causes issues with redeclarations when using SOC_INTEL_COMMON_GFX_OPREGION along with FSP 1.1. Separating it out and including directly in vbt.c has no negative side effects. Change-Id: I2d82c2da40b067272d876929fc73b97f490146a7 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/drivers/intel/fsp1_1/include/fsp/util.h M src/drivers/intel/fsp1_1/vbt.c 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/20448/1 diff --git a/src/drivers/intel/fsp1_1/include/fsp/util.h b/src/drivers/intel/fsp1_1/include/fsp/util.h index 8f55256..ffc43bc 100644 --- a/src/drivers/intel/fsp1_1/include/fsp/util.h +++ b/src/drivers/intel/fsp1_1/include/fsp/util.h @@ -21,7 +21,6 @@ #include <fsp/api.h> /* Current users expect to get the SoC's FSP definitions by including util.h. */ #include <fsp/soc_binding.h> -#include <fsp/gop.h> #include <program_loading.h> #include <commonlib/region.h> diff --git a/src/drivers/intel/fsp1_1/vbt.c b/src/drivers/intel/fsp1_1/vbt.c index 5cac150..92a4c91 100644 --- a/src/drivers/intel/fsp1_1/vbt.c +++ b/src/drivers/intel/fsp1_1/vbt.c @@ -17,6 +17,7 @@ #include <bootmode.h> #include <cbfs.h> #include <console/console.h> +#include <fsp/gop.h> #include <fsp/ramstage.h> #include <fsp/util.h> -- To view, visit https://review.coreboot.org/20448 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2d82c2da40b067272d876929fc73b97f490146a7 Gerrit-Change-Number: 20448 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: northbridge/intel/haswell: Fix copy paste error
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20445 ) Change subject: northbridge/intel/haswell: Fix copy paste error ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56515/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12100/ : SUCCESS -- To view, visit https://review.coreboot.org/20445 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48866d9243c2a576a02519724429801ae47c5644 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 2 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 02:16:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: southbridge/intel/lynxpoint: Fix undefined behavior
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20446 ) Change subject: southbridge/intel/lynxpoint: Fix undefined behavior ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56514/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12099/ : SUCCESS -- To view, visit https://review.coreboot.org/20446 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3c95e36e8b7f88ed69d5339e299c40934cb87da Gerrit-Change-Number: 20446 Gerrit-PatchSet: 2 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 02:12:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: northbridge/intel/haswell: Fix undefined behavior.
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20447 ) Change subject: northbridge/intel/haswell: Fix undefined behavior. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56513/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12098/ : SUCCESS -- To view, visit https://review.coreboot.org/20447 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2d34e4f05494c17bf9b9dec113b8f6863214e56 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 02:04:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: northbridge/intel/haswell: Fix undefined behavior.
by Ryan Salsamendi (Code Review) 01 Jul '17

01 Jul '17

Ryan Salsamendi has uploaded this change for review. ( https://review.coreboot.org/20447 Change subject: northbridge/intel/haswell: Fix undefined behavior. ...................................................................... northbridge/intel/haswell: Fix undefined behavior. Fix reports found by undefined behavior sanitizer. Left shifting an int where the right operand is >= the width of the type is undefined. Add UL suffix since it's safe for unsigned types. Change-Id: If2d34e4f05494c17bf9b9dec113b8f6863214e56 Signed-off-by: Ryan Salsamendi <rsalsamendi(a)hotmail.com> --- M src/drivers/intel/gma/i915_reg.h M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/haswell/northbridge.c 3 files changed, 12 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/20447/1 diff --git a/src/drivers/intel/gma/i915_reg.h b/src/drivers/intel/gma/i915_reg.h index dee6865..e88ecfb 100644 --- a/src/drivers/intel/gma/i915_reg.h +++ b/src/drivers/intel/gma/i915_reg.h @@ -2979,7 +2979,7 @@ /* Ironlake */ #define CPU_VGACNTRL 0x41000 -#define CPU_VGA_DISABLE (1<<31) +#define CPU_VGA_DISABLE (1UL<<31) #define DIGITAL_PORT_HOTPLUG_CNTRL 0x44030 #define DIGITAL_PORTA_HOTPLUG_ENABLE (1 << 4) @@ -4177,7 +4177,7 @@ #define HSW_PWR_WELL_CTL2 0x45404 /* Driver */ #define HSW_PWR_WELL_CTL3 0x45408 /* KVMR */ #define HSW_PWR_WELL_CTL4 0x4540C /* Debug */ -#define HSW_PWR_WELL_ENABLE (1<<31) +#define HSW_PWR_WELL_ENABLE (1UL<<31) #define HSW_PWR_WELL_STATE (1<<30) #define HSW_PWR_WELL_CTL5 0x45410 #define HSW_PWR_WELL_ENABLE_SINGLE_STEP (1<<31) diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index f22ff48..75f3b7a 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -252,13 +252,13 @@ gtt_write_regs(haswell_gt_setup); /* Wait for Mailbox Ready */ - gtt_poll(0x138124, (1 << 31), (0 << 31)); + gtt_poll(0x138124, (1UL << 31), (0UL << 31)); /* Mailbox Data - RC6 VIDS */ gtt_write(0x138128, 0x00000000); /* Mailbox Command */ gtt_write(0x138124, 0x80000004); /* Wait for Mailbox Ready */ - gtt_poll(0x138124, (1 << 31), (0 << 31)); + gtt_poll(0x138124, (1UL << 31), (0UL << 31)); /* Enable PM Interrupts */ gtt_write(GEN6_PMIER, GEN6_PM_MBOX_EVENT | GEN6_PM_THERMAL_EVENT | diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index a8c8015..3753942 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -36,6 +36,7 @@ static int get_pcie_bar(device_t dev, unsigned int index, u32 *base, u32 *len) { u32 pciexbar_reg; + u32 mask; *base = 0; *len = 0; @@ -47,15 +48,19 @@ switch ((pciexbar_reg >> 1) & 3) { case 0: // 256MB - *base = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 29)|(1 << 28)); + mask = ((1UL << 31)|(1 << 30)|(1 << 29)|(1 << 28)); + *base = pciexbar_reg & mask; *len = 256 * 1024 * 1024; return 1; case 1: // 128M - *base = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 29)|(1 << 28)|(1 << 27)); + mask = ((1UL << 31)|(1 << 30)|(1 << 29)|(1 << 28)|(1 << 27)); + *base = pciexbar_reg & mask; *len = 128 * 1024 * 1024; return 1; case 2: // 64M - *base = pciexbar_reg & ((1 << 31)|(1 << 30)|(1 << 29)|(1 << 28)|(1 << 27)|(1 << 26)); + mask = ((1UL << 31)|(1 << 30)|(1 << 29)|(1 << 28)|(1 << 27)); + mask |= (1 << 26); + *base = pciexbar_reg & mask; *len = 64 * 1024 * 1024; return 1; } -- To view, visit https://review.coreboot.org/20447 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If2d34e4f05494c17bf9b9dec113b8f6863214e56 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com>

1 0

Change in coreboot[master]: southbridge/intel/lynxpoint: Fix undefined behavior
by build bot (Jenkins) (Code Review) 01 Jul '17

01 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20446 ) Change subject: southbridge/intel/lynxpoint: Fix undefined behavior ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/56512/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/12097/ : SUCCESS -- To view, visit https://review.coreboot.org/20446 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3c95e36e8b7f88ed69d5339e299c40934cb87da Gerrit-Change-Number: 20446 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 01 Jul 2017 01:25:47 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017