coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: sb/intel/i82870: Add whitespace around '<<'
by build bot (Jenkins) (Code Review) 04 Jul '17

04 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20460 ) Change subject: sb/intel/i82870: Add whitespace around '<<' ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56562/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12138/ : SUCCESS -- To view, visit https://review.coreboot.org/20460 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b0e6404a3f90312f7d2d3b6c367b0a1d9ec6e2 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 19:34:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: console: Add weak method to notify about death
by build bot (Jenkins) (Code Review) 04 Jul '17

04 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19696 ) Change subject: console: Add weak method to notify about death ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56560/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12137/ : SUCCESS -- To view, visit https://review.coreboot.org/19696 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71f8ddfc96047e8a0d39f084588db1fe2f251612 Gerrit-Change-Number: 19696 Gerrit-PatchSet: 9 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 18:36:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Add panic method
by build bot (Jenkins) (Code Review) 04 Jul '17

04 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19695 ) Change subject: ec/lenovo/h8: Add panic method ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56561/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12136/ : SUCCESS -- To view, visit https://review.coreboot.org/19695 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8 Gerrit-Change-Number: 19695 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 18:32:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Remove unused SD controller
by Martin Roth (Code Review) 04 Jul '17

04 Jul '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/20401 ) Change subject: soc/amd/stoneyridge: Remove unused SD controller ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/20401/1/src/soc/amd/stoneyridge/hudson.c File src/soc/amd/stoneyridge/hudson.c: https://review.coreboot.org/#/c/20401/1/src/soc/amd/stoneyridge/hudson.c@63 PS1, Line 63: void hudson_enable(device_t dev) Why not get rid of it completely? -- To view, visit https://review.coreboot.org/20401 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7dbd70320740e8a05e6bf16af125d67012f20674 Gerrit-Change-Number: 20401 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 00:03:19 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/ibexpeak: Add whitespace around '<<'
by build bot (Jenkins) (Code Review) 03 Jul '17

03 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20459 ) Change subject: sb/intel/ibexpeak: Add whitespace around '<<' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56555/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12131/ : SUCCESS -- To view, visit https://review.coreboot.org/20459 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3a69f45b48c19c61b12a992b23dad1693bf5f9e Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Jul 2017 19:56:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82870: Add whitespace around '<<'
by build bot (Jenkins) (Code Review) 03 Jul '17

03 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20460 ) Change subject: sb/intel/i82870: Add whitespace around '<<' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56556/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12132/ : SUCCESS -- To view, visit https://review.coreboot.org/20460 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b0e6404a3f90312f7d2d3b6c367b0a1d9ec6e2 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Jul 2017 19:55:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82870: Add whitespace around '<<'
by HAOUAS Elyes (Code Review) 03 Jul '17

03 Jul '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20460 Change subject: sb/intel/i82870: Add whitespace around '<<' ...................................................................... sb/intel/i82870: Add whitespace around '<<' Change-Id: Ic8b0e6404a3f90312f7d2d3b6c367b0a1d9ec6e2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/i82870/ioapic.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/20460/1 diff --git a/src/southbridge/intel/i82870/ioapic.c b/src/southbridge/intel/i82870/ioapic.c index a02a2af..8281eb3 100644 --- a/src/southbridge/intel/i82870/ioapic.c +++ b/src/southbridge/intel/i82870/ioapic.c @@ -68,9 +68,9 @@ apic_id <<= 24; // Convert ID to bitmask *pIndexRegister = 0; // Select APIC ID register - *pWindowRegister = (*pWindowRegister & ~(0xF<<24)) | apic_id; // Set the ID + *pWindowRegister = (*pWindowRegister & ~(0xF << 24)) | apic_id; // Set the ID - if ((*pWindowRegister & (0xF<<24)) != apic_id) + if ((*pWindowRegister & (0xF << 24)) != apic_id) die("p64h2_ioapic_init failed"); *pIndexRegister = 3; // Select Boot Configuration register -- To view, visit https://review.coreboot.org/20460 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic8b0e6404a3f90312f7d2d3b6c367b0a1d9ec6e2 Gerrit-Change-Number: 20460 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Add whitespace around '<<'
by build bot (Jenkins) (Code Review) 03 Jul '17

03 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20458 ) Change subject: sb/intel/lynxpoint: Add whitespace around '<<' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56554/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12130/ : SUCCESS -- To view, visit https://review.coreboot.org/20458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b2a16e8eb70819c72efd50f30a57f3687f31bb5 Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Jul 2017 19:49:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/ibexpeak: Add whitespace around '<<'
by HAOUAS Elyes (Code Review) 03 Jul '17

03 Jul '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20459 Change subject: sb/intel/ibexpeak: Add whitespace around '<<' ...................................................................... sb/intel/ibexpeak: Add whitespace around '<<' Change-Id: Ib3a69f45b48c19c61b12a992b23dad1693bf5f9e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/ibexpeak/smi.c M src/southbridge/intel/ibexpeak/smihandler.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/20459/1 diff --git a/src/southbridge/intel/ibexpeak/smi.c b/src/southbridge/intel/ibexpeak/smi.c index 950dbe0..961f3d5 100644 --- a/src/southbridge/intel/ibexpeak/smi.c +++ b/src/southbridge/intel/ibexpeak/smi.c @@ -181,9 +181,9 @@ reg32 = inl(tcobase + 0x04); /* set status bits are cleared by writing 1 to them */ - outl(reg32 & ~(1<<18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS + outl(reg32 & ~(1 << 18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS if (reg32 & (1 << 18)) - outl(reg32 & (1<<18), tcobase + 0x04); // clear BOOT_STS + outl(reg32 & (1 << 18), tcobase + 0x04); // clear BOOT_STS return reg32; } diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c index a0b963e..af25c49 100644 --- a/src/southbridge/intel/ibexpeak/smihandler.c +++ b/src/southbridge/intel/ibexpeak/smihandler.c @@ -215,9 +215,9 @@ reg32 = inl(tcobase + 0x04); /* set status bits are cleared by writing 1 to them */ - outl(reg32 & ~(1<<18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS + outl(reg32 & ~(1 << 18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS if (reg32 & (1 << 18)) - outl(reg32 & (1<<18), tcobase + 0x04); // clear BOOT_STS + outl(reg32 & (1 << 18), tcobase + 0x04); // clear BOOT_STS return reg32; } -- To view, visit https://review.coreboot.org/20459 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib3a69f45b48c19c61b12a992b23dad1693bf5f9e Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: sb/intel/lynxpoint: Add whitespace around '<<'
by HAOUAS Elyes (Code Review) 03 Jul '17

03 Jul '17

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/20458 Change subject: sb/intel/lynxpoint: Add whitespace around '<<' ...................................................................... sb/intel/lynxpoint: Add whitespace around '<<' Change-Id: I1b2a16e8eb70819c72efd50f30a57f3687f31bb5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/lynxpoint/lpc.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/20458/1 diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 37cd94b..513063e 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -371,7 +371,7 @@ pci_write_config32(dev, 0xac, pci_read_config32(dev, 0xac) | (1 << 21)); - pch_iobp_update(0xED00015C, ~(1<<11), 0x00003700); + pch_iobp_update(0xED00015C, ~(1 << 11), 0x00003700); pch_iobp_update(0xED000118, ~0UL, 0x00c00000); pch_iobp_update(0xED000120, ~0UL, 0x00240000); pch_iobp_update(0xCA000000, ~0UL, 0x00000009); @@ -466,7 +466,7 @@ /* Check for LPT-LP B2 stepping and 0:31.0@0xFA > 4 */ if (pci_read_config8(dev_find_slot(0, PCI_DEVFN(2, 0)), 0x8) >= 0x0b) - RCBA32_OR(0x2614, (1<<26)); + RCBA32_OR(0x2614, (1 << 26)); RCBA32_OR(0x900, 0x0000031f); -- To view, visit https://review.coreboot.org/20458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1b2a16e8eb70819c72efd50f30a57f3687f31bb5 Gerrit-Change-Number: 20458 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017