coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: util/cbfstool: strip unused data at the end of Tianocore FVs
by Patrick Georgi (Code Review) 05 Jul '17

05 Jul '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20470 Change subject: util/cbfstool: strip unused data at the end of Tianocore FVs ...................................................................... util/cbfstool: strip unused data at the end of Tianocore FVs There's no need to compress endless streaks of 0xff. It compresses to basically nothing, but it still takes time to process. Change-Id: I6f128eca10bd56f5a0eb1302903de4a4c78aa568 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/cbfstool/cbfs-mkpayload.c 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/20470/1 diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index fd2c4ca..87d3406 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -382,7 +382,13 @@ return -1; } - if (buffer_create(output, (sizeof(segs) + input->size), + uint32_t end = input->size; + while (--end != 0) { + if (((uint8_t *)input->data)[end] != 0xff) + break; + } + + if (buffer_create(output, (sizeof(segs) + end), input->name) != 0) return -1; @@ -393,19 +399,19 @@ /* Prepare code segment */ segs[0].type = PAYLOAD_SEGMENT_CODE; segs[0].load_addr = loadaddress; - segs[0].mem_len = input->size; + segs[0].mem_len = end; segs[0].offset = doffset; - if (!compress(input->data, input->size, output->data + doffset, &len) && - (unsigned int)len < input->size) { + if (!compress(input->data, end, output->data + doffset, &len) && + (unsigned int)len < end) { segs[0].compression = algo; segs[0].len = len; } else { WARN("Compression failed or would make the data bigger " "- disabled.\n"); segs[0].compression = 0; - segs[0].len = input->size; - memcpy(output->data + doffset, input->data, input->size); + segs[0].len = end; + memcpy(output->data + doffset, input->data, end); } /* prepare entry point segment */ -- To view, visit https://review.coreboot.org/20470 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6f128eca10bd56f5a0eb1302903de4a4c78aa568 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/cbfstool: demote FV handling errors to debug
by Patrick Georgi (Code Review) 05 Jul '17

05 Jul '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20469 Change subject: util/cbfstool: demote FV handling errors to debug ...................................................................... util/cbfstool: demote FV handling errors to debug It's rather normal that a few bytes are skipped. Change-Id: I9371afdbb3ad05de7645bfbf257e4f4bfa2feddb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/cbfstool/cbfs-mkpayload.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/20469/1 diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index 45d36f4..fd2c4ca 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -320,7 +320,7 @@ fh = (ffs_file_header_t *)(input->data + fv->header_length); while (fh->file_type == FILETYPE_PAD) { unsigned long offset = (fh->size[2] << 16) | (fh->size[1] << 8) | fh->size[0]; - ERROR("skipping %lu bytes of FV padding\n", offset); + DEBUG("skipping %lu bytes of FV padding\n", offset); fh = (ffs_file_header_t *)(((uintptr_t)fh) + offset); } if (fh->file_type != FILETYPE_SEC) { @@ -332,7 +332,7 @@ cs = (common_section_header_t *)&fh[1]; while (cs->section_type == SECTION_RAW) { unsigned long offset = (cs->size[2] << 16) | (cs->size[1] << 8) | cs->size[0]; - ERROR("skipping %lu bytes of section padding\n", offset); + DEBUG("skipping %lu bytes of section padding\n", offset); cs = (common_section_header_t *)(((uintptr_t)cs) + offset); } if (cs->section_type != SECTION_PE32) { -- To view, visit https://review.coreboot.org/20469 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9371afdbb3ad05de7645bfbf257e4f4bfa2feddb Gerrit-Change-Number: 20469 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/cbfstool: demote not-ELF error to debug
by Patrick Georgi (Code Review) 05 Jul '17

05 Jul '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20468 Change subject: util/cbfstool: demote not-ELF error to debug ...................................................................... util/cbfstool: demote not-ELF error to debug It's irritating when adding tianocore payloads - those are not ELF, but that's deliberate. Change-Id: I76d9367b28545348f526e5f0b8216f9ff2a3d636 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/cbfstool/elfheaders.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/20468/1 diff --git a/util/cbfstool/elfheaders.c b/util/cbfstool/elfheaders.c index 0462d0a..67f01d4 100644 --- a/util/cbfstool/elfheaders.c +++ b/util/cbfstool/elfheaders.c @@ -503,7 +503,7 @@ memset(pelf, 0, sizeof(*pelf)); if (!iself(buffer_get(pinput))) { - ERROR("The stage file is not in ELF format!\n"); + DEBUG("The stage file is not in ELF format!\n"); return -1; } -- To view, visit https://review.coreboot.org/20468 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I76d9367b28545348f526e5f0b8216f9ff2a3d636 Gerrit-Change-Number: 20468 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: cpu/intel/haswell: Fix undefined behavior
by Philipp Deppenwiese (Code Review) 05 Jul '17

05 Jul '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/20467 ) Change subject: cpu/intel/haswell: Fix undefined behavior ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20467 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieacf83d052bf4abfad639ef8e592bd8de17d16e6 Gerrit-Change-Number: 20467 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jul 2017 11:18:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: smbios: Correct the system enclosure types
by Martin Roth (Code Review) 05 Jul '17

05 Jul '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/20463 ) Change subject: smbios: Correct the system enclosure types ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/20463 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5538be0b434eed20d76aef6f26247e46d1225feb Gerrit-Change-Number: 20463 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jul 2017 01:17:38 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Add support for Audio
by build bot (Jenkins) (Code Review) 05 Jul '17

05 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19799 ) Change subject: mainboard/intel/glkrvp: Add support for Audio ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56569/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12145/ : SUCCESS -- To view, visit https://review.coreboot.org/19799 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32022ddacd79917730080889c040f842e0c9e6b9 Gerrit-Change-Number: 19799 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jul 2017 01:11:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Add support for GLKRVP
by build bot (Jenkins) (Code Review) 05 Jul '17

05 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19604 ) Change subject: mainboard/intel/glkrvp: Add support for GLKRVP ...................................................................... Patch Set 65: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56571/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12147/ : SUCCESS -- To view, visit https://review.coreboot.org/19604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef Gerrit-Change-Number: 19604 Gerrit-PatchSet: 65 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jul 2017 01:09:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GL...
by build bot (Jenkins) (Code Review) 05 Jul '17

05 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19739 ) Change subject: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GLKRVP. ...................................................................... Patch Set 12: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56570/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/12146/ : SUCCESS -- To view, visit https://review.coreboot.org/19739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a99bbb70ac9edda8448fabf05e3ea90d18d93c Gerrit-Change-Number: 19739 Gerrit-PatchSet: 12 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 05 Jul 2017 01:08:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/haswell: Fix undefined behavior
by build bot (Jenkins) (Code Review) 04 Jul '17

04 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20467 ) Change subject: cpu/intel/haswell: Fix undefined behavior ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56568/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12144/ : SUCCESS -- To view, visit https://review.coreboot.org/20467 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieacf83d052bf4abfad639ef8e592bd8de17d16e6 Gerrit-Change-Number: 20467 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 21:09:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/intel/gma: Fix undefined behavior
by build bot (Jenkins) (Code Review) 04 Jul '17

04 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20466 ) Change subject: drivers/intel/gma: Fix undefined behavior ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56567/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12143/ : SUCCESS -- To view, visit https://review.coreboot.org/20466 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5240a19647c8ad59f64925f3e1c199446a886d2d Gerrit-Change-Number: 20466 Gerrit-PatchSet: 1 Gerrit-Owner: Ryan Salsamendi <rsalsamendi(a)hotmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Jul 2017 20:59:56 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017