Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/15057 )
Change subject: payloads/external/tianocore: Update to build uefi corebootpayload
......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/#/c/15057/21/payloads/external/tianocore/Makefi…
File payloads/external/tianocore/Makefile:
Line 61: ( printf " Not found.\n"; echo "ERROR: please_install uuid-dev (uuid-devel)"; exit 1 )
libuuid-devel
--
To view, visit https://review.coreboot.org/15057
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9719ca5c39fccb856dfe096d449760a937d51fd1
Gerrit-PatchSet: 21
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Maurice Ma <mauricexma(a)gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Reviewer: Pablo
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Prabal Saha <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19830 )
Change subject: google/kahlee: Start Kahlee mainboard
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/19830/3/src/mainboard/google/kahlee/bootblo…
File src/mainboard/google/kahlee/bootblock/OemCustomize.c:
PS3, Line 102: static const UINT32 AzaliaCodecAlc286Table[] =
: {
: 0x00172051, 0x001721C7, 0x00172222, 0x00172310,
: 0x0017FF00, 0x0017FF00, 0x0017FF00, 0x0017FF00,
: 0x01271C50, 0x01271D01, 0x01271EA6, 0x01271FB7,
: 0x01371C00, 0x01371D00, 0x01371E00, 0x01371F40,
: 0x01471C10, 0x01471D01, 0x01471E17, 0x01471F90,
: 0x01771CF0, 0x01771D11, 0x01771E11, 0x01771F41,
: 0x01871C40, 0x01871D10, 0x01871EA1, 0x01871F04,
: 0x01971CF0, 0x01971D11, 0x01971E11, 0x01971F41,
: 0x01A71CF0, 0x01A71D11, 0x01A71E11, 0x01A71F41,
: 0x01D71C2D, 0x01D71DA5, 0x01D71E67, 0x01D71F40,
: 0x01E71C30, 0x01E71D11, 0x01E71E45, 0x01E71F04,
: 0x02171C20, 0x02171D10, 0x02171E21, 0x02171F04,
: 0x02050071, 0x02040014, 0x02050010, 0x02040C22,
: 0x0205004F, 0x0204B029, 0x0205002B, 0x02040C50,
: 0x0205002D, 0x02041020, 0x02050020, 0x02040000,
: 0x02050019, 0x02040817, 0x02050035, 0x02041AA5,
: 0x02050063, 0x02042906, 0x02050063, 0x02042906,
: 0xffffffff
: };
> Ah, I understand your comment as about this file. This probably needs a bet
I mentioned it in the Gardenia file where this went into the bootblock, but Stefan may not have seen it. These are customizations to the AmdInitEarly() call, which I really sort of need to be in bootblock. Unsure, at this time, whether the ability could be applied to a later entry point instead. (Marc had found something like that with GPIOs.)
--
To view, visit https://review.coreboot.org/19830
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia68b16969518f4d63d5d2dea7658a472b2daca05
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/15057 )
Change subject: payloads/external/tianocore: Update to build uefi corebootpayload
......................................................................
Patch Set 21:
Latest edk2 seems to compile just fine with at least gcc 7.1
--
To view, visit https://review.coreboot.org/15057
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9719ca5c39fccb856dfe096d449760a937d51fd1
Gerrit-PatchSet: 21
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Maurice Ma <mauricexma(a)gmail.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com>
Gerrit-Reviewer: Pablo
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Prabal Saha <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No