Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19375
to look at the new patch set (#4).
Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code
......................................................................
[WIP]soc/intel/apollolake: Add support in APL for PMC common code
Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2
Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/bootblock/bootblock.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/include/soc/gpe.h
M src/soc/intel/apollolake/include/soc/pm.h
M src/soc/intel/apollolake/pmc.c
M src/soc/intel/apollolake/pmutil.c
M src/soc/intel/apollolake/reset.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/apollolake/smi.c
10 files changed, 41 insertions(+), 376 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/19375/4
--
To view, visit https://review.coreboot.org/19375
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has posted comments on this change. ( https://review.coreboot.org/20004 )
Change subject: superio/winbond/*/header: Include <arch/io.h>
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/20004
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6bcea4377359c15e3148062458186ee222b8e2
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19988 )
Change subject: cpu/amd/car: Fix checkpatch warnings
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/disable_cache_as_ra…
File src/cpu/amd/car/disable_cache_as_ram.c:
PS1, Line 61: msr.lo &= ~(SYSCFG_MSR_MtrrFixDramEn
: | SYSCFG_MSR_MtrrFixDramModEn);
> too bad this doesn't fit in one line
can you align after "=&"?
--
To view, visit https://review.coreboot.org/19988
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a5abaa06f8e285ff58436789318cb9cd3b7ac3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Evelyn Huang <evhuang(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19987 )
Change subject: src/cpu/amd/quadcore Fix checkpatch errors/warnings
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/19987/1/src/cpu/amd/quadcore/amd_sibling.c
File src/cpu/amd/quadcore/amd_sibling.c:
PS1, Line 108: 8 * siblings + sysconf.nodes;
isn't it cleaner to align just after the "="?
https://review.coreboot.org/#/c/19987/1/src/cpu/amd/quadcore/quadcore.c
File src/cpu/amd/quadcore/quadcore.c:
PS1, Line 62: "Start
same here, align after the "("?
and so on
--
To view, visit https://review.coreboot.org/19987
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0a28c12e209547b3625f4ca1696f9c26dc2b6d0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Evelyn Huang <evhuang(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20004 )
Change subject: superio/winbond/*/header: Include <arch/io.h>
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/20004
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6bcea4377359c15e3148062458186ee222b8e2
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No