coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...
by Hannah Williams (Code Review) 01 Jun '17

01 Jun '17

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 ) Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common ...................................................................... Patch Set 20: (3 comments) https://review.coreboot.org/#/c/19759/15/src/soc/intel/common/block/gpio/gp… File src/soc/intel/common/block/gpio/gpio.c: PS15, Line 68: GPIO_MAX_NUM_PER_GROUP > This is the 'group' within the community. But you are saying that the gpio I'll add this as a field inside the community. https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/gpio/gp… File src/soc/intel/common/block/gpio/gpio.c: PS20, Line 54: 32 > Shouldn't this be GPIO_MAX_NUM_PER_GROUP? I'll move this as a field inside const struct pad_community - because each group or community can also have a different max number of pins per group PS20, Line 80: soc_gpio_configure_itss > Why does this have soc_ in its name? will fix -- To view, visit https://review.coreboot.org/19759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Gerrit-PatchSet: 20 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: src/soc/intel/common: Modify smihandler calls as per common ...
by Shaunak Saha (Code Review) 01 Jun '17

01 Jun '17

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/20006 ) Change subject: src/soc/intel/common: Modify smihandler calls as per common pmc code ...................................................................... Patch Set 6: Code-Review-1 -- To view, visit https://review.coreboot.org/20006 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabadd80962324cf8de6a01d24aad25d257bcb048 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]soc/intel/apollolake: Add support in APL for PMC common...
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19375 ) Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54740/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/10443/ : SUCCESS -- To view, visit https://review.coreboot.org/19375 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/common: Modify smihandler calls as per common ...
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20006 ) Change subject: src/soc/intel/common: Modify smihandler calls as per common pmc code ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54739/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10442/ : SUCCESS -- To view, visit https://review.coreboot.org/20006 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabadd80962324cf8de6a01d24aad25d257bcb048 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP]soc/intel/apollolake: Add support in APL for PMC common...
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19375 ) Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code ...................................................................... Patch Set 9: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54738/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10441/ : SUCCESS -- To view, visit https://review.coreboot.org/19375 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/slippy: populate PEI SPD data for all channels
by Arthur Heymans (Code Review) 01 Jun '17

01 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19981 ) Change subject: google/slippy: populate PEI SPD data for all channels ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19981 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e14b35642a3fbaecaeb7d1d33b5a7c1405bac45 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...
by Furquan Shaikh (Code Review) 01 Jun '17

01 Jun '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19759 ) Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common ...................................................................... Patch Set 20: (11 comments) https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/gpio/Kc… File src/soc/intel/common/block/gpio/Kconfig: Line 16: default n It would be helpful to have help text explaining what this config option does. Same with the config option below. https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/gpio/gp… File src/soc/intel/common/block/gpio/gpio.c: PS20, Line 54: 32 Shouldn't this be GPIO_MAX_NUM_PER_GROUP? PS20, Line 55: 32 GPIO_MAX_NUM_PER_GROUP? PS20, Line 80: soc_gpio_configure_itss Why does this have soc_ in its name? PS20, Line 105: pad_cfg_offset + sizeof(uint32_t) It would be better to have macros like PAD_CFG1_OFFSET, PAD_CFG0_OFFSET defined as: #define PAD_CFG0_OFFSET(x) ((x) + GPIO_DWx_SIZE(0)) #define PAD_CFG1_OFFSET(x) ((x) + GPIO_DWx_SIZE(1)) That way it will be clear what register is being read/written to. PS20, Line 123: PAD_CFG_BASE I believe this has to be provided by the SoC. It would be good to document it somewhere what exactly is expected to be implemented by the SoC. Might also be a good idea to have an assert here to ensure that we catch it early if SoC fails to initialize this. PS20, Line 155: gpio_configure_owner(cfg, comm->port, cfg->pad - comm->first_pad); : : gpi_enable_smi(cfg, comm->port, cfg->pad - comm->first_pad); You can also just pass in cfg and comm and let the called function deal with what parameters it wants to use: gpio_configure_owner(cfg, comm); gpi_enable_smi(cfg, comm); PS20, Line 247: int index = 0 You are setting this before using. No need to initialize it to 0. https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/include… File src/soc/intel/common/block/include/intelblocks/gpio.h: Line 67: extra blank line PS20, Line 87: extra blank Line 112: blank line not needed? -- To view, visit https://review.coreboot.org/19759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Gerrit-PatchSet: 20 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [WIP]soc/intel/apollolake: Add support in APL for PMC common...
by Shaunak Saha (Code Review) 01 Jun '17

01 Jun '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19375 to look at the new patch set (#9). Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code ...................................................................... [WIP]soc/intel/apollolake: Add support in APL for PMC common code Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/include/soc/gpe.h M src/soc/intel/apollolake/include/soc/pm.h M src/soc/intel/apollolake/pmc.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/apollolake/reset.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/smi.c 10 files changed, 45 insertions(+), 380 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/19375/9 -- To view, visit https://review.coreboot.org/19375 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]soc/intel/apollolake: Add support in APL for PMC common...
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19375 ) Change subject: [WIP]soc/intel/apollolake: Add support in APL for PMC common code ...................................................................... Patch Set 8: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54737/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10440/ : SUCCESS -- To view, visit https://review.coreboot.org/19375 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322a25a8b608d7fe98bec626c6696e723357a9d2 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/common: Modify smihandler calls as per common ...
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20006 ) Change subject: src/soc/intel/common: Modify smihandler calls as per common pmc code ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54736/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/10439/ : SUCCESS -- To view, visit https://review.coreboot.org/20006 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabadd80962324cf8de6a01d24aad25d257bcb048 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017