coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: soc/intel/common/block: Add Intel PMC support
by Hannah Williams (Code Review) 01 Jun '17

01 Jun '17

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19349 ) Change subject: soc/intel/common/block: Add Intel PMC support ...................................................................... Patch Set 9: (2 comments) https://review.coreboot.org/#/c/19349/9/src/soc/intel/common/block/pmc/Make… File src/soc/intel/common/block/pmc/Makefile.inc: PS9, Line 5: verstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC) += pmc.c does verstage use pmc functions ? https://review.coreboot.org/#/c/19349/9/src/soc/intel/common/block/pmc/pmc.c File src/soc/intel/common/block/pmc/pmc.c: PS9, Line 245: if (IS_ENABLED(CONFIG_SOC_INTEL_APOLLOLAKE)) { why only for APL ? -- To view, visit https://review.coreboot.org/19349 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d96fc23a98c30e8ea0969a7be09d217eeaa889 Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Remove unused PCI ID from SOC header
by Subrata Banik (Code Review) 01 Jun '17

01 Jun '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19927 ) Change subject: soc/intel/apollolake: Remove unused PCI ID from SOC header ...................................................................... Patch Set 3: > > > Apparently this is a dupe: https://review.coreboot.org/#/c/19999/ > > > > :) first patch was on 26th May. not sure how this got missed. > > Ya. Sorry. I just continually cycle back through my inbox. A lot of > the patches seem like a blur. thanks aaron for your time to review the patch and provide great feedback. Don't bother about my last comment, its okay :) -- To view, visit https://review.coreboot.org/19927 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a86256641f4b877de32ca81dfdaef4e9d49334a Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18692 ) Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... Patch Set 23: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54742/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/10445/ : SUCCESS -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by Arthur Heymans (Code Review) 01 Jun '17

01 Jun '17

Hello Paul Menzel, build bot (Jenkins), coreboot org, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18692 to look at the new patch set (#23). Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... nb/intel/x4x/raminit: Rework receive enable calibration Moves receive enable calibration to a separate file to lighten raminit.c a bit. Receive enable calibration is quite similar to gm45 so it reuses some of its function names. The functional changes are: * the minimum coarse is now reset for each channel; * on the second fine search for DQS high, TAP overflow is handled by increasing medium; * start coarse at CAS + 1 instead of CAS - 1. Other Intel northbridges do the same and the results are more in line with register dumps from vendor bios. These might improve stability. TESTED on ga-g41m-es2l Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/Makefile.inc M src/northbridge/intel/x4x/raminit_ddr2.c A src/northbridge/intel/x4x/rcven.c M src/northbridge/intel/x4x/x4x.h 4 files changed, 368 insertions(+), 282 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/18692/23 -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by build bot (Jenkins) (Code Review) 01 Jun '17

01 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18692 ) Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... Patch Set 22: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54741/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/10444/ : SUCCESS -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 22 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by Arthur Heymans (Code Review) 01 Jun '17

01 Jun '17

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by Arthur Heymans (Code Review) 01 Jun '17

01 Jun '17

Hello Paul Menzel, build bot (Jenkins), coreboot org, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18692 to look at the new patch set (#22). Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... nb/intel/x4x/raminit: Rework receive enable calibration Moves receive enable calibration to a separate file to lighten raminit.c a bit. Receive enable calibration is quite similar to gm45 so it reuses some of its function names. The functional changes are: * the minimum coarse is now reset for each channel; * on the second fine search for DQS high, TAP overflow is handled by increasing medium; * start coarse at CAS + 1 instead of CAS - 1. Other Intel northbridges do the same and the results are more in line with register dumps from vendor bios. These might improve stability. TESTED on ga-g41m-es2l Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/Makefile.inc M src/northbridge/intel/x4x/raminit_ddr2.c A src/northbridge/intel/x4x/rcven.c M src/northbridge/intel/x4x/x4x.h 4 files changed, 372 insertions(+), 282 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/18692/22 -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 22 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by Arthur Heymans (Code Review) 01 Jun '17

01 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18692 ) Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... Patch Set 21: (3 comments) https://review.coreboot.org/#/c/18692/21/src/northbridge/intel/x4x/rcven.c File src/northbridge/intel/x4x/rcven.c: PS21, Line 40: #define SAMPLE_COUNT 3 does not seem to improve things. PS21, Line 174: if (sampledqs(addr, lane, channel, DQS_HIGH)) { : printk(BIOS_WARNING, "DQS already HIGH... DQS probe is incosistent!\n" : "Continuing, but be cautious of possible instabilities.\n"); Is still being hit very consistently, so I think there is some hysteresis in this dram controller. I'll just documented it and maybe adapt printed message. PS21, Line 218: /* Some settings are very noisy. Check the next tap */ : /* if the result of the probe is consistent. */ : if (sampledqs(addr, lane, channel, DQS_HIGH)) { : increase_tap(timing); : program_timing(timing, channel, lane); : if (sampledqs(addr, lane, channel, DQS_HIGH)) { : decrease_tap(timing); : program_timing(timing, channel, lane); : break; : } else { : decrease_tap(timing); : } : } Does not seem to improve things since problems don't seem to be caused that much by noise but by hysteresis. -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 21 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Remove unused PCI ID from SOC header
by Subrata Banik (Code Review) 01 Jun '17

01 Jun '17

Subrata Banik has abandoned this change. ( https://review.coreboot.org/19927 ) Change subject: soc/intel/apollolake: Remove unused PCI ID from SOC header ...................................................................... Abandoned https://review.coreboot.org/#/c/19999/ -- To view, visit https://review.coreboot.org/19927 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3a86256641f4b877de32ca81dfdaef4e9d49334a Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Remove unused PCI ID from SOC header
by Subrata Banik (Code Review) 01 Jun '17

01 Jun '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19927 ) Change subject: soc/intel/apollolake: Remove unused PCI ID from SOC header ...................................................................... Patch Set 3: > Apparently this is a dupe: https://review.coreboot.org/#/c/19999/ :) first patch was on 26th May. not sure how this got missed. -- To view, visit https://review.coreboot.org/19927 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a86256641f4b877de32ca81dfdaef4e9d49334a Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017