Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19926 )
Change subject: mainboard/google/poppy: Enable H1 I2C TPM ......................................................................
mainboard/google/poppy: Enable H1 I2C TPM
Enable H1 I2C TPM in Kconfig and devicetree for poppy.
CQ-DEPEND=CL:513513,CL:*381534 BUG=b:36265511 BRANCH=None TEST=Compiles successfully.
Change-Id: I4c6c94fa05abf9f5374505ded5956e879ac79726 Signed-off-by: Furquan Shaikh furquan@chromium.org Reviewed-on: https://review.coreboot.org/19926 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nicolas Boichat drinkcat@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/baseboard/devicetree.cb 2 files changed, 8 insertions(+), 2 deletions(-)
Approvals: Aaron Durbin: Looks good to me, approved Nicolas Boichat: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index a947ec1..e133f9f 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -14,7 +14,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_USES_FSP2_0 select NO_FADT_8042 - select POPPY_USE_I2C_TPM if BOARD_GOOGLE_SORAKA + select POPPY_USE_I2C_TPM select SOC_INTEL_KABYLAKE
if BOARD_GOOGLE_BASEBOARD_POPPY diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb index 51dadda..4197437 100644 --- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb @@ -217,7 +217,13 @@ device i2c 4b on end end end # I2C #0 - device pci 15.1 on end # I2C #1 + device pci 15.1 on + chip drivers/i2c/tpm + register "hid" = ""GOOG0005"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E0_IRQ)" + device i2c 50 on end + end + end # I2C #1 device pci 15.2 on chip drivers/intel/mipi_camera register "acpi_hid" = ""INT3472""