coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/intel/common/block: Add Intel common smbus code
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19372 ) Change subject: soc/intel/common/block: Add Intel common smbus code ...................................................................... Patch Set 6: it seems very similar to what is attempted in https://review.coreboot.org/#/c/19258/ could it be more unified instead of having code in src/soc and src/soutbridge that is almost identical? -- To view, visit https://review.coreboot.org/19372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19494 ) Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... Patch Set 4: Maybe wrap line of install_int15_handler and clean headers in mainboard.c on x200, x201, x60, t60 too? -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82801ex: Remove unused southbridge code
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19507 ) Change subject: sb/intel/i82801ex: Remove unused southbridge code ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53059/ : SUCCESS -- To view, visit https://review.coreboot.org/19507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03a101adc1eedfa9669e0b44c54c2c6fa08bd5f2 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common smbus code
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19372 ) Change subject: soc/intel/common/block: Add Intel common smbus code ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53056/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8897/ : SUCCESS -- To view, visit https://review.coreboot.org/19372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Remove unused skylake_i2c_config structure
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19520 ) Change subject: soc/intel/skylake: Remove unused skylake_i2c_config structure ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53058/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8899/ : SUCCESS -- To view, visit https://review.coreboot.org/19520 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icde4b7af5b9c31020099c1a6372a6867827f61ae Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82801ex: Remove unused southbridge code
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Hello Philippe Mathieu-Daudé, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19507 to look at the new patch set (#2). Change subject: sb/intel/i82801ex: Remove unused southbridge code ...................................................................... sb/intel/i82801ex: Remove unused southbridge code The only board using this code was tyan s2735 which was removed in f76de841f1 "[REMOVAL] tyan/s2735", which featured a e7501 northbridge, which is also not in tree anymore since f338fa1f3 "intel/e7501: Remove unused northbridge code" Change-Id: I03a101adc1eedfa9669e0b44c54c2c6fa08bd5f2 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- D src/southbridge/intel/i82801ex/Kconfig D src/southbridge/intel/i82801ex/Makefile.inc D src/southbridge/intel/i82801ex/ac97.c D src/southbridge/intel/i82801ex/chip.h D src/southbridge/intel/i82801ex/early_smbus.c D src/southbridge/intel/i82801ex/ehci.c D src/southbridge/intel/i82801ex/i82801ex.c D src/southbridge/intel/i82801ex/i82801ex.h D src/southbridge/intel/i82801ex/ide.c D src/southbridge/intel/i82801ex/lpc.c D src/southbridge/intel/i82801ex/pci.c D src/southbridge/intel/i82801ex/reset.c D src/southbridge/intel/i82801ex/sata.c D src/southbridge/intel/i82801ex/smbus.c D src/southbridge/intel/i82801ex/smbus.h D src/southbridge/intel/i82801ex/uhci.c D src/southbridge/intel/i82801ex/watchdog.c 17 files changed, 0 insertions(+), 1,120 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/19507/2 -- To view, visit https://review.coreboot.org/19507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I03a101adc1eedfa9669e0b44c54c2c6fa08bd5f2 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/skylake: Remove unused skylake_i2c_config structure
by Furquan Shaikh (Code Review) 02 May '17

02 May '17

Furquan Shaikh has uploaded a new change for review. ( https://review.coreboot.org/19520 ) Change subject: soc/intel/skylake: Remove unused skylake_i2c_config structure ...................................................................... soc/intel/skylake: Remove unused skylake_i2c_config structure Remove struct skylake_i2c_config from chip.h since it is not used anymore. Change-Id: Icde4b7af5b9c31020099c1a6372a6867827f61ae Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/soc/intel/skylake/chip.h 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/19520/1 diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index cd461d4..b474ca2 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -40,15 +40,6 @@ I2C_VOLTAGE_1V8 }; -struct skylake_i2c_config { - /* Bus speed in Hz, default is I2C_SPEED_FAST (400 KHz) */ - enum i2c_speed speed; - /* Bus should be enabled prior to ramstage with temporary base */ - int early_init; - /* Custom bus speed configuration { scl_lcnt, scl_hcnt, sda_hold } */ - struct lpss_i2c_speed_config speed_config[LPSS_I2C_SPEED_CONFIG_COUNT]; -}; - struct soc_intel_skylake_config { /* * Interrupt Routing configuration -- To view, visit https://review.coreboot.org/19520 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icde4b7af5b9c31020099c1a6372a6867827f61ae Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Use intel/common/block/smbus code
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19373 ) Change subject: soc/intel/skylake: Use intel/common/block/smbus code ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53057/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8898/ : SUCCESS -- To view, visit https://review.coreboot.org/19373 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Use intel/common/block/smbus code
by Aamir Bohra (Code Review) 02 May '17

02 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19373 to look at the new patch set (#7). Change subject: soc/intel/skylake: Use intel/common/block/smbus code ...................................................................... soc/intel/skylake: Use intel/common/block/smbus code Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62 Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- M src/soc/intel/skylake/Kconfig M src/soc/intel/skylake/Makefile.inc M src/soc/intel/skylake/bootblock/pch.c D src/soc/intel/skylake/bootblock/smbus.c D src/soc/intel/skylake/early_smbus.c M src/soc/intel/skylake/include/soc/bootblock.h M src/soc/intel/skylake/include/soc/smbus.h D src/soc/intel/skylake/smbus.c D src/soc/intel/skylake/smbus_common.c 9 files changed, 4 insertions(+), 365 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/19373/7 -- To view, visit https://review.coreboot.org/19373 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2ca32ab594552424e4f1358302641f159a3d7e62 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common smbus code
by Aamir Bohra (Code Review) 02 May '17

02 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19372 to look at the new patch set (#6). Change subject: soc/intel/common/block: Add Intel common smbus code ...................................................................... soc/intel/common/block: Add Intel common smbus code Add below code support under intel/common/block: *Smbus read/write byte APIs *Common smbus initialization code Change-Id: I936143a334c31937d557c6828e5876d35b133567 Signed-off-by: Aamir Bohra <aamir.bohra(a)intel.com> --- A src/soc/intel/common/block/include/intelblocks/smbus.h A src/soc/intel/common/block/smbus/Kconfig A src/soc/intel/common/block/smbus/Makefile.inc A src/soc/intel/common/block/smbus/smbus.c A src/soc/intel/common/block/smbus/smbuslib.c 5 files changed, 334 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/19372/6 -- To view, visit https://review.coreboot.org/19372 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017