Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19372 )
Change subject: soc/intel/common/block: Add Intel common smbus code
......................................................................
Patch Set 6:
it seems very similar to what is attempted in https://review.coreboot.org/#/c/19258/
could it be more unified instead of having code in src/soc and src/soutbridge that is almost identical?
--
To view, visit https://review.coreboot.org/19372
To …
[View More]unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
[View Less]
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19494 )
Change subject: mb/lenvovo/*: Clean mainboard.c
......................................................................
Patch Set 4:
Maybe wrap line of install_int15_handler and clean headers in mainboard.c on x200, x201, x60, t60 too?
--
To view, visit https://review.coreboot.org/19494
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: …
[View More]I692a5632030fe2fedbe9a90f86251000f1360fb2
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No
[View Less]
Hello Philippe Mathieu-Daudé, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19507
to look at the new patch set (#2).
Change subject: sb/intel/i82801ex: Remove unused southbridge code
......................................................................
sb/intel/i82801ex: Remove unused southbridge code
The only board using this code was tyan s2735 which was removed in
f76de841f1 "[REMOVAL] tyan/s2735", which featured a e7501
…
[View More]northbridge, which is also not in tree anymore since f338fa1f3
"intel/e7501: Remove unused northbridge code"
Change-Id: I03a101adc1eedfa9669e0b44c54c2c6fa08bd5f2
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
D src/southbridge/intel/i82801ex/Kconfig
D src/southbridge/intel/i82801ex/Makefile.inc
D src/southbridge/intel/i82801ex/ac97.c
D src/southbridge/intel/i82801ex/chip.h
D src/southbridge/intel/i82801ex/early_smbus.c
D src/southbridge/intel/i82801ex/ehci.c
D src/southbridge/intel/i82801ex/i82801ex.c
D src/southbridge/intel/i82801ex/i82801ex.h
D src/southbridge/intel/i82801ex/ide.c
D src/southbridge/intel/i82801ex/lpc.c
D src/southbridge/intel/i82801ex/pci.c
D src/southbridge/intel/i82801ex/reset.c
D src/southbridge/intel/i82801ex/sata.c
D src/southbridge/intel/i82801ex/smbus.c
D src/southbridge/intel/i82801ex/smbus.h
D src/southbridge/intel/i82801ex/uhci.c
D src/southbridge/intel/i82801ex/watchdog.c
17 files changed, 0 insertions(+), 1,120 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/19507/2
--
To view, visit https://review.coreboot.org/19507
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03a101adc1eedfa9669e0b44c54c2c6fa08bd5f2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
[View Less]