coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge
by Marshall Dawson (Code Review) 02 May '17

02 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19157 to look at the new patch set (#15). Change subject: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge ...................................................................... amd/pi/00670F00: Add AMD PSP support for Stoney Ridge Add PSP communication support that is not covered by AGESA. The PSP must be notified DRAM is ready after amdinitpost(). Move amd_initcpuio() to the end of amdinitpost() so that the PSP decode for notify works. Change-Id: Icf111470b261d6516b878e88be471967abe681b3 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Signed-off-by: Marc Jones <marcj303(a)gmail.com> --- M src/cpu/amd/pi/00670F00/romstage.c M src/northbridge/amd/pi/00670F00/Makefile.inc A src/northbridge/amd/pi/00670F00/psp.c A src/northbridge/amd/pi/00670F00/psp.h M src/northbridge/amd/pi/agesawrapper.c 5 files changed, 304 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/19157/15 -- To view, visit https://review.coreboot.org/19157 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf111470b261d6516b878e88be471967abe681b3 Gerrit-PatchSet: 15 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19518 ) Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53052/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8893/ : SUCCESS -- To view, visit https://review.coreboot.org/19518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Enable H1 I2C TPM
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19519 ) Change subject: mainboard/google/poppy: Enable H1 I2C TPM ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53053/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8894/ : SUCCESS -- To view, visit https://review.coreboot.org/19519 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9947dce9b7f755971f0199f043af8d251d275ab Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM
by Furquan Shaikh (Code Review) 02 May '17

02 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19518 ) Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/Kconfig File src/mainboard/google/poppy/Kconfig: PS1, Line 25: config DRIVER_TPM_I2C_BUS : default 0x1 : : config DRIVER_TPM_I2C_ADDR : default 0x50 : > should these be conditional on POPPY_USE_I2C_TPM being true? Done https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/baseboard/gpio.c: PS1, Line 95: IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM > aren't USE_SPI_TPM and USE_I2C_TPM mutually exclusive and one of them guara Right now we have only mocktpm enabled for poppy, so both USE_SPI_TPM and USE_I2C_TPM are not true. That is why I did not combine the two blocks. -- To view, visit https://review.coreboot.org/19518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM
by Furquan Shaikh (Code Review) 02 May '17

02 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19518 to look at the new patch set (#2). Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ...................................................................... mainboard/google/poppy: Add support for cr50 I2C TPM 1. Add support for using cr50 I2C TPM on poppy. This will not be enabled until the next build. 2. Also, configure GPIOs for SPI and I2C TPM only if the corresponding Kconfig options are set. BUG=b:36265511 TEST=Verified on a reworked board that I2C TPM communication works fine. Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/gpio.c 3 files changed, 50 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/19518/2 -- To view, visit https://review.coreboot.org/19518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM
by Vadim Bendebury (Code Review) 02 May '17

02 May '17

Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/19518 ) Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ...................................................................... Patch Set 1: (2 comments) just a couple of nits/questions https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/Kconfig File src/mainboard/google/poppy/Kconfig: PS1, Line 25: config DRIVER_TPM_I2C_BUS : default 0x1 : : config DRIVER_TPM_I2C_ADDR : default 0x50 : should these be conditional on POPPY_USE_I2C_TPM being true? https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/baseboard/gpio.c: PS1, Line 95: IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM aren't USE_SPI_TPM and USE_I2C_TPM mutually exclusive and one of them guaranteed to be present for Poppy? Maybe it is enough to combine this conditional compilation section and the next one (starting in line 161) -- To view, visit https://review.coreboot.org/19518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mainboard/google/poppy: Add support for cr50 I2C TPM
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19518 ) Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53049/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8891/ : SUCCESS -- To view, visit https://review.coreboot.org/19518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b293b8d410a6973a6dfea393c17d0be425b6a28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Enable H1 I2C TPM
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19519 ) Change subject: mainboard/google/poppy: Enable H1 I2C TPM ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53051/ : SUCCESS -- To view, visit https://review.coreboot.org/19519 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9947dce9b7f755971f0199f043af8d251d275ab Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Update GPIO table for next build
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19517 ) Change subject: mainboard/google/poppy: Update GPIO table for next build ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53048/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8890/ : SUCCESS -- To view, visit https://review.coreboot.org/19517 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I949a14bfaa7972f2257a0b11ee81dcb0771e2f7f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Enable H1 I2C TPM
by Furquan Shaikh (Code Review) 02 May '17

02 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19519 ) Change subject: mainboard/google/poppy: Enable H1 I2C TPM ...................................................................... Patch Set 2: Code-Review-2 Need to wait until next build to submit this. Marking CR-2. -- To view, visit https://review.coreboot.org/19519 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9947dce9b7f755971f0199f043af8d251d275ab Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017