coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19500 to look at the new patch set (#12). Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... nb/intel/gm45: Set display backlight according to EDID string Add some known good values for some thinkpads displays. Known good means that at this pwm frequency the display is evenly lit on all duty cycles, the display makes minimal to no noise at lower duty cycles and the display does not flicker. This values differs from vendor (which uses an obviously wrong display clock (190MHz instead of 320MHz) resulting in frequency more than 60% off the intended value. Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t400/Makefile.inc A src/mainboard/lenovo/t400/blc.c M src/mainboard/lenovo/x200/Makefile.inc A src/mainboard/lenovo/x200/blc.c M src/mainboard/roda/rk9/Makefile.inc A src/mainboard/roda/rk9/blc.c M src/northbridge/intel/gm45/chip.h M src/northbridge/intel/gm45/gm45.h M src/northbridge/intel/gm45/gma.c 9 files changed, 150 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/19500/12 -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/#/c/19500/11/src/mainboard/lenovo/t400/blc.c File src/mainboard/lenovo/t400/blc.c: PS11, Line 21: set > at? incredible how much was wrong in that line... -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 ) Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... Patch Set 9: (4 comments) https://review.coreboot.org/#/c/19503/6/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c: PS6, Line 669: gtt_res > The original code would dereference the NULL in gma_pm_init_ ok. https://review.coreboot.org/#/c/19503/9/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c: Line 692: if (IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT)) { > Maybe move the whole if body into a new function to save an And passing pointer to edid_lvds as argument? PS9, Line 709: gtt_res && gtt_res->base && > ... this could be removed then. ok Line 710: && pio_res->base && lfb_res && lfb_res->base) { > We could also bail out here if anything is unset. This would save ok -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 9 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53041/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8884/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19499 to look at the new patch set (#11). Change subject: lib/edid: Save the display ASCII string ...................................................................... lib/edid: Save the display ASCII string Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/include/edid.h M src/lib/edid.c 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/19499/11 -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 11: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53040/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8883/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19500 to look at the new patch set (#11). Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... nb/intel/gm45: Set display backlight according to EDID string Add some known good values for some thinkpads displays. Known good means that at this pwm frequency the display is evenly lit on all duty cycles, the display makes minimal to no noise at lower duty cycles and the display does not flicker. This values differs from vendor (which uses an obviously wrong display clock (190MHz instead of 320MHz) resulting in frequency more than 60% off the intended value. Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/gma/edid.h M src/mainboard/lenovo/t400/Makefile.inc A src/mainboard/lenovo/t400/blc.c M src/mainboard/lenovo/x200/Makefile.inc A src/mainboard/lenovo/x200/blc.c M src/mainboard/roda/rk9/Makefile.inc A src/mainboard/roda/rk9/blc.c M src/northbridge/intel/gm45/chip.h M src/northbridge/intel/gm45/gma.c 9 files changed, 146 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/19500/11 -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 10: > (7 comments) > > Finally \o/ > > Regarding "known good", maybe add an option to use Vendor intended > vs. > coreboot recommended? It feels a little wrong to force values that > are > that far off the originals. I'm ok with that. Should it be the value that option rom attempts to use (you can extract that with intel_bios_reader) or the value that option rom actually sets using 190MHz cdclock? -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53037/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8880/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53039/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8882/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017