coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19500 to look at the new patch set (#8). Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... nb/intel/gm45: Set display backlight according to EDID string Add some known good values for some thinkpads displays. Known good means that at this pwm frequency the display is evenly lit on all duty cycles, the display makes minimal to no noise at lower duty cycles and the display does not flicker. This values differs from vendor (which uses an obviously wrong display clock (190MHz instead of 320MHz) resulting in frequency more than 60% off the intended value. Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/gma/edid.h M src/mainboard/lenovo/t400/Makefile.inc A src/mainboard/lenovo/t400/blc.c M src/mainboard/lenovo/x200/Makefile.inc A src/mainboard/lenovo/x200/blc.c M src/mainboard/roda/rk9/Makefile.inc A src/mainboard/roda/rk9/blc.c M src/northbridge/intel/gm45/gma.c 8 files changed, 141 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/19500/8 -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/19499/8/src/lib/edid.c File src/lib/edid.c: PS8, Line 1485: printk(BIOS_DEBUG,"ASCII string: %s\n", out->ascii_string); wups, debug code still here -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53033/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8876/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19503 ) Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53032/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8875/ : SUCCESS -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19499 to look at the new patch set (#8). Change subject: lib/edid: Save the display ASCII string ...................................................................... lib/edid: Save the display ASCII string Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/include/edid.h M src/lib/edid.c 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/19499/8 -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/19499/7/src/include/edid.h File src/include/edid.h: Line 92: char ascii_string[13]; > Needs additional space for null-termination. So with 14 spaces it will be automatically null-terminated ,given that 13 byte EDID strings are not? -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19503 to look at the new patch set (#8). Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... nb/intel/gm45/gma.c: Decode EDID before NGI path This allows to use EDID data outside of NGI path without needing to fetch it twice. Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/gm45/gma.c 1 file changed, 53 insertions(+), 59 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19503/8 -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19503 ) Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... Patch Set 7: (2 comments) https://review.coreboot.org/#/c/19503/6/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c: PS6, Line 669: gtt_res > It usually is guarded (and was in this function too before). it still is on the native path and was not guarded on gma_pm_init_post_vbios(), so nothing changed? Anyway I could guard against it since running option rom would fail too in that case I guess? https://review.coreboot.org/#/c/19503/7/src/northbridge/intel/gm45/gma.c File src/northbridge/intel/gm45/gma.c: Line 694: } > Just move it below, right before the VGA decision? ok -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/gigabyte/ga-g41m-es2l: Add timestamps in romstage
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19513 ) Change subject: mb/gigabyte/ga-g41m-es2l: Add timestamps in romstage ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53031/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8874/ : SUCCESS -- To view, visit https://review.coreboot.org/19513 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93f43a0af41ae86f1b8ba33e28f3b9f060a5ab5e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Remove very long delay
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19514 ) Change subject: nb/intel/x4x/raminit: Remove very long delay ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53030/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8873/ : SUCCESS -- To view, visit https://review.coreboot.org/19514 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idff5b978bbf161f8520d8000848e7b11c98c3945 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017