coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/gigabyte/ga-g41m-es2l: Add timestamps in romstage
by Arthur Heymans (Code Review) 01 May '17

01 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19513 ) Change subject: mb/gigabyte/ga-g41m-es2l: Add timestamps in romstage ...................................................................... mb/gigabyte/ga-g41m-es2l: Add timestamps in romstage Change-Id: I93f43a0af41ae86f1b8ba33e28f3b9f060a5ab5e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/gigabyte/ga-g41m-es2l/romstage.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/19513/1 diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c b/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c index 0a1470b..7c1259d 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c +++ b/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c @@ -134,6 +134,9 @@ u8 boot_path = 0; u8 s3_resume; + timestamp_init(get_initial_timestamp()); + timestamp_add_now(TS_START_ROMSTAGE); + /* Disable watchdog timer */ RCBA32(0x3410) = RCBA32(0x3410) | 0x20; @@ -159,7 +162,9 @@ boot_path = BOOT_PATH_WARM_RESET; printk(BIOS_DEBUG, "Initializing memory\n"); + timestamp_add_now(TS_BEFORE_INITRAM); sdram_initialize(boot_path, spd_addrmap); + timestamp_add_now(TS_AFTER_INITRAM); quick_ram_check(); printk(BIOS_DEBUG, "Memory initialized\n"); -- To view, visit https://review.coreboot.org/19513 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93f43a0af41ae86f1b8ba33e28f3b9f060a5ab5e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: drivers/{aspeed, xgi_z9s}/Kconfig: Don't override NATIVE_VGA_...
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19511 ) Change subject: drivers/{aspeed,xgi_z9s}/Kconfig: Don't override NATIVE_VGA_USE_EDID ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53025/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8868/ : SUCCESS -- To view, visit https://review.coreboot.org/19511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8d333a53a0dadcc94e47ca5460b23d49cf7eb52 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45/gma.c: Decode EDID before NGI path
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19503 ) Change subject: nb/intel/gm45/gma.c: Decode EDID before NGI path ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53024/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8867/ : SUCCESS -- To view, visit https://review.coreboot.org/19503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a540b1d036a9f38b44fd004309601630861f6e7 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53023/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8866/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53022/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8865/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/edid: Save the display ASCII string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19499 ) Change subject: lib/edid: Save the display ASCII string ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53020/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/8863/ : SUCCESS -- To view, visit https://review.coreboot.org/19499 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic31af53dcb9947e2264c809ee8f80ea4f89f347d Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53019/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8862/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/{aspeed, xgi_z9s}/Kconfig: Don't override NATIVE_VGA_...
by build bot (Jenkins) (Code Review) 01 May '17

01 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19511 ) Change subject: drivers/{aspeed,xgi_z9s}/Kconfig: Don't override NATIVE_VGA_USE_EDID ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53021/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/8864/ : SUCCESS -- To view, visit https://review.coreboot.org/19511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8d333a53a0dadcc94e47ca5460b23d49cf7eb52 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: cbmem: Add new command line flag to dump console for one boo...
by Furquan Shaikh (Code Review) 01 May '17

01 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19497 ) Change subject: cbmem: Add new command line flag to dump console for one boot only ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19497 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic17383507a884d84de9a2a880380cb15b25708a1 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: cbgfx: Add portrait screen support
by Martin Roth (Code Review) 01 May '17

01 May '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19474 ) Change subject: cbgfx: Add portrait screen support ...................................................................... cbgfx: Add portrait screen support cbgfx currently does not support portrait screen which height >width. so add it. Change-Id: I66fee6d73654e736a2db4a3d191f030c52a23e0d Signed-off-by: Nickey Yang <nickey.yang(a)rock-chips.com> Reviewed-on: https://review.coreboot.org/19474 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/libpayload/drivers/video/graphics.c 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Julius Werner: Looks good to me, approved build bot (Jenkins): Verified diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index 4a8792c..d4eaa09 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -154,18 +154,18 @@ screen.offset.x = 0; screen.offset.y = 0; - /* Calculate canvas size & offset, assuming the screen is landscape */ + /* Calculate canvas size & offset. Canvas is always square. */ if (screen.size.height > screen.size.width) { - const int bpl = fbinfo->bytes_per_line; - LOG("Portrait screen not supported, forcing square image!\n"); - memset(fbaddr + screen.size.width * bpl, 0, - (screen.size.height - screen.size.width) * bpl); - screen.size.height = screen.size.width; + canvas.size.height = screen.size.width; + canvas.size.width = canvas.size.height; + canvas.offset.x = 0; + canvas.offset.y = (screen.size.height - canvas.size.height) / 2; + } else { + canvas.size.height = screen.size.height; + canvas.size.width = canvas.size.height; + canvas.offset.x = (screen.size.width - canvas.size.width) / 2; + canvas.offset.y = 0; } - canvas.size.height = screen.size.height; - canvas.size.width = canvas.size.height; - canvas.offset.x = (screen.size.width - canvas.size.width) / 2; - canvas.offset.y = 0; initialized = 1; LOG("cbgfx initialized: screen:width=%d, height=%d, offset=%d canvas:width=%d, height=%d, offset=%d\n", -- To view, visit https://review.coreboot.org/19474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66fee6d73654e736a2db4a3d191f030c52a23e0d Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: nickey.yang(a)rock-chips.com Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shunqian Zheng <zhengsq(a)rock-chips.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: nickey.yang(a)rock-chips.com

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017