coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: drivers/pc80/tpm: Enable TPM device unconditionally in ASL
by Tobias Diedrich (Code Review) 02 May '17

02 May '17

Tobias Diedrich has posted comments on this change. ( https://review.coreboot.org/19235 ) Change subject: drivers/pc80/tpm: Enable TPM device unconditionally in ASL ...................................................................... Patch Set 6: > > Does the tpm work? > > Did you run a selftest? > > Can you get owernership? > > Could you please list the commands on how to test that? Right now, > judging from the Linux messages everything works on the Lenovo > X60t, besides sometimes resume, where the start-up is not done by > the coreboot. tpm_selftest is part of the tpm-tools package. Also this _might_ be helpful info: """ Initializing a TPM without the BIOS (for systems where the BIOS does not have TPM support). I couldn't find any docs for this, so it required quite a bit of trial-and-error. 1) Install tpm-tools (and trousers) 2) Boot into single-user mode (trousers only allows you to software-assert physical presence in single-user mode) 3) tpm_setpresence --assert --well-known 4) tpm_setenable --enable --force 5) tpm_setactive --enable --well-known 6) reboot! 7) Your TPM should now be enabled and active. """ -- To view, visit https://review.coreboot.org/19235 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If057c49c3b80f6d43702e2971d3a8ff198f8d3cc Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Denis 'GNUtoo' Carikli <GNUtoo(a)no-log.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/s230u: fix sata port map for the msata port
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19523 ) Change subject: mb/lenovo/s230u: fix sata port map for the msata port ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53063/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8902/ : SUCCESS -- To view, visit https://review.coreboot.org/19523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: gigabyte/ga-b75m-d3h: add tpm acknowledgement for its onboar...
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19521 ) Change subject: gigabyte/ga-b75m-d3h: add tpm acknowledgement for its onboard tpm socket. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53061/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8900/ : SUCCESS -- To view, visit https://review.coreboot.org/19521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dee74d945bae5d77eb669d8b9d468a67aee508 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/s230u: fix sata port map for the msata port
by Anonymous Coward (Code Review) 02 May '17

02 May '17

Anonymous Coward #1001586 has uploaded a new change for review. ( https://review.coreboot.org/19523 ) Change subject: mb/lenovo/s230u: fix sata port map for the msata port ...................................................................... mb/lenovo/s230u: fix sata port map for the msata port Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab Signed-off-by: persmule <persmule(a)gmail.com> --- M src/mainboard/lenovo/s230u/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/19523/1 diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index ff4c6c4..b9b38dd 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -52,7 +52,7 @@ register "pcie_hotplug_map" = "{ 0, 1, 0, 1, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" - register "sata_port_map" = "0x11" + register "sata_port_map" = "0x5" register "superspeed_capable_ports" = "0x0000000f" register "xhci_overcurrent_mapping" = "0x00000c03" register "xhci_switchable_ports" = "0x0000000f" -- To view, visit https://review.coreboot.org/19523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support.
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53062/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8901/ : SUCCESS -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support.
by Anonymous Coward (Code Review) 02 May '17

02 May '17

Anonymous Coward #1001586 has uploaded a new change for review. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support. ...................................................................... mb/gigabyte/ga-b75m-d3h: add libgfxinit support. Currently native video init works only on port HDMI1 wired to the on-board DVI-D socket, both text mode and fb mode. Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Signed-off-by: persmule <persmule(a)gmail.com> --- M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc A src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads 3 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/19522/1 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index e53b68c..a9fd50d 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -17,6 +17,7 @@ select INTEL_INT15 select UDELAY_TSC select SERIRQ_CONTINUOUS_MODE + select MAINBOARD_HAS_LIBGFXINIT config MMCONF_BASE_ADDRESS hex diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc b/src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc index d57c9b5..b5747e9 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Makefile.inc @@ -14,3 +14,4 @@ ## romstage-y += gpio.c +ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads \ No newline at end of file diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads b/src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads new file mode 100644 index 0000000..19f6bf9 --- /dev/null +++ b/src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads @@ -0,0 +1,17 @@ +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + ports : constant Port_List := + (DP1, + DP2, + HDMI1, + HDMI2, + Analog, + others => Disabled); + +end GMA.Mainboard; -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586

1 0

Change in coreboot[master]: gigabyte/ga-b75m-d3h: add tpm acknowledgement for its onboar...
by Anonymous Coward (Code Review) 02 May '17

02 May '17

Anonymous Coward #1001586 has uploaded a new change for review. ( https://review.coreboot.org/19521 ) Change subject: gigabyte/ga-b75m-d3h: add tpm acknowledgement for its onboard tpm socket. ...................................................................... gigabyte/ga-b75m-d3h: add tpm acknowledgement for its onboard tpm socket. Change-Id: Id0dee74d945bae5d77eb669d8b9d468a67aee508 Signed-off-by: persmule <persmule(a)gmail.com> --- M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/19521/1 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index e53b68c..bbc5db0 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -17,6 +17,7 @@ select INTEL_INT15 select UDELAY_TSC select SERIRQ_CONTINUOUS_MODE + select MAINBOARD_HAS_LPC_TPM config MMCONF_BASE_ADDRESS hex diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb b/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb index 2cd3816..3659354 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb +++ b/src/mainboard/gigabyte/ga-b75m-d3h/devicetree.cb @@ -109,6 +109,10 @@ device pnp 2e.7 off end # GPIO device pnp 2e.a off end # IR end + + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end end device pci 1f.2 on # SATA Controller 1 subsystemid 0x1458 0xb005 -- To view, visit https://review.coreboot.org/19521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0dee74d945bae5d77eb669d8b9d468a67aee508 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586

1 0

Change in coreboot[master]: nb/intel/pineview/raminit: Remove very long delays
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19505 ) Change subject: nb/intel/pineview/raminit: Remove very long delays ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53060/ : SUCCESS -- To view, visit https://review.coreboot.org/19505 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If089d6677fe95b086eeb00540acfbb66fa2e1c47 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Remove very long delay
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19514 ) Change subject: nb/intel/x4x/raminit: Remove very long delay ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19514/2//COMMIT_MSG Commit Message: Line 8: > When you know, why the delay was added in the first place, please add that No idea actually. My best guess is that serialICE was slow at some point, but since I have never successfully used serialICE I don't know if that theory is possibly valid. Fun fact: on resume from s3 with one dimm using i2c block read for spd it boots faster than that 250ms delay. -- To view, visit https://review.coreboot.org/19514 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idff5b978bbf161f8520d8000848e7b11c98c3945 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: nb/intel/pineview/raminit: Remove very long delays
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19505 to look at the new patch set (#2). Change subject: nb/intel/pineview/raminit: Remove very long delays ...................................................................... nb/intel/pineview/raminit: Remove very long delays These delays, adding up to 600 ms, don’t seem to be needed, so remove them. TESTED on d510mo, boots fine without. Change-Id: If089d6677fe95b086eeb00540acfbb66fa2e1c47 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/19505/2 -- To view, visit https://review.coreboot.org/19505 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If089d6677fe95b086eeb00540acfbb66fa2e1c47 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017