coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18523 ) Change subject: mainboard/pcengines/apu2: Add LPC TPM support ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53101/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8935/ : SUCCESS -- To view, visit https://review.coreboot.org/18523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18523 to look at the new patch set (#8). Change subject: mainboard/pcengines/apu2: Add LPC TPM support ...................................................................... mainboard/pcengines/apu2: Add LPC TPM support APU2 exposes a LPC header which can be used in conjunction with a LPC TPM module. Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/mainboard/pcengines/apu2/Kconfig M src/mainboard/pcengines/apu2/devicetree.cb M src/mainboard/pcengines/apu2/romstage.c 3 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/18523/8 -- To view, visit https://review.coreboot.org/18523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/pcengines/apu2: Add LPC TPM support
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18523 ) Change subject: mainboard/pcengines/apu2: Add LPC TPM support ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53100/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8934/ : SUCCESS -- To view, visit https://review.coreboot.org/18523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9312370a5071ffbeb6d83888c75fa69a0c27819 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi: Add AMD fam16h TPM ACPI path support
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18522 ) Change subject: amd/pi: Add AMD fam16h TPM ACPI path support ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53099/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8933/ : SUCCESS -- To view, visit https://review.coreboot.org/18522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi: Add AMD fam16h TPM ACPI path support
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Hello Philippe Mathieu-Daudé, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18522 to look at the new patch set (#4). Change subject: amd/pi: Add AMD fam16h TPM ACPI path support ...................................................................... amd/pi: Add AMD fam16h TPM ACPI path support Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/northbridge/amd/pi/00730F01/northbridge.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/amd/pi/hudson/pci_devs.h 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/18522/4 -- To view, visit https://review.coreboot.org/18522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5322d731a0dc655f2da14b87fa6cbc1e54b5abd5 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
by Anonymous Coward (Code Review) 03 May '17

03 May '17

Anonymous Coward #1001586 has posted comments on this change. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19522/3/src/mainboard/gigabyte/ga-b75m-d3h/… File src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads: Line 13: HDMI2, > If HDMI2 is not working, did you try HDMI3 too? The output of xrandr(1) is posted below: Screen 0: minimum 8 x 8, current 1360 x 768, maximum 32767 x 32767 DP1 disconnected primary (normal left inverted right x axis y axis) DP2 disconnected (normal left inverted right x axis y axis) HDMI1 disconnected (normal left inverted right x axis y axis) HDMI2 connected 1360x768+0+0 (normal left inverted right x axis y axis) 820mm x 460mm 1360x768 59.80*+ 1920x1080 60.00 60.00 50.00 59.94 1920x1080i 60.00 50.00 59.94 1600x1200 60.00 1680x1050 59.88 1280x1024 75.02 60.02 1440x900 59.90 1280x960 60.00 1280x800 59.91 1280x768 59.87 1280x720 60.00 50.00 59.94 1024x768 75.03 70.07 60.00 800x600 72.19 75.00 60.32 720x576 50.00 720x576i 50.00 720x480 60.00 59.94 720x480i 60.00 59.94 640x480 72.81 60.00 59.94 720x400 70.08 VGA1 disconnected (normal left inverted right x axis y axis) VIRTUAL1 disconnected (normal left inverted right x axis y axis) -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: Anonymous Coward #1001586 Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19535 ) Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53098/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8932/ : SUCCESS -- To view, visit https://review.coreboot.org/19535 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/pc80/tpm: Fix missing tis_close() function and TPM d...
by Philipp Deppenwiese (Code Review) 03 May '17

03 May '17

Philipp Deppenwiese has uploaded a new change for review. ( https://review.coreboot.org/19535 ) Change subject: drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. ...................................................................... drivers/pc80/tpm: Fix missing tis_close() function and TPM deactivation. tis_close() must be called after tis_open() otherwise the locked locality isn't released and the sessions hangs. The deactivate command of the TPM should be executed after the startup is done. So that we can be sure that the TPM exists and is functional. Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98 Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- M src/drivers/pc80/tpm/romstage.c 1 file changed, 17 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/19535/1 diff --git a/src/drivers/pc80/tpm/romstage.c b/src/drivers/pc80/tpm/romstage.c index a257ba1..9dcbf02 100644 --- a/src/drivers/pc80/tpm/romstage.c +++ b/src/drivers/pc80/tpm/romstage.c @@ -183,19 +183,6 @@ u32 result; u8 response[TPM_LARGE_ENOUGH_COMMAND_SIZE]; - if (IS_ENABLED(CONFIG_TPM_DEACTIVATE)) { - printk(BIOS_SPEW, "TPM: Deactivate\n"); - result = TlclSendReceive(tpm_deactivate_cmd.buffer, - response, sizeof(response)); - if (result == TPM_SUCCESS) { - printk(BIOS_SPEW, "TPM: OK.\n"); - return; - } - - printk(BIOS_ERR, "TPM: Error code 0x%x.\n", result); - return; - } - /* Doing TPM startup when we're not coming in on the S3 resume path * saves us roughly 20ms in boot time only. This does not seem to * be worth an API change to vboot_reference-firmware right now, so @@ -215,7 +202,6 @@ if (tis_open()) return; - if (s3resume) { /* S3 Resume */ printk(BIOS_SPEW, "TPM: Resume\n"); @@ -226,6 +212,7 @@ * in S3, so it's already initialized. */ printk(BIOS_DEBUG, "TPM: Already initialized.\n"); + tis_close(); return; } } else { @@ -235,7 +222,23 @@ } if (result == TPM_SUCCESS) { + if (IS_ENABLED(CONFIG_TPM_DEACTIVATE)) { + printk(BIOS_SPEW, "TPM: Deactivate\n"); + result = TlclSendReceive(tpm_deactivate_cmd.buffer, + response, sizeof(response)); + if (result == TPM_SUCCESS) { + printk(BIOS_SPEW, "TPM: OK.\n"); + tis_close(); + return; + } + + printk(BIOS_ERR, "TPM: Error code 0x%x.\n", result); + tis_close(); + return; + } + printk(BIOS_SPEW, "TPM: OK.\n"); + tis_close(); return; } -- To view, visit https://review.coreboot.org/19535 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a06f6a29015708e4bc1de6e6678827c28b84e98 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: nb/intel/pineview/raminit: Remove very long delays
by Philippe Mathieu-Daudé (Code Review) 03 May '17

03 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19505 ) Change subject: nb/intel/pineview/raminit: Remove very long delays ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/19505 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If089d6677fe95b086eeb00540acfbb66fa2e1c47 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation/Intel: Add vboot documentation
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19534 ) Change subject: Documentation/Intel: Add vboot documentation ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53097/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8931/ : SUCCESS -- To view, visit https://review.coreboot.org/19534 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie17b8443772f596de0c9d8afe6f4ec3ac4d4fef8 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017