coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
by Bill XIE (Code Review) 03 May '17

03 May '17

Bill XIE has posted comments on this change. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/19522/3/src/mainboard/gigabyte/ga-b75m-d3h/… File src/mainboard/gigabyte/ga-b75m-d3h/gma-mainboard.ads: PS3, Line 10: (DP1, : DP2, > They are, the pins on the PCH are always DP++. Since your DVI-D So the statements for DPs can actually be removed? Line 13: HDMI2, > Linux can skip gaps in the numbering. So what you see in xrandr But can this output prove that there is no HDMI3? -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/apollolake: Use XDCI common code
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19429 ) Change subject: soc/intel/apollolake: Use XDCI common code ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53104/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8937/ : SUCCESS -- To view, visit https://review.coreboot.org/19429 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4649bffe1bb90d7df6a72b5334793bf8f0fdbaeb Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use intel/common/xhci driver
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19427 ) Change subject: soc/intel/apollolake: Use intel/common/xhci driver ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53103/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8938/ : SUCCESS -- To view, visit https://review.coreboot.org/19427 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccb6b6c8c002701d17444fcf62ec11315e5aeed9 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: common/block/xhci: Get XHCI PCI ID from device/pci_ids.h
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19536 ) Change subject: common/block/xhci: Get XHCI PCI ID from device/pci_ids.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53105/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8939/ : SUCCESS -- To view, visit https://review.coreboot.org/19536 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33d92a173055ea18b8675c720f01dd5bc77befa3 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support
by build bot (Jenkins) (Code Review) 03 May '17

03 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19428 ) Change subject: soc/intel/common/block: Add Intel XDCI code support ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53102/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8936/ : SUCCESS -- To view, visit https://review.coreboot.org/19428 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support
by Subrata Banik (Code Review) 03 May '17

03 May '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 ) Change subject: soc/intel/common/block: Add Intel XDCI code support ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/include/… File src/soc/intel/common/block/include/intelblocks/xdci.h: Line 22: > one too many new lines? Done https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/xdci/xdc… File src/soc/intel/common/block/xdci/xdci.c: PS1, Line 33: 0x5aaa, /* ApolloLake */ : 0x31aa, /* GLK */ : 0x9d30, /* SunRisePoint LP */ > I've mentioned this in other CLs. I think it'd be good to move all of these Done Line 42: .devices = pci_device_ids, > It's interesting we're repeating the boiler plate and then only providing a make sense, but only concern is that init/some APIs which may need to implement inside SOC as an overridden mechanism. Implementing those might be little tricky because of some many like this static struct device_operations usb_xdci_ops = { .read_resources = &pci_dev_read_resources, .set_resources = &pci_dev_set_resources, .enable_resources = &pci_dev_enable_resources, #if (pci_device_ids == XDCI) .init = soc_xdci_init, #if (pci_device_ids == XHCI) .init = soc_xhci_init, #if (pci_device_ids == XYZZ) .init = soc_xyzz_init, }; -- To view, visit https://review.coreboot.org/19428 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: common/block/xhci: Get XHCI PCI ID from device/pci_ids.h
by Subrata Banik (Code Review) 03 May '17

03 May '17

Subrata Banik has uploaded a new change for review. ( https://review.coreboot.org/19536 ) Change subject: common/block/xhci: Get XHCI PCI ID from device/pci_ids.h ...................................................................... common/block/xhci: Get XHCI PCI ID from device/pci_ids.h Change-Id: I33d92a173055ea18b8675c720f01dd5bc77befa3 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/include/device/pci_ids.h M src/soc/intel/common/block/xhci/xhci.c 2 files changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/19536/1 diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index fe5245a..910d058 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2659,12 +2659,18 @@ #define PCI_DEVICE_ID_INTEL_LYNXPOINT_MOB_DESK_MAX 0x8c4f /* Intel Skylake Device IDS */ +#define PCI_DEVICE_ID_INTEL_SKYLAKE_LP_XHCI 0x9d2f #define PCI_DEVICE_ID_INTEL_SKYLAKE_LP_XDCI 0x9d30 +/* Intel Kabylake Device IDS */ +#define PCI_DEVICE_ID_INTEL_KABYLAKE_H_XHCI 0xa12f + /* Intel Apollolake Device IDS */ +#define PCI_DEVICE_ID_INTEL_APOLLOLAKE_XHCI 0x5aa8 #define PCI_DEVICE_ID_INTEL_APOLLOLAKE_XDCI 0x5aaa /* Intel GLK Device IDS */ +#define PCI_DEVICE_ID_INTEL_GLK_XHCI 0x31a8 #define PCI_DEVICE_ID_INTEL_GLK_XDCI 0x31aa #define PCI_VENDOR_ID_COMPUTONE 0x8e0e diff --git a/src/soc/intel/common/block/xhci/xhci.c b/src/soc/intel/common/block/xhci/xhci.c index 32fad93..d389aac 100644 --- a/src/soc/intel/common/block/xhci/xhci.c +++ b/src/soc/intel/common/block/xhci/xhci.c @@ -30,10 +30,10 @@ }; static const unsigned short pci_device_ids[] = { - 0x5aa8, /* ApolloLake */ - 0x31a8, /* GLK */ - 0x9d2f, /* SunRisePoint LP */ - 0xa12f, /* KBL-H*/ + PCI_DEVICE_ID_INTEL_APOLLOLAKE_XHCI, + PCI_DEVICE_ID_INTEL_GLK_XHCI, + PCI_DEVICE_ID_INTEL_SKYLAKE_LP_XHCI, + PCI_DEVICE_ID_INTEL_KABYLAKE_H_XHCI, 0 }; -- To view, visit https://review.coreboot.org/19536 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33d92a173055ea18b8675c720f01dd5bc77befa3 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Use intel/common/xhci driver
by Subrata Banik (Code Review) 03 May '17

03 May '17

Hello Aaron Durbin, Barnali Sarkar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19427 to look at the new patch set (#2). Change subject: soc/intel/apollolake: Use intel/common/xhci driver ...................................................................... soc/intel/apollolake: Use intel/common/xhci driver Change-Id: Iccb6b6c8c002701d17444fcf62ec11315e5aeed9 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc M src/soc/intel/apollolake/include/soc/pci_ids.h D src/soc/intel/apollolake/xhci.c 4 files changed, 1 insertion(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/19427/2 -- To view, visit https://review.coreboot.org/19427 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iccb6b6c8c002701d17444fcf62ec11315e5aeed9 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Use XDCI common code
by Subrata Banik (Code Review) 03 May '17

03 May '17

Hello Aaron Durbin, Barnali Sarkar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19429 to look at the new patch set (#2). Change subject: soc/intel/apollolake: Use XDCI common code ...................................................................... soc/intel/apollolake: Use XDCI common code This patch performs apollolake specific XDCI controller initialization. Change-Id: I4649bffe1bb90d7df6a72b5334793bf8f0fdbaeb Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/include/soc/pci_ids.h M src/soc/intel/apollolake/xdci.c 3 files changed, 7 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/19429/2 -- To view, visit https://review.coreboot.org/19429 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4649bffe1bb90d7df6a72b5334793bf8f0fdbaeb Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support
by Subrata Banik (Code Review) 03 May '17

03 May '17

Hello Barnali Sarkar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19428 to look at the new patch set (#2). Change subject: soc/intel/common/block: Add Intel XDCI code support ...................................................................... soc/intel/common/block: Add Intel XDCI code support XDCI MMIO offsets definitions are not alike between various SoCs hence provided "soc_xdci_init" function to implement SoC specific initialization. Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/include/device/pci_ids.h A src/soc/intel/common/block/include/intelblocks/xdci.h A src/soc/intel/common/block/xdci/Kconfig A src/soc/intel/common/block/xdci/Makefile.inc A src/soc/intel/common/block/xdci/xdci.c 5 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/19428/2 -- To view, visit https://review.coreboot.org/19428 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017